Version: 2.3.0 (using 4.4.2 (KDE 4.4.2), Kubuntu packages) Compiler: cc OS: Linux (x86_64) release 2.6.32-22-generic using ubuntu 10.04 64 bit since i am using the final release of 10.04 (clean install) no last.fm userdata will be saved :( authorization of the last.fm account works fine, but after continuing by clicking OK nothing is saved
Is that still a problem in 2.3.1 beta 1?
Am 01.05.2010 09:21, schrieb Sven Krohlas: > https://bugs.kde.org/show_bug.cgi?id=235861 > > > Sven Krohlas<sven@asbest-online.de> changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > CC| |kde@dontletsstart.com, > | |lfranchi@kde.org, > | |parallelgrapefruit@gmail.co > | |m > Component|general |Services/Last.fm > > > > > --- Comment #1 from Sven Krohlas<sven asbest-online de> 2010-05-01 09:21:01 --- > Is that still a problem in 2.3.1 beta 1? > > japp, auch noch in der 2.3.1 beta 1 version werden last.fm name und passwort nicht gespeichert.
English, please. ;-)
Am 02.05.2010 11:29, schrieb Sven Krohlas: > https://bugs.kde.org/show_bug.cgi?id=235861 > > > Sven Krohlas<sven@asbest-online.de> changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > Version|2.3.0 |2.3.0.90 > > > > > --- Comment #3 from Sven Krohlas<sven asbest-online de> 2010-05-02 11:29:05 --- > English, please. ;-) > > ok, it still doesn't work in version 2.3.0.90 ;)
*** Bug 237693 has been marked as a duplicate of this bug. ***
commit 021e38aeb66ff162b892cd66ac0bee6d75891df6 Author: Casey Link <unnamedrambler@gmail.com> Date: Fri May 28 17:53:12 2010 -0500 Ensure last.fm settings are written to disk when saving. This hopefully will fix the issue of the last.fm service not working without KWallet. CCBUG: 235861 diff --git a/src/services/lastfm/LastFmServiceConfig.cpp b/src/services/lastfm/LastFmServiceConfig.cpp index c5dec70..67147d4 100644 --- a/src/services/lastfm/LastFmServiceConfig.cpp +++ b/src/services/lastfm/LastFmServiceConfig.cpp @@ -119,6 +119,7 @@ void LastFmServiceConfig::save() { debug() << "Could not access the wallet to save the last.fm credentials"; } + config.sync(); } void
I'm afraid this is still broken in recent GIT. I did a clean build and a clean install a few hours ago (a2d1a78) and I am experiencing the exact same problem.
Setting to confirmed.
Had the same problem with today's git version after I've removed the amarok settings files. And I guess the MySQL settings (username/password) have the same problem.
*** Bug 246372 has been marked as a duplicate of this bug. ***
Still a problem in Amarok 2.3.2 (Ubuntu)
(In reply to comment #11) > Still a problem in Amarok 2.3.2 (Ubuntu) Impossible, Amarok 2.3.2 is not released, you either have 2.3.1 or 2.3.2 beta (aka 2.3.1.90)
It's 2.3.1.
Probably not surprising: Problem also appears in osx10.6.4, amarok2.3.1, kde4.4.5 from macports.
*** Bug 236243 has been marked as a duplicate of this bug. ***
commit 0a7a673fe2b1dfda7489b19e4f792a2359e81e62 Author: Mark Kretschmann <kretschmann@kde.org> Date: Sat Sep 4 15:37:07 2010 +0200 Make the Last.fm service work without KWallet. This was broken because the wrong signals were used in the confirmation dialog. BUG: 235861 diff --git a/ChangeLog b/ChangeLog index 2c95b9a..39f132d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -12,6 +12,7 @@ VERSION 2.3.2 * Use system date/time format for default name when saving user playlists. BUGFIXES: + * The Last.fm service did not work without KWallet. (BR 235861) * Show actual KDE version in the "About Amarok" dialog, instead of the version used at compile time. * Fixed a crash when trying to save a playlist to a file where the format diff --git a/src/services/lastfm/LastFmServiceConfig.cpp b/src/services/lastfm/LastFmServiceConfig.cpp index 6847a33..6ac3ff6 100644 --- a/src/services/lastfm/LastFmServiceConfig.cpp +++ b/src/services/lastfm/LastFmServiceConfig.cpp @@ -50,6 +50,8 @@ LastFmServiceConfig::LastFmServiceConfig() LastFmServiceConfig::~LastFmServiceConfig() { + DEBUG_BLOCK + if( m_askDiag ) m_askDiag->deleteLater(); if( m_wallet ) @@ -141,8 +143,8 @@ LastFmServiceConfig::askAboutMissingKWallet() m_askDiag->setButtons( KDialog::Yes | KDialog::No ); m_askDiag->setModal( true ); - connect( m_askDiag, SIGNAL( okClicked() ), this, SLOT( textDialogOK() ) ); - connect( m_askDiag, SIGNAL( cancelClicked() ), this, SLOT( textDialogCancel() ) ); + connect( m_askDiag, SIGNAL( yesClicked() ), this, SLOT( textDialogYes() ) ); + connect( m_askDiag, SIGNAL( noClicked() ), this, SLOT( textDialogNo() ) ); } m_askDiag->exec(); } @@ -161,8 +163,10 @@ LastFmServiceConfig::reset() void -LastFmServiceConfig::textDialogOK() +LastFmServiceConfig::textDialogYes() //SLOT { + DEBUG_BLOCK + KConfigGroup config = KGlobal::config()->group( configSectionName() ); config.writeEntry( "ignoreWallet", "yes" ); config.sync(); @@ -170,8 +174,10 @@ LastFmServiceConfig::textDialogOK() void -LastFmServiceConfig::textDialogCancel() +LastFmServiceConfig::textDialogNo() //SLOT { + DEBUG_BLOCK + KConfigGroup config = KGlobal::config()->group( configSectionName() ); config.writeEntry( "ignoreWallet", "no" ); config.sync(); diff --git a/src/services/lastfm/LastFmServiceConfig.h b/src/services/lastfm/LastFmServiceConfig.h index 642410e..99b46c2 100644 --- a/src/services/lastfm/LastFmServiceConfig.h +++ b/src/services/lastfm/LastFmServiceConfig.h @@ -57,8 +57,8 @@ public: void setFetchSimilar( bool fetchSimilar ) { m_fetchSimilar = fetchSimilar; } private slots: - void textDialogOK(); - void textDialogCancel(); + void textDialogYes(); + void textDialogNo(); private: void askAboutMissingKWallet();