Bug 234600 - zoom does not change row height (size), when in details view. It overlap previews
Summary: zoom does not change row height (size), when in details view. It overlap prev...
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 16.12.2
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Peter Penz
URL:
Keywords: investigated, reproducible
: 250017 253289 259399 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-04-17 10:47 UTC by Pedro Jiménez
Modified: 2010-12-10 14:52 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.5.3


Attachments
Suggested fix (1.19 KB, patch)
2010-10-04 22:34 UTC, Frank Reininghaus
Details
Alternative fix (978 bytes, patch)
2010-10-04 23:17 UTC, Frank Reininghaus
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Jiménez 2010-04-17 10:47:25 UTC
Version:           1.4 (using KDE 4.4.2)
Compiler:          cc 
OS:                Linux
Installed from:    Ubuntu Packages

Open Dolphin, choose View->View Mode->Details, select a file (or a picture file), and use the zoom to enlarge the views. The previews grow, but the rows height doesn't, and so the pictures previews overlap, generating a mess of previews. 

You can now change to Icons view and come back to Details view. If no file is selected, zoom on previews works fine. But selecting a file, it works wrong again. 

Using the zoom to reduce preview always works fine.
Comment 1 Frank Reininghaus 2010-04-18 17:27:15 UTC
Thanks for the bug report! I can confirm this problem in current trunk.
Comment 2 Alessandro Molari 2010-06-09 17:27:18 UTC
I found the same problem. If you refresh the page the rows height would be ok.

So I think the issue is that rows aren't refreshed when you use the slider to zoom-in
Comment 3 Pedro Jiménez 2010-06-09 17:47:06 UTC
I don't think the problem is that rows aren't refreshed. Rows do actually change its size when moving the slider, if you make previews smaller and bigger again.

Make icons size to 128 pixels, for example. Then move down and up the preview size slider. The rows change size, up to a maximum to fit the 128 pixels preview.

It also has some estrange behaviour when the scroll bars appear of disappear.
Comment 4 Pedro Jiménez 2010-09-05 10:55:47 UTC
Dolphin 1.5 with KDE 4.5.1 still shows the problem
Comment 5 Frank Reininghaus 2010-09-06 13:42:03 UTC
Yes, you're right. It's still reproducible in trunk as well. I think it might be related to the recently reported bug 250017.
Comment 6 Peter Penz 2010-09-23 14:48:38 UTC
I've investigated into this issue already and it looks like a bug in QTreeView. However I did not find the time yet to confirm this to 100 % :-(
Comment 7 Pedro Jiménez 2010-09-23 17:48:41 UTC
I'm using the QTreeView with detailed view mode (with QT4.7.0, KDE 4.5.1) for other projects, this row resizing error does NOT happen when changing the icon size. I use the property 
treeview->setIconSize(QSize(value, value));
And it works perfectly. The rows are resized as needed.
However, it does not work correctly with my Dolphin (version 1.5) neither Konqueror (v 4.5.1).

On the other hand, a college of me has kde 4.3.2, Dolphin 1.3 and QT 4.5.2, and row resizing works correctly both for Dolphin and the QTreeView objects we use in our projects.
Comment 8 Frank Reininghaus 2010-10-04 22:27:51 UTC
*** Bug 250017 has been marked as a duplicate of this bug. ***
Comment 9 Frank Reininghaus 2010-10-04 22:34:44 UTC
Created attachment 52223 [details]
Suggested fix

I'm afraid it's my fault. This is a regression (since 4.4.1) caused by my fix for bug 226666. Sorry to everyone for the trouble.

@Peter: could you have a look at my suggested changes to DolphinDetailsView::updateDecorationSize(...) and DolphinDetailsView::adjustMaximumSizeForEditing(...)? Just to make sure that I don't cause another regression ;-)
Comment 10 Frank Reininghaus 2010-10-04 23:17:55 UTC
Created attachment 52224 [details]
Alternative fix

Maybe this fix is a bit more elegant because it does not set the height of maximumSize "by hand".
Comment 11 Frank Reininghaus 2010-10-05 16:25:31 UTC
*** Bug 253289 has been marked as a duplicate of this bug. ***
Comment 12 Peter Penz 2010-10-05 16:33:35 UTC
Thanks Frank for investigating into this! I think the "Alternate fix" looks fine, please commit :-)
Comment 13 Frank Reininghaus 2010-10-05 19:55:27 UTC
SVN commit 1182797 by freininghaus:

Prevent that icons overlap in Details View when zooming.

The problem was that a maximum size was assigned to KFileItemDelegate
for displaying items without considering that icon zooming may change
the item height.

CCBUG: 234600


 M  +12 -0     dolphindetailsview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1182797
Comment 14 Frank Reininghaus 2010-10-05 19:55:56 UTC
SVN commit 1182798 by freininghaus:

Prevent that icons overlap in Details View when zooming.

The problem was that a maximum size was assigned to KFileItemDelegate
for displaying items without considering that icon zooming may change
the item height.

BUG: 234600
FIXED-IN: 4.5.3


 M  +12 -0     dolphindetailsview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1182798
Comment 15 Frank Reininghaus 2010-12-10 14:52:29 UTC
*** Bug 259399 has been marked as a duplicate of this bug. ***