234555 – track details dialog doesn't respect KDE 4 label alignament.

Bug 234555 - track details dialog doesn't respect KDE 4 label alignament.

Summary: track details dialog doesn't respect KDE 4 label alignament.

Status:	RESOLVED FIXED

Alias:	None

Product:	amarok
Classification:	Applications
Component:	Metadata Editing and Reading (show other bugs)
Version:	unspecified
Platform:	Compiled Sources Linux

Importance:	NOR normal
Target Milestone:	---
Assignee:	Amarok Developers

URL:
Keywords:

Depends on:
Blocks:

Reported:	2010-04-16 20:10 UTC by Davide Bettio
Modified:	2010-05-29 10:34 UTC (History)
CC List:	0 users

See Also:
Latest Commit:
Version Fixed In:	2.3.2

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.

Description Davide Bettio 2010-04-16 20:10:05 UTC

Version:            (using Devel)
OS:                Linux
Installed from:    Compiled sources

Track dettails dialog doesn't respect KDE 4 label alignament. Every label is aligned on the left but they should be aligned to the right as described in KDE 4 UIG.

Comment 1 Sven Krohlas 2010-04-20 23:39:39 UTC

Version?

Comment 2 Casey Link 2010-05-29 02:01:03 UTC

commit 1369dd39e021549edf2c5fc2c5cbe2abc97acc22
Author: Casey Link <unnamedrambler@gmail.com>
Date:   Fri May 28 18:33:33 2010 -0500

    Align track details dialog's labels to the right as per KDE4's HIG.
    
    BUG: 234555

diff --git a/src/dialogs/TagDialogBase.ui b/src/dialogs/TagDialogBase.ui
index ff3a3db..4b33809 100644
--- a/src/dialogs/TagDialogBase.ui
+++ b/src/dialogs/TagDialogBase.ui
@@ -160,6 +160,9 @@
            <property name="text">
             <string>T&amp;itle:</string>
            </property>
+           <property name="alignment">
+            <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
+           </property>
            <property name="wordWrap">
             <bool>false</bool>
            </property>
@@ -176,6 +179,9 @@
            <property name="text">
             <string>&amp;Artist:</string>
            </property>
+           <property name="alignment">
+            <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
+           </property>
            <property name="wordWrap">
             <bool>false</bool>
            </property>
@@ -205,6 +211,9 @@
            <property name="text">
             <string>&amp;Composer:</string>
            </property>
+           <property name="alignment">
+            <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
+           </property>
            <property name="wordWrap">
             <bool>false</bool>
            </property>
@@ -231,6 +240,9 @@
            <property name="text">
             <string>Al&amp;bum:</string>
            </property>
+           <property name="alignment">
+            <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
+           </property>
            <property name="wordWrap">
             <bool>false</bool>
            </property>
@@ -274,7 +286,7 @@
                 <string>&amp;Disc Number:</string>
                </property>
                <property name="alignment">
-                <set>Qt::AlignLeading|Qt::AlignLeft|Qt::AlignVCenter</set>
+                <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
                </property>
                <property name="wordWrap">
                 <bool>false</bool>
@@ -285,19 +297,6 @@
               </widget>
              </item>
              <item>
-              <spacer name="horizontalSpacer_6">
-               <property name="orientation">
-                <enum>Qt::Horizontal</enum>
-               </property>
-               <property name="sizeHint" stdset="0">
-                <size>
-                 <width>40</width>
-                 <height>20</height>
-                </size>
-               </property>
-              </spacer>
-             </item>
-             <item>
               <widget class="QSpinBox" name="qSpinBox_discNumber">
                <property name="sizePolicy">
                 <sizepolicy hsizetype="Fixed" vsizetype="Fixed">
@@ -362,6 +361,9 @@
                <property name="text">
                 <string>B&amp;eats Per Minute:</string>
                </property>
+               <property name="alignment">
+                <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
+               </property>
                <property name="buddy">
                 <cstring>kLineEdit_Bpm</cstring>
                </property>
@@ -436,6 +438,9 @@
            <property name="text">
             <string>&amp;Genre:</string>
            </property>
+           <property name="alignment">
+            <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
+           </property>
            <property name="wordWrap">
             <bool>false</bool>
            </property>
@@ -452,6 +457,9 @@
            <property name="textFormat">
             <enum>Qt::PlainText</enum>
            </property>
+           <property name="alignment">
+            <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
+           </property>
            <property name="wordWrap">
             <bool>false</bool>
            </property>
@@ -486,6 +494,9 @@
              <property name="text">
               <string>&amp;Year:</string>
              </property>
+             <property name="alignment">
+              <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
+             </property>
              <property name="wordWrap">
               <bool>false</bool>
              </property>
@@ -523,6 +534,9 @@
            <property name="textFormat">
             <enum>Qt::PlainText</enum>
            </property>
+           <property name="alignment">
+            <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
+           </property>
            <property name="wordWrap">
             <bool>false</bool>
            </property>
@@ -618,6 +632,9 @@
                  <property name="text">
                   <string>Score:</string>
                  </property>
+                 <property name="alignment">
+                  <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
+                 </property>
                  <property name="wordWrap">
                   <bool>false</bool>
                  </property>
@@ -647,6 +664,9 @@
                  <property name="text">
                   <string>Rating:</string>
                  </property>
+                 <property name="alignment">
+                  <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
+                 </property>
                  <property name="wordWrap">
                   <bool>false</bool>
                  </property>
@@ -739,7 +759,7 @@
                 <string>Label:</string>
                </property>
                <property name="alignment">
-                <set>Qt::AlignLeading|Qt::AlignLeft|Qt::AlignVCenter</set>
+                <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
                </property>
               </widget>
              </item>
@@ -859,6 +879,9 @@
          <property name="text">
           <string>Location:</string>
          </property>
+         <property name="alignment">
+          <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
+         </property>
          <property name="wordWrap">
           <bool>false</bool>
          </property>