Bug 228583 - Bovo stores its icon in oxygen instead of in hicolor icon set
Summary: Bovo stores its icon in oxygen instead of in hicolor icon set
Status: RESOLVED FIXED
Alias: None
Product: bovo
Classification: Applications
Component: general (show other bugs)
Version: 0.6
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Pelladi Gabor
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-26 09:08 UTC by Jeremy Bicha
Modified: 2010-03-02 18:08 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Bicha 2010-02-26 09:08:31 UTC
Version:           0.6 (using 4.4.00 (KDE 4.4.0), Kubuntu packages)
Compiler:          cc
OS:                Linux (x86_64) release 2.6.32-14-generic

Bovo stores its icon in the oxygen icon set instead of in hicolor. This means that if someone is not using the oxygen icons, then they won't have an icon for Bovo. For instance, if a user wants kdegames installed but is using Gnome as their desktop environment, they will get a missing icon in the menu for Bovo instead of the regular application icon.

I think this line in KDE/kdegames/bomber/src/CMakeLists.txt needs to be changed for this to work properly:

kde4_add_app_icon(bovogui_SRCS "${KDE4_ICON_DIR}/oxygen/*/apps/bovo.png")
Comment 1 Pelladi Gabor 2010-03-02 17:08:17 UTC
SVN commit 1097996 by gpelladi:

BUG: 228583
Add icons for bovo, like other games do.

 M  +1 -1      AUTHORS  
 M  +18 -11    CMakeLists.txt  
 M  +1 -1      gui/version.h  
 A             icons (directory)  
 A             icons/CMakeLists.txt  
 AM            icons/hi128-app-bovo.png  
 AM            icons/hi16-app-bovo.png  
 AM            icons/hi22-app-bovo.png  
 AM            icons/hi32-app-bovo.png  
 AM            icons/hi48-app-bovo.png  
 AM            icons/hi64-app-bovo.png  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1097996
Comment 2 Pelladi Gabor 2010-03-02 17:17:18 UTC
SVN commit 1097999 by gpelladi:

BUG: 228583
Add icons for bovo, like other games do.

 M  +1 -1      AUTHORS  
 M  +18 -11    CMakeLists.txt  
 M  +1 -1      gui/version.h  
 A             icons (directory)   branches/KDE/4.4/kdegames/bovo/icons#1097996


WebSVN link: http://websvn.kde.org/?view=rev&revision=1097999
Comment 3 Pelladi Gabor 2010-03-02 18:08:24 UTC
Fixed in 4.4 branch and trunk. 4.4.1 has been already tagged, so KDE 4.4.2 will include the fix first.