Bug 225426 - Ark treats single-file archives as non-single-folder archive
Summary: Ark treats single-file archives as non-single-folder archive
Status: RESOLVED FIXED
Alias: None
Product: ark
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Unspecified
: NOR normal
Target Milestone: ---
Assignee: Raphael Kubo da Costa
URL:
Keywords:
: 240770 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-02-03 20:29 UTC by Silver Salonen
Modified: 2010-06-14 06:46 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.4.5


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Silver Salonen 2010-02-03 20:29:17 UTC
Version:            (using KDE 4.3.5)
Installed from:    openSUSE RPMs

I often use Ark for extracting archives containing only one file. Every time I press 'extract' button, I manually uncheck "Extract into subfolder". I think there should be some settings to be used as default or smth, or if Ark must really not have settings dialog for some reason, Ark could remember settings that were used last.
Comment 1 Raphael Kubo da Costa 2010-02-03 20:34:24 UTC
Actually, that's the only setting in the extraction dialog which isn't remembered because it's automatically "guessed" depending on whether the archive contains only one file or directory.

In case your suggestion is followed, what would happen when you uncheck it for a given file, the setting is stored and you open another single-file/single-directory archive?
Comment 2 Silver Salonen 2010-02-03 21:15:26 UTC
Well, it would be unchecked.

But if that's a smart setting being adjusted automatically, then it guesses wrong, right? Because when an archive has only one file, why should it be extracted into sub-directory (named as that file)?
Comment 3 Raphael Kubo da Costa 2010-02-09 01:39:48 UTC
Hmm, it depends :)

I've changed the behaviour so that single-file archives also create a subfolder some time ago, but I guess the decision isn't very popular.
Comment 4 Raphael Kubo da Costa 2010-02-09 01:41:12 UTC
SVN commit 1087415 by rkcosta:

Revert "Make subfolder detection work with one-file archives."

This reverts commit 1079099: the decision didn't seem to be
very popular.

BUG: 225426

 M  +1 -1      archivebase.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1087415
Comment 5 Raphael Kubo da Costa 2010-02-09 01:44:33 UTC
SVN commit 1087418 by rkcosta:

Backport r1087415.

Revert "Make subfolder detection work with one-file archives."

This reverts commit 1079099: the decision didn't seem to be
very popular.

CCBUG: 225426


 M  +1 -1      archivebase.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1087418
Comment 6 Silver Salonen 2010-03-21 09:44:09 UTC
In which release will it appear? I'm using KDE 4.4.1 and it behaves the same way.
Comment 7 Silver Salonen 2010-06-02 08:15:55 UTC
4.4.3 still behaves the same way.
Comment 8 Raphael Kubo da Costa 2010-06-04 23:33:50 UTC
*** Bug 240770 has been marked as a duplicate of this bug. ***
Comment 9 Hans Überacher 2010-06-05 00:28:33 UTC
Thanks for CC'ing me on this. Good to see it's been taken care of!

I'm using version 2.16 in (KDE 4.4.2 with Kubuntu 10.04) and it shows that behavior. Does anyone know a PPA that has an up-to-date package including this change?
Comment 10 Raphael Kubo da Costa 2010-06-05 01:54:47 UTC
Actually, as comment #7 points out, the fix wasn't properly done, so the bug has been reopened and is still present.
Comment 11 Raphael Kubo da Costa 2010-06-14 06:35:21 UTC
Raising severity -- this is not a wish, but most likely a regression. A fix will be committed soon.
Comment 12 Raphael Kubo da Costa 2010-06-14 06:42:22 UTC
SVN commit 1137712 by rkcosta:

Revert most of r948055.

Single-file archives should _be_ considered single-folder archives.

CCBUG: 225426

 M  +8 -11     jobs.cpp  
 M  +1 -1      jobs.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1137712
Comment 13 Raphael Kubo da Costa 2010-06-14 06:46:40 UTC
SVN commit 1137716 by rkcosta:

Backport r1137712.

Revert most of r948055.

Single-file archives should _be_ considered single-folder archives.

BUG: 225426
FIXED-IN: 4.4.5

 M  +8 -11     jobs.cpp  
 M  +1 -1      jobs.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1137716