Bug 222566 - Photo applet broken with other locales thant US/EN
Summary: Photo applet broken with other locales thant US/EN
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Context View (show other bugs)
Version: 2.2.2
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
: 221951 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-01-13 18:38 UTC by Cédric Bellegarde
Modified: 2010-01-13 20:18 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Fix for this bug (560 bytes, application/octet-stream)
2010-01-13 19:51 UTC, Cédric Bellegarde 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Cédric Bellegarde 2010-01-13 18:38:51 UTC 
Version:            (using KDE 4.3.4)
OS:                Linux
Installed from:    Archlinux Packages

Photo applet is broken in 2.2.2 release...

Debian bug report:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=564814

Arch Linux bug report:
http://bugs.archlinux.org/task/17822
Comment 1 Mark Kretschmann 2010-01-13 18:48:42 UTC 
*** Bug 221951 has been marked as a duplicate of this bug. ***
Comment 2 Cédric Bellegarde 2010-01-13 19:51:23 UTC 
Created attachment 39854 [details]
Fix for this bug

Engine was sending translated data to applet looking for non translated...

I remove translation because i don't think we need to send translated data.
Comment 3 Mark Kretschmann 2010-01-13 20:18:24 UTC 
commit 7fc57a99e59da1ec225fcf5cbd6c8a40430e50c0
Author: Mark Kretschmann <kretschmann@kde.org>
Date:   Wed Jan 13 20:13:39 2010 +0100

    Fix bug in Photos applet, didn't work with translated Amarok.
    
    Thanks to Bellegarde Cédric <gnumdk@gmail.com> for the patch.
    @Simon: Could you please verify and test this?
    
    BUG: 222566

diff --git a/ChangeLog b/ChangeLog
index 0336a14..5897907 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -2,6 +2,7 @@ Amarok ChangeLog
 ================
 (C) 2002-2010 the Amarok authors.
 
+
 VERSION 2.2.3
   FEATURES:
     * Non collection files with a cue sheet will now load their tracks as
@@ -27,6 +28,8 @@ VERSION 2.2.3
       files which incorrectly have the same MusicBrainz unique identifier.
 
   BUGFIXES:
+    * Fixed bug in Photos applet that made it break with translated versions
+      of Amarok. Patch by Bellegarde Cédric <gnumdk@gmail.com>. (BR 222566)
     * Lyrics applet: Fixed saving and restoring font styles. (BR 222277)
     * Lyrics applet: Fixed a bug where sometimes suggested URLs are not
       cleared when switching tracks.
diff --git a/src/context/engines/photos/PhotosEngine.cpp b/src/context/engines/photos/PhotosEngine.cpp
index 9c841f2..8aff13f 100644
--- a/src/context/engines/photos/PhotosEngine.cpp
+++ b/src/context/engines/photos/PhotosEngine.cpp
@@ -156,7 +156,7 @@ void PhotosEngine::update()
         // Show the information
         if( !m_artist.isEmpty() )
         {
-            setData( "photos", "message", i18n( "Fetching" ) );
+            setData( "photos", "message", "Fetching");
             setData( "photos", "artist", m_artist );
         }
         else