Bug 221830 - auto mode scroollbars in form textarea
Summary: auto mode scroollbars in form textarea
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: khtml (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-08 18:24 UTC by Andrea Iacovitti
Modified: 2010-03-02 10:28 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
patch (969 bytes, patch)
2010-01-08 18:25 UTC, Andrea Iacovitti
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrea Iacovitti 2010-01-08 18:24:31 UTC
Version:            (using Devel)
OS:                Linux
Installed from:    Compiled sources

Please consider to apply attached patch to enable 'ScrollBarAsNeeded' in form TextArea, to match firefox behaviour.
A test page to see the differences between FF and Konq will be http://www.tizag.com/htmlT/htmltextarea.php

IMO text areas will look nicer...

Regard,
Andrea
Comment 1 Andrea Iacovitti 2010-01-08 18:25:53 UTC
Created attachment 39696 [details]
patch
Comment 2 Frank Reininghaus 2010-01-10 22:53:06 UTC
Thanks for the report and patch. The issue has been reported a while ago already.

*** This bug has been marked as a duplicate of bug 173585 ***
Comment 3 Germain Garand 2010-02-04 12:23:02 UTC
@andrea: fwiw, I agree with the patch. The idea initially was to have form widgets clearly identified in any circumstances, has an accessibility helper.

This is no longer much of an issue since we have removed most of the other styling limitations on other widgets, so this is now inconsistent (until I get around introducing that accessibility option I think about)

could you possibly get an svn account and commit this yourself?
thanks
Comment 4 Andrea Iacovitti 2010-02-04 18:21:54 UTC
> could you possibly get an svn account and commit this yourself?
> thanks

Thank you for the trust, but probably will not right away....
In the meantime, you can apply the patch if you want.

Cheers,
Andrea.
Comment 5 Andrea Iacovitti 2010-02-14 13:12:33 UTC
SVN commit 1090000 by aiacovitti:

Do not display scroll bars on textarea elements when not necessary.
Match other browsers behaviour.
Approved by Germain.

BUG: 221830
CCBUG: 173585


 M  +7 -8      render_form.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1090000
Comment 6 Germain Garand 2010-02-16 05:24:04 UTC
thanks for applying eventually and commiting the fix, sorry I didn't respond beforehand.
As you might guess this isn't so much a matter of trust (KDE doesn't have much of a commit-access-is-sacred mindset ; it rather put the emphasis on responsibility for one's commits) as a matter of being really very few people to handle patches.
If you haven't noticed, KHTML hacking is unpopular ; it annoys a lot of people.
*Don Giovanni's Commantore theme*
Comment 7 Germain Garand 2010-02-20 02:13:05 UTC
SVN commit 1093037 by ggarand:

automatically merged revision 1090000:
Do not display scroll bars on textarea elements when not necessary.
Match other browsers behaviour.
Approved by Germain.

BUG: 221830
CCBUG: 173585

 M  +7 -8      render_form.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1093037
Comment 8 Germain Garand 2010-03-02 10:28:10 UTC
SVN commit 1097847 by ggarand:

got a better idea here:

instead of letting the textarea be always ScrollBarAsNeeded,
we may mirror the overflow-x/y property and default to overflow-y:scroll

This matches MSIE7 so should be perfectly compatible with sites that want
to turn the scrollbars to auto for cosmetic reasons (with overflow:auto),
while retaining as default the very nice "this is a form widget"
accessibility hint that the vertical scrollbar naturally provides.

CCBUG: 221830

 M  +1 -0      css/html4.css  
 M  +13 -0     rendering/render_form.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1097847