Bug 221798 - random _and_ repeating playlist
Summary: random _and_ repeating playlist
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Playlist (show other bugs)
Version: 2.3-GIT
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
: 229183 233543 240772 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-01-08 14:45 UTC by Richard Weinberger
Modified: 2010-08-01 12:23 UTC (History)
10 users (show)

See Also:
Latest Commit:
Version Fixed In: 2.3.1


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Weinberger 2010-01-08 14:45:05 UTC
Version:           2.2.1.90 (using 4.3.4 (KDE 4.3.4) "release 2", KDE:43 / openSUSE_11.0)
Compiler:          gcc
OS:                Linux (i686) release 2.6.25.20-0.5-pae

Since 2.2.1 (or 2.2.0?) Amarok is unable to play tracks in random order _and_ repeating the playlist.

E.g:
There are 10 tracks in my playlist.
"Random Tracks" is enabled. Amarok plays these 10 tracks in random order and stops.
Even if "Repeat Playlist" was set.
Starting with 2.2.1.90 I can only choose between "Random Tracks" and "Repeat Playlist".
That is crazy. :-(

Every music player is able to mange this!

Cheers,
//richard
Comment 1 Myriam Schweingruber 2010-01-08 16:12:47 UTC
Confirmed
Comment 2 Chris 2010-01-10 21:16:30 UTC
It would be really nice to have this feature, maybe by making it possible to select random mode and repeat mode separately?

Greetings, Chris.
Comment 3 Nikolaj Hald Nielsen 2010-01-11 11:08:27 UTC
prior to 2.2.1 we had the _option_ to specify random and repeat modes separately. The only issue was that internally in Amarok only one of the mode would ever actually be active at once, so in essence the ui was lying.

The big issue here as I see it is that many combinations of random and repeat simply makes no sense at all. For instance, what would "repeat track" + "random <something>" do? The simple solution here is to simply ignore the random mode, but if both are specified in the ui, this is being dishonest to the user.

And what about "random album" + "repeat album"?

You could argue that "random track" + "repeat album" might make sense (I think this is a bit of a corner case that can be handled using playlist shuffling if really needed), but other than this, the only thing that really makes sense is "random <something>" + "repeat playlist".

So I am not opposed to allowing "repeat playlist" to be active at the same time as a random mode, but other than that I really don't think it makes any sense to combine the modes.
Comment 4 Alex Richardson 2010-01-13 12:13:51 UTC
I agree, repeat playlist and random at the same time is needed.
For example I have a playlist with very few items (say ~6 songs) and would like to play them in random but have them play for more than 1 time.
Usually I'd do this by filtering, but for that Bug #222129 has to be fixed first.

Other than that, a really nice release of amarok :-)
Comment 5 Myriam Schweingruber 2010-01-13 15:12:19 UTC
Changing to wish.
Comment 6 Alex Richardson 2010-01-13 17:42:29 UTC
(In reply to comment #5)
> Changing to wish.

IMO it is not a wish, it is a regression from an earlier version.
Comment 7 Richard Weinberger 2010-01-13 22:52:47 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > Changing to wish.
> 
> IMO it is not a wish, it is a regression from an earlier version.

Ack.
Comment 8 Myriam Schweingruber 2010-03-03 10:07:24 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > Changing to wish.
> 
> IMO it is not a wish, it is a regression from an earlier version.

No, it is not, this never worked in Amarok 2, and Amarok 1.4 was a completely different codebase, please do not compare.
Comment 9 Myriam Schweingruber 2010-03-03 10:08:09 UTC
*** Bug 229183 has been marked as a duplicate of this bug. ***
Comment 10 Richard Weinberger 2010-03-03 12:47:43 UTC
(In reply to comment #8)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > Changing to wish.
> > 
> > IMO it is not a wish, it is a regression from an earlier version.
> 
> No, it is not, this never worked in Amarok 2, and Amarok 1.4 was a completely
> different codebase, please do not compare.

AFAIK it worked with Amarok 2.1.x.
Comment 11 Nikolaj Hald Nielsen 2010-03-03 15:35:04 UTC
Please read comment #3 again and really understand it. Having both random and repeat enabled _newer worked_ in Amarok 2 (I don't know how this stuff was implemented in Amarok 1), the one exception being random <something> and repeat playlist. Prior to 2.2.1, the user interface allowed you to select both at once, but only one would ever be enabled internally.
Comment 12 Anthony Vital 2010-03-07 00:43:02 UTC
How about making "Random tracks" behave like "Random tracks" + "Repeat playlist" and "Random album" behave like "Random album" + "Repeat playlist" by default? I think this could make sense, "random" here would really mean "random". I can hardly think of a user case where the user would want the playback to stop at the end of the playlist after choosing "Random something" anyway.
Comment 13 langstr 2010-03-20 16:56:56 UTC
This is fixed in the current git, as part of a big refactoring of the track navigators code.

I only see this bug report now, but I noticed the problem while working with that code.

It now has the same behaviour that was suggested by comment #12.
Comment 14 Mikko C. 2010-03-20 16:58:46 UTC
Closing then.
Thanks
Comment 15 Sven Krohlas 2010-04-07 21:31:37 UTC
*** Bug 233543 has been marked as a duplicate of this bug. ***
Comment 16 Myriam Schweingruber 2010-04-17 12:15:13 UTC
(In reply to comment #13)
> This is fixed in the current git, as part of a big refactoring of the track
> navigators code.
> 
> I only see this bug report now, but I noticed the problem while working with
> that code.
> 
> It now has the same behaviour that was suggested by comment #12.

Nanno, sorry, but there still is no option that allows to choose both random and repeat. Reopening.
Comment 17 langstr 2010-04-17 16:51:33 UTC
You're right, there is no option, but that's because "random" now always implies "repeat".

i.e. "random" now has the behaviour that was suggested by comment #12.

It avoids the most-recently-played 50% of tracks in the playlist, but it never stops playing.

There doesn't seem to be a use case for "be random, but on the other hand play each track exactly one time, and then stop".
Comment 18 langstr 2010-07-12 23:54:17 UTC
The new BUG 240772 report does request "Be random, but on the other hand play
each track exactly one time, and then stop".

Where I stand: randomness in Amarok is a bit of a mess.

 * You've got multiple unrelated "random" modes:
    - Playlist Sorting mode = "Random"
    - Track Progression mode = "Random"    
    - Dynamic Playlists mode = "Random"     

 * On the other hand, there's no simple "Shuffle" button for the playlist, for which there are multiple requests here on bugs.kde.org.

 * "Repeat" mode is not an orthogonal switch, it's 1 specific (linear) Track Progression mode which is mutually exclusive with all other Track Progression modes.


So:
 * There is now abundant evidence that "Repeat" needs to become an orthogonal switch.

 * The whole Track Progression system needs to be unified with the Dynamic Playlists system.

However, to my knowledge there is nobody under the few existing Amarok developers who's energized to improve this. So if you want it soon, you will likely have to program it yourself.
Comment 19 langstr 2010-07-12 23:56:08 UTC
*** Bug 240772 has been marked as a duplicate of this bug. ***
Comment 20 Myriam Schweingruber 2010-07-13 00:49:23 UTC
This is not about not wanting it to fix, but about not having enough time and manpower to do so. You are very welcome to give a hand.
Comment 21 Leonardo La Malfa 2010-07-13 10:56:30 UTC
(In reply to comment #18)
> The new BUG 240772 report does request "Be random, but on the other hand play
> each track exactly one time, and then stop".
> 
> Where I stand: randomness in Amarok is a bit of a mess.
> 
>  * You've got multiple unrelated "random" modes:
>     - Playlist Sorting mode = "Random"
>     - Track Progression mode = "Random"    
>     - Dynamic Playlists mode = "Random"     
> 
>  * On the other hand, there's no simple "Shuffle" button for the playlist, for
> which there are multiple requests here on bugs.kde.org.

Sorry for opening Bug 240772, but no matter how hard I tried, I failed to find a relevant discussion on that. I've read everyone's position on the matter, now, and I see that my perception of the Random Tracks mode remains tied to what it used to be prior to v. 2.3.1, where no repeat of any sort was implied. Which, after reading your last comment, I can now identify with the Shuffle Mode, unless I am mistaken. So, yeah, I'll now add myself to the party of users who hope to see this feature implemented, for, as it stands now, Track Progression mode is no longer of any use to me, personally.

However, most importantly, I am well aware that most (all?) Amarok developers are all volunteers who prefer to devote their free time to improving users' experience with music playing by "rediscovering their music" on one of the greatest player I have ever used. So, I'm grateful for all the awesome work you guys are doing, and understand the lack of man-power behind features waiting to be implemented or fixed. This is not a complaint, just a big thank-you and encouragement to keep rocking on!
Comment 22 Myriam Schweingruber 2010-08-01 12:23:49 UTC
(In reply to comment #17)
> You're right, there is no option, but that's because "random" now always
> implies "repeat".
> 
> i.e. "random" now has the behaviour that was suggested by comment #12.
> 
> It avoids the most-recently-played 50% of tracks in the playlist, but it never
> stops playing.
> 
> There doesn't seem to be a use case for "be random, but on the other hand play
> each track exactly one time, and then stop".

Well, that is the shuffle mode: https://bugs.kde.org/show_bug.cgi?id=166068
Currently Random doesn't shuffle the playlist. Different bug.