Version: (using KDE 4.3.4) OS: Linux Installed from: Unlisted Binary Package To get python plasma stuff built and installed you don't need python/sip/pyqt4/pykde4! These are only needed at runtime and NOT build time. This patch fixes this weirdness: --- kdebase-workspace-4.3.4/CMakeLists.txt~ 2009-11-27 14:01:58.000000000 +0100 +++ kdebase-workspace-4.3.4/CMakeLists.txt 2010-01-05 14:23:22.615963105 +0100 @@ -59,10 +59,7 @@ endif(PYQT4_FOUND AND PYQT4_VERSION STRLESS "040400") macro_optional_find_package(PyKDE4) -set(PythonSupport_FOUND FALSE) -if(PYTHONLIBRARY_FOUND AND SIP_FOUND AND PYQT4_FOUND AND PYKDE4_FOUND) - set(PythonSupport_FOUND TRUE) -endif(PYTHONLIBRARY_FOUND AND SIP_FOUND AND PYQT4_FOUND AND PYKDE4_FOUND) +set(PythonSupport_FOUND TRUE) macro_log_feature(PythonSupport_FOUND "Python" "KDE Python support" "http://techbase.kde.org/Development/Languages/Python" FALSE "" "Needed to build plasma scriptengine for Python") #### End Python support ####
submitting this patch to the plasma mailing list is probably more effective..
Is this commited, what is the status of this patch?
no this have not been commited yet this seems OK can some plasma dev give their opinion please ?
should be fine; just remove the macro_log_feature line as well since it isn't being checked for anymore.
Just to be sure, i can commit this ? Index: CMakeLists.txt =================================================================== --- CMakeLists.txt (révision 1132806) +++ CMakeLists.txt (copie de travail) @@ -60,12 +60,8 @@ endif(PYQT4_FOUND AND PYQT4_VERSION STRLESS "040400") macro_optional_find_package(PyKDE4) -set(PythonSupport_FOUND FALSE) -if(PYTHONLIBRARY_FOUND AND SIP_FOUND AND PYQT4_FOUND AND PYKDE4_FOUND) - set(PythonSupport_FOUND TRUE) -endif(PYTHONLIBRARY_FOUND AND SIP_FOUND AND PYQT4_FOUND AND PYKDE4_FOUND) +set(PythonSupport_FOUND TRUE) -macro_log_feature(PythonSupport_FOUND "Python" "KDE Python support" "http://techbase.kde.org/Development/Languages/Python" FALSE "" "Needed to build plasma scriptengine for Python") #### End Python support #### include(MacroLibrary)
yes
SVN commit 1135756 by nlecureuil: Remove unneeded deps at build time BUG: 221501 M +0 -4 CMakeLists.txt WebSVN link: http://websvn.kde.org/?view=rev&revision=1135756
SVN commit 1135770 by nlecureuil: Forwardport commit 1135756 CCBUG: 221501 M +0 -4 CMakeLists.txt WebSVN link: http://websvn.kde.org/?view=rev&revision=1135770
Git commit 21ba979f72d70d33d6775831512bb8820dab82a3 by Michael Jansen. Committed on 01/05/2012 at 17:16. Pushed by mjansen into branch 'master'. Remove checks for sip, pyqt4 and pykde4. They are unneeded. Correct fix for the given bug. REVIEW: 104619 M +2 -20 CMakeLists.txt M +2 -2 plasma/generic/scriptengines/CMakeLists.txt http://commits.kde.org/kde-workspace/21ba979f72d70d33d6775831512bb8820dab82a3