Bug 218164 - Confusing selection boxes in Web Shortcuts menu
Summary: Confusing selection boxes in Web Shortcuts menu
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: general (show other bugs)
Version: SVN
Platform: Compiled Sources Unspecified
: NOR minor
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-10 20:49 UTC by Richard Hartmann
Modified: 2012-05-09 22:36 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.9.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Hartmann 2009-12-10 20:49:44 UTC
Version:            (using Devel)
Installed from:    Compiled sources

Problem:

The selection boxes before each entry in the Web Shortcuts menu have non-obvious meanings. Especially as #kde-devel agreed that it controls an optional module, i.e. the search box' drop-down options.

This should be shown in some way.

Also, the gut-feeling of 100% of KDE devs I talked to was that this controls which Web Shortcuts are active in the address bar (it defaults to everything being active at all times). Maybe add a second checkbox to control that, though I am not sure if that is actually useful.
Comment 1 km 2010-10-16 22:36:15 UTC
I totally agree. It's not only confusing, but also problematic since krunner started to respect this setting. Now every shortcut that I want to use in krunner, also clutters the context submenu and search box drop-down menu (I like to have lots of shortcuts available for typing and only few most important ones in the menus). I think there should be at least two check-boxes for each shortcut: one for context menu and search box, one for address bar and krunner.
Comment 2 Burkhard Lück 2011-05-15 00:24:36 UTC
see also https://bugs.kde.org/show_bug.cgi?id=153942

In 4.6 with http://websvn.kde.org/?view=revision&revision=1176926
an option "Use selected shortcuts only" to the settings dialog was added.

Does this solve the issue now?
Comment 3 Dawit Alemayehu 2011-10-15 17:51:40 UTC
(In reply to comment #1)
> I totally agree. It's not only confusing, but also problematic since krunner
> started to respect this setting. Now every shortcut that I want to use in
> krunner, also clutters the context submenu and search box drop-down menu (I
> like to have lots of shortcuts available for typing and only few most important
> ones in the menus). I think there should be at least two check-boxes for each
> shortcut: one for context menu and search box, one for address bar and krunner.

Sorry, but KRunner does not depend on only selected web shortcuts. You can use  any defined shortcut from KRunner. I know because I changed KRunner to do that over a year ago.

As far as the checkboxes are concerned, the only alternative to the current implementation would be to move the checkboxes into the New/Change dialog box. Unfortunately, that would mean that you cannot quickly check your preferred shortcuts quickly. Personally, I think the failure is that 

For the record, the checkbox is meant for the user to mark his/her "preferred" web shortcuts. These preferred shortcuts are then used by any application that prefers to have only a limited list web shortcuts. Currently, that includes Konqueror's search bar plugin and the search context menu shown in some apps and kparts.
Comment 4 Dawit Alemayehu 2012-05-09 22:36:51 UTC
Git commit 0707b07d3afb14870d5c31149238e0f32e0d1187 by Dawit Alemayehu.
Committed on 07/05/2012 at 09:36.
Pushed by adawit into branch 'master'.

- Moved the checkbox used to select preferred shortcuts into its own column to
  prevent user confusion.

- Allow the shortcut list to be filtered using the shortcut texts.
Related: bug 168223
FIXED-IN: 4.9.0
REVIEW: 104900
GUI: New translatable text

M  +37   -21   kurifilter-plugins/ikws/ikwsopts.cpp
M  +5    -5    kurifilter-plugins/ikws/ikwsopts_p.h
M  +1    -1    kurifilter-plugins/ikws/ikwsopts_ui.ui

http://commits.kde.org/kde-runtime/0707b07d3afb14870d5c31149238e0f32e0d1187