Bug 215672 - Flashinglabel text is always Black.
Summary: Flashinglabel text is always Black.
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Plasma
Component: widget-microblogging (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-22 14:28 UTC by Philip Muškovac
Modified: 2009-11-24 19:08 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
patch proposed for kubuntu (700 bytes, patch)
2009-11-22 14:33 UTC, Philip Muškovac
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Muškovac 2009-11-22 14:28:30 UTC
Version:           kdeplasma-addons_4.3.2-0ubuntu6 (using KDE 4.3.2)
Compiler:          gcc 4.4.1-4ubuntu8 
OS:                Linux
Installed from:    Ubuntu Packages

The KDEµBlog Widget has a FlashingLabel on top that shows notifications about new tweets/characters left/etc.
The bug is that the notification text is ALWAYS black. That makes it hard/impossible to read if you're using dark themese like oxygen.

The cause is following line in applets/microblog/microblog.cpp:
m_flash->setColor( Plasma::Theme::TextColor );

this is an attempt to set the color to the theme text color. BUT TextColor is an enum value used by the Theme indicating what color value is used, not the actual color value. The correct way to set the color would be:
m_flash->setColor( Plasma::Theme::defaultTheme()->color(Plasma::Theme::TextColor) );

With that the correct text color for the current theme is used (on initialization).

LP report: https://bugs.launchpad.net/ubuntu/+source/kdeplasma-addons/+bug/486631
Comment 1 Philip Muškovac 2009-11-22 14:33:55 UTC
Created attachment 38487 [details]
patch proposed for kubuntu
Comment 2 Beat Wolf 2009-11-22 18:22:51 UTC
this patch should be submitted to the kde-devel mailing list, or reviewboard.kde.org. thank you
Comment 3 Beat Wolf 2009-11-24 13:03:50 UTC
after the feedback on reviewboard, i'm not sure, can this be closed? is the fix commited?
Comment 4 Philip Muškovac 2009-11-24 19:08:42 UTC
Trusting the svn log entries 1053269 and 1053270 this seems to be fixed. Thanks!