Bug 214493 - ”Show Menu Bar” appears double in shortcut-list
Summary: ”Show Menu Bar” appears double in shortcut-list
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: 2.3
Platform: unspecified Linux
: NOR minor
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-14 10:50 UTC by M G Berberich
Modified: 2012-10-20 10:59 UTC (History)
2 users (show)

See Also:
Latest Commit: http://commits.kde.org/konsole/40a38d7aa18fe40637ec35da6295022007df0a6e
Version Fixed In: 4.10.0
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description M G Berberich 2009-11-14 10:50:42 UTC 
Version:           2.3 (using 4.3.2 (KDE 4.3.2), Debian packages)
Compiler:          cc
OS:                Linux (x86_64) release 2.6.30-2-amd64

In the shortcuts editor the entry are two entries “Show Menu Bar”
Comment 1 Burkhard Lück 2009-11-15 12:15:25 UTC 
I can confirm the duplicated entry “Show Menu Bar” in all these versions:
Kubuntu 9.04
$ konsole --version
Qt: 4.5.2
KDE: 4.3.2 (KDE 4.3.2)
Konsole: 2.3.2

branch compiled from sources 
$ konsole --version
Qt: 4.5.2
KDE: 4.3.3 (KDE 4.3.3)
Konsole: 2.3.3

trunk compiled from sources 
$ konsole --version
Qt: 4.6.0
KDE: 4.3.75 (KDE 4.3.74 (KDE 4.4 >= 20091102))
Konsole: 2.4
Comment 2 Jekyll Wu 2011-07-05 10:08:24 UTC 
I can confirm this with konsole-2.7.999
Comment 3 Jekyll Wu 2011-11-24 05:20:20 UTC 
The cause is that the "Show MenuBar" action is ALWAYS part of the context menu, even when the menubar is already shown.
Comment 4 Jekyll Wu 2012-10-20 10:59:12 UTC 
Git commit 40a38d7aa18fe40637ec35da6295022007df0a6e by Jekyll Wu.
Committed on 20/10/2012 at 04:06.
Pushed by jekyllwu into branch 'master'.

Avoid duplicate "Show Menubar" entries in shortcuts dialog

The "show menubar" action in context menu is now shown only when menubar is
hidden.
REVIEW: 104193

FIXED-IN: 4.10.0

M  +1    -3    desktop/sessionui.rc
M  +10   -1    src/SessionController.cpp
M  +2    -0    src/SessionController.h

http://commits.kde.org/konsole/40a38d7aa18fe40637ec35da6295022007df0a6e