Bug 211907 - kphotoalbum: Missing EXIF support dialog upon startup without remedy ? (XMLDB/FileReader.cpp #ifdef HASEXIV2)
Summary: kphotoalbum: Missing EXIF support dialog upon startup without remedy ? (XMLDB...
Status: RESOLVED FIXED
Alias: None
Product: kphotoalbum
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: KPhotoAlbum Bugs
URL:
Keywords:
: 211671 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-10-26 10:07 UTC by Mark Purcell
Modified: 2009-12-02 20:27 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Purcell 2009-10-26 10:07:07 UTC
Version:           4.0.2 (using 4.3.2 (KDE 4.3.2), Debian packages)
Compiler:          cc
OS:                Linux (i686) release 2.6.30-2-686

Forwarded-From: http://bugs.debian.org/552236


----------  Forwarded Message  ----------

Subject: [Pkg-kde-extras] Bug#552236: kphotoalbum: Missing EXIF support dialog upon startup without remedy ?
Date: Monday 26 October 2009
From: Olivier Berger <oberger@ouvaton.org>
To: 552236@bugs.debian.org, control@bugs.debian.org

tags 552236 + patch
thanks

On Sat, Oct 24, 2009 at 05:35:44PM +0200, Olivier Berger wrote:
> 
> Looking at the code, in XMLDB/FileReader.cpp, it seems it's the only place in the sources where a #ifdef HASEXIV2 is used, whereas all the other sources seem to use #ifdef HAVE_EXIV2
> 

Here's a proposed patch to fix the issue :

diff -u kphotoalbum-4.0.2/debian/changelog kphotoalbum-4.0.2/debian/changelog
--- kphotoalbum-4.0.2/debian/changelog
+++ kphotoalbum-4.0.2/debian/changelog
@@ -1,3 +1,9 @@
+kphotoalbum (4.0.2-1.1) unstable; urgency=low
+
+  * Fix exiv2 message on startup (Closes: #552236)
+
+ -- olivier <oberger@ouvaton.org>  Sun, 25 Oct 2009 15:44:26 +0100
+
 kphotoalbum (4.0.2-1) unstable; urgency=low
 
   * New upstream release. (Closes: #538061)
only in patch2:
unchanged:
--- kphotoalbum-4.0.2.orig/XMLDB/FileReader.cpp
+++ kphotoalbum-4.0.2/XMLDB/FileReader.cpp
@@ -264,7 +264,7 @@
 
     if ( wrongOrder ) {
         KMessageBox::information( messageParent(),
-#ifdef HASEXIV2
+#ifdef HAVE_EXIV2
                                   i18n("<p>Your images/videos are not sorted, which means that navigating using the date bar "
                                        "will only work suboptimally.</p>"
                                        "<p>In the <b>Maintenance</b> menu, you can find <b>Display Images with Incomplete Dates</b> "

-- 
Olivier BERGER 
(OpenPGP: 1024D/B4C5F37F)
http://www.olivierberger.com/weblog/



_______________________________________________
pkg-kde-extras mailing list
pkg-kde-extras@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-kde-extras

-------------------------------------------------------
Comment 1 Olivier Berger 2009-10-26 10:23:54 UTC
*** Bug 211671 has been marked as a duplicate of this bug. ***
Comment 2 Hassan Ibraheem 2009-11-25 15:44:49 UTC
Patch committed in revision 1054068.
Thanks for reporting this, and thanks Olivier for the patch.