Bug 210880 - yakuake should reopen if shortcut is pressed on another screen
Summary: yakuake should reopen if shortcut is pressed on another screen
Status: RESOLVED FIXED
Alias: None
Product: yakuake
Classification: Applications
Component: general (show other bugs)
Version: 2.9.6
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: ---
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-17 15:06 UTC by Marc Schiffbauer
Modified: 2011-03-07 02:40 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Schiffbauer 2009-10-17 15:06:07 UTC
Version:           2.9.6 (using KDE 4.3.2)
OS:                Linux
Installed from:    Gentoo Packages

There is a small usability glitch with yakuake when configured like this:

* have yakuake stay open when loosing focus
* have yakuake NOT appear on every screen
* option "get focus back on shortcut" *disabled* (as this will switch screen if on another screen)

now if you have yakuake open and switch to another screen to do something else and then want the yakuake window again you have to press the shortcut (F12) *twice* which is very confusing if you do not know why this is.

Mor intuitive would be IMO: 
if (yakuake window still open on another screen) 
  and (shortcut pressed) 
  and ("get focus back on shortcut" option disabled) 
then (close and reopen on current screen with just *one* keypress)

What do you think?
Comment 1 Eike Hein 2009-10-17 16:10:51 UTC
Sorry, but is it possible that with "screen" you mean virtual desktop/workspace? Otherwise I'm unable to follow your text.
Comment 2 Marc Schiffbauer 2009-10-17 18:19:51 UTC
yes indeed, I mean virtual desktop/workspace, sorry

And i have a german i18n, so if its not clear I might start yakuake
with english locales to get the correct names of the options I was
talking about.

thanks
Comment 3 Eike Hein 2009-10-17 18:56:39 UTC
So to summarize, you want the Open/Retract Yakuake action/shortcut to move the Yakuake window from whatever virtual desktop it is on to the current virtual desktop if the "Use Open/Retract action to focus window" option is disabled. Hmm, yes, you might be right about that -- provided it's doable, I'll likely change the behavior as you desire for 2.9.7.
Comment 4 Marc Schiffbauer 2009-10-17 19:16:34 UTC
Yes exactly! 

Thanks for considering. And keep up the great work!
Comment 5 Marc Schiffbauer 2009-12-27 21:49:10 UTC
Hi Eike,

anythign new on this one? And if yes, will 2.9.7 make it into KDE 4.4?
Comment 6 Eike Hein 2009-12-27 23:04:42 UTC
Yakuake is not part of the KDE Software Compilation - it's an Extragear application, with a release cycle independent of the SC. In other words, in practice, when to make a release is up to me, and the release date of KDE SC 4.4 has nothing to do with it.

I hope to getting around to making 2.9.7 in early 2010 - January or February - including this change.
Comment 7 Marc Schiffbauer 2009-12-27 23:28:17 UTC
Great Eike, many thanks!
Comment 8 Marc Schiffbauer 2011-03-03 13:59:27 UTC
Hi Eike,

did you forget about this one?

Currently using 2.9.8+

TIA
-Marc
Comment 9 Eike Hein 2011-03-03 16:01:33 UTC
Crap, yes - sorry.
Comment 10 Eike Hein 2011-03-05 00:23:06 UTC
Marc,

I was finally getting around to implementing this tonight, and while doing so I remembered/rediscovered (I don't use virtual desktops, personally, so I don't get to experience it first-hand usually) that Yakuake actually sets its window to be visible on all virtual desktops, so it shouldn't be necessary to pull it from one to another - could you explain why this is necessary in your case?
Comment 11 Eike Hein 2011-03-05 00:24:55 UTC
Arf, disregard - there's an option controlling that (which I implemented of course, but *also* forgot about ;-).

That changes the question slightly, however - wouldn't it satisfy your needs to enable the option to show the window on all desktops, or is there some reason you don't want to that? Implementing your original request is fairly simple and I don't mind doing it if it's still necessary, but it seems like the existing option might suffice already?
Comment 12 Eike Hein 2011-03-05 01:08:36 UTC
Git commit de03b66bc74522014340a5986cfedd4a8b9f57f1 by Eike Hein.
Committed on 05/03/2011 at 01:03.
Pushed by hein into branch 'master'.

Pull the window to the current virtual desktop under certain conditions.

When the window is set not to show on all virtual desktops and is not
residing on the current virtual desktop, but is open (i.e. set to stay
open regardless of focus loss), the Open/Retract action normally used
to either retract it, or, when the option to also use the action to
focus the window is enabled, cause the window manager to switch to the
virtual desktop the window resides on. The former case, i.e. when the
option to also use the action to focus the window is disabled, has now
been changed to move the window to the current virtual desktop and
focus it, rather than retract it.

Also augments the What's This blurb on the focus option to mention the
window manager's VD switch behavior, and added some code comments to
help charting the codepaths.

BUG:210880

M  +9    -0    ChangeLog     
M  +1    -1    app/config/behaviorsettings.ui     
M  +33   -3    app/mainwindow.cpp     

http://commits.kde.org/yakuake/de03b66bc74522014340a5986cfedd4a8b9f57f1
Comment 13 Eike Hein 2011-03-05 01:09:06 UTC
In the end it just made sense to do, so I've added the behavior regardless of the show-on-all-desktops action - sorry it took so long.
Comment 14 Marc Schiffbauer 2011-03-07 02:40:50 UTC
Hi Eike,

many thanks! 

Marc