Bug 210013 - Crash when typing Return two times after a term in the search box
Summary: Crash when typing Return two times after a term in the search box
Status: RESOLVED FIXED
Alias: None
Product: marble
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR crash
Target Milestone: 0.8 (KDE 4.3)
Assignee: marble-bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-09 20:23 UTC by gerlos
Modified: 2013-10-20 08:02 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
marble-bug210013.diff (454 bytes, patch)
2009-11-06 15:41 UTC, Dennis Nienhüser
Details

Note You need to log in before you can comment on or make changes to this bug.
Description gerlos 2009-10-09 20:23:06 UTC
Version:           0.8.1 (using 4.3.2 (KDE 4.3.2), Mandriva Linux release 2009.1 (Official) for i586)
Compiler:          gcc
OS:                Linux (i686) release 2.6.29.6-desktop-2mnb

Marble crashes every time I type the name of a place in the search field AND I hit two times the return key.

Here's (a part of) what I get in the console if I try with the term "Roma":

MarbleControlBox (sort): Time elapsed: 1 ms
Creating GeoDataCoordinates from string  "roma"
ONF search: GET /namefinder/search.xml?find= "Roma"
Runner finished, active runners:  1
Runner reports 0 results
QThread: Destroyed while thread is still running
marble: Fatal IO error: client killed

Sorry, but at the moment I can't create a backtrace. 
Let me know if you need it.
Comment 1 Dennis Nienhüser 2009-11-06 15:20:45 UTC
Confirmed for current trunk [Version 0.9 SVN Using KDE 4.3.74 (KDE 4.3.74 (KDE 4.4 >= 20091102))]

Not always happening here, but I was able to reproduce it twice with different keywords.

There's another, related bug: Hitting enter n times while the search is running will execute the search n times, and each result will come in n times as well.
Comment 2 Dennis Nienhüser 2009-11-06 15:41:31 UTC
Created attachment 38135 [details]
marble-bug210013.diff

This patch should fix both issues.

Is there any case I'm not seeing where a consecutive search for the same term should be executed multiple times? If yes, double searches should be prevented in the MarbleControlBox instead. If not, I'll check in the patch.
Comment 3 Dennis Nienhüser 2009-11-14 00:25:15 UTC
SVN commit 1048810 by nienhueser:

Do not search for the same term more than once in a row. Avoids duplicated result entries and crashes.
CCBUG: 210013


 M  +3 -0      MarbleRunnerManager.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1048810
Comment 4 Dennis Nienhüser 2009-11-15 10:38:15 UTC
SVN commit 1049435 by nienhueser:

Do not search for the same term more than once in a row. Avoids duplicated
result entries and crashes. Backport of commit 1048810
BUG: 210013
Please follow up in https://bugs.kde.org/show_bug.cgi?id=206534 for crashes related to multiple search queries running at the same time.


 M  +9 -7      MarbleRunnerManager.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1049435