Bug 208845 - KRDC toolbar on top cannot be accessed in Fullscreen mode
Summary: KRDC toolbar on top cannot be accessed in Fullscreen mode
Status: RESOLVED FIXED
Alias: None
Product: krdc
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: HI normal
Target Milestone: ---
Assignee: Tony Murray
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-29 08:45 UTC by Parameshwara Bhat
Modified: 2010-04-28 14:10 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
krdc debug output (2.45 KB, text/plain)
2010-01-14 08:20 UTC, Silver Salonen
Details
output of session where toolbar disappears on 2nd connection (7.28 KB, text/x-log)
2010-01-25 09:05 UTC, Silver Salonen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Parameshwara Bhat 2009-09-29 08:45:30 UTC
Version:           4.3.1 (KDE 4.3.1) "release 165" (using 4.3.1 (KDE 4.3.1) "release 165", KDE:KDE4:Factory:Desktop / openSUSE_11.1)
Compiler:          gcc
OS:                Linux (i686) release 2.6.27.29-0.1-default

When the mouse is hovered it used to appear before.Now one can see a small strip on top,but it never opens upon mouse hovering except in the first few secs of switching to krdc from other application.

I have extensively used it before,it used to work well.
Comment 1 Urs Wolfer 2009-09-29 21:35:35 UTC
Can you reproduce this issue all the time? Using VNC or RDP? What is your remote resolution and real screen resolution?
Comment 2 Parameshwara Bhat 2009-09-30 05:17:53 UTC
1.Yes,this happens all the time.
2.My screen resolution is 1280 x 1024.I normally connect at "current screen resolution".But this occurs even when resolution is lower.In all resolutions.
3.I am using RDP.
Comment 3 Urs Wolfer 2009-09-30 21:29:34 UTC
From what KRDC (KDE) version have you updated recently? What graphic drivers are you using?
Comment 4 Parameshwara Bhat 2009-10-01 09:56:55 UTC
1. KRDC version and details:

pbhat@bhat:~> rpm -qi krdc
Name        : krdc                         Relocations: (not relocatable)             
Version     : 4.3.1                             Vendor: openSUSE Build Service        
Release     : 105.1                         Build Date: Saturday 19 September 2009 08:45:29 PM IST                               
Install Date: Monday 21 September 2009 12:27:06 AM IST      Build Host: build19       
Group       : Productivity/Networking/Remote Desktop   Source RPM: kdenetwork4-4.3.1-105.1.src.rpm
Size        : 873647                           License: GPL v2 or later
Signature   : DSA/SHA1, Saturday 19 September 2009 08:49:02 PM IST, Key ID 58d8ff412e1efa87
URL         : http://www.kde.org
Summary     : Remote Desktop Connection
Description :
Krdc allows to connect to VNC and RDP compatible servers.

Authors:
--------
    The KDE Team <kde@kde.org>
Distribution: KDE:KDE4:Factory:Desktop / openSUSE_11.1

2.I have an integrated video.This is intel 945 chip.Driver I believe is i915 as I do not see any i945.There is also intel_agp listed.
Comment 5 Tony Murray 2009-10-08 23:33:54 UTC
I can confirm this bug, but it is very infrequent for me.  It just happened today once, and I think I remember it happening once before.  I think I will start running krdc from a konsole so I can see any debug output it may spew out when this happens.  I have no clue on reproducing it reliably.
Comment 6 Tony Murray 2009-12-03 07:04:53 UTC
Still can confirm this in svn but haven't figured out how to reproduce it.

Upping the priority since you cannot switch out of fullscreen then and have to kill krdc.
Comment 7 Silver Salonen 2010-01-13 08:39:50 UTC
I can reproduce it :)

I use NVidia GeForce 7300 LE with 17" LCD-monitor and thus 1280x1024 resolution.

1) I connect to RDP-desktop and set its resolution to 1280x1024
2) I switch to full-screen
3) I log out from the desktop
4) I select the same desktop from the list that appears after that
5) At the point KRDC connects to the RDP-desktop, the toolbar disappears from the top

I just tried the same with 1024x768 desktop and it doesn't reproduce it. If I connect to 1280x1024 desktop though, the toolbar disappears again.
Comment 8 Tony Murray 2010-01-14 01:12:52 UTC
Silver, that's great that you can reproduce it.

Please run krdc from a console and check your debug output.  I suspect that when it doesn't work you should get two of this line in a row.

FloatingToolBar::showAndAnimate: anchorWidget not fullscreen yet
FloatingToolBar::showAndAnimate: anchorWidget not fullscreen yet 

If you don't get any debug output run kdebugdialog and check krdc(5010) and you will see then.

If this is what is happening then I think I know where the bug is happening, but I still need a little more info to make sure we get it fixed.  I've added some more debug information to svn, so if you can check out krdc from svn and build it that would be great or you can wait for rc2 (although this doesn't leave us much time to fix it before 4.4 is out).  If you need help building from svn and are willing to, email me directly and I'll help you out.  Unfortunately, I'll be on vacation for a few days, but I'm sure Urs would like to get this fixed too so maybe he will be able to give it some attention.  

Once you have a fresh copy of krdc, run it again from the console, retrigger the bug and paste the console output to here.

Thanks a lot.
Comment 9 Silver Salonen 2010-01-14 08:19:43 UTC
Nope, no such lines. I'll attach output of the 2nd session (which makes the toolbar disappear).
Comment 10 Silver Salonen 2010-01-14 08:20:54 UTC
Created attachment 39879 [details]
krdc debug output

That's the output of the 2nd session that makes the toolbar disappear.
Comment 11 Silver Salonen 2010-01-14 08:23:00 UTC
BTW, I haven't mentioned I currently use KDE 4.3.90 on OpenSuse 11.2.
Comment 12 Tony Murray 2010-01-17 00:45:47 UTC
I've put some additional debug statements in for the rc2 release.  Please submit  the console output once you can get a copy of this release.  Thanks.
Comment 13 Tony Murray 2010-01-22 05:04:33 UTC
Can you please test again with RC2 and post the output of the console on the
bug report, thanks!

On Thu, Jan 14, 2010 at 1:23 AM, Silver Salonen <silver.salonen@gmail.com>wrote:

> https://bugs.kde.org/show_bug.cgi?id=208845
>
>
>
>
>
> --- Comment #11 from Silver Salonen <silver salonen gmail com>  2010-01-14
> 08:23:00 ---
> BTW, I haven't mentioned I currently use KDE 4.3.90 on OpenSuse 11.2.
>
> --
> Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are on the CC list for the bug.
>
Comment 14 Silver Salonen 2010-01-22 10:12:38 UTC
I'm waiting for RC2 to appear in OpenSuse packages :)
Comment 15 Silver Salonen 2010-01-25 08:50:01 UTC
So, I've finally got 4.3.95.

One interesting note - I couldn't reproduce the bug if I entered the full-screen mode BEFORE connecting to the 1st RDP-server. If I switch to full-screen AFTER connecting, the bug is there.

Anyway, the output of the entire toolbar-disappearing session is uploaded in a minute.
Comment 16 Silver Salonen 2010-01-25 09:05:18 UTC
Created attachment 40214 [details]
output of session where toolbar disappears on 2nd connection

I first connected to one server, logged out from that and connected to another. On another connection the toolbar disappears.
Comment 17 Silver Salonen 2010-02-04 11:12:28 UTC
Any progress?
Comment 18 Silver Salonen 2010-02-18 10:43:04 UTC
Any progress?
Comment 19 Silver Salonen 2010-03-26 14:21:35 UTC
Any progress?
Comment 20 Urs Wolfer 2010-03-28 19:09:30 UTC
Silver Salonen: No news yet, sorry. You will get notified when there are any changes.

Tony, are you still investigating this issue?
Comment 21 Tony Murray 2010-04-27 22:30:21 UTC
I've got a workaround for this, but I'm waiting for a response from Urs to see if we can get a more complete fix.
Comment 22 Tony Murray 2010-04-28 01:13:02 UTC
SVN commit 1119910 by murrant:

Simple fix for this bug for 4.4, refuse to resize the tab widget when in fullscreen mode.
BUG: 208845


 M  +4 -0      mainwindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1119910
Comment 23 Tony Murray 2010-04-28 13:56:22 UTC
SVN commit 1120109 by murrant:

Fix bug 208845 and make several other changes to code around this to make things more sane.
* Common window size variables in hostpreferences.  Modified VNC connection settings to allow the setting the window size when scaling is enabled.
* Save the window size to the new standard variables, but only if scaling is enabled.
* Remove the need to cast to QScrollArea by using QWidget::frameGeometry(). This relieves us of the need to cache the bordersize.
* Resize the window, don't temporarily change the minimum size of the tab widget.
* If the view size and the screen size match, automatically go into fullscreen mode. Not sure if this will be wanted by users or not.

REVIEW: 3824
CCBUG: 208845


 M  +22 -0     core/hostpreferences.cpp  
 M  +8 -1      core/hostpreferences.h  
 M  +27 -37    mainwindow.cpp  
 M  +0 -3      mainwindow.h  
 M  +0 -22     rdp/rdphostpreferences.cpp  
 M  +0 -4      rdp/rdphostpreferences.h  
 M  +3 -2      vnc/vncclientthread.cpp  
 M  +77 -0     vnc/vnchostpreferences.cpp  
 M  +5 -0      vnc/vnchostpreferences.h  
 M  +145 -4    vnc/vncpreferences.ui  
 M  +7 -6      vnc/vncview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1120109
Comment 24 Silver Salonen 2010-04-28 14:10:27 UTC
(In reply to comment #23)
> * If the view size and the screen size match, automatically go into fullscreen
> mode. Not sure if this will be wanted by users or not.

For me it seems reasonable, because in these cases I go fullscreen every time anyway - otherwise I just can't see a almost 1/3 of the remote desktop.