Bug 206776 - Collection & Playlist Search Filters should have consistent ENTER key behaviour
Summary: Collection & Playlist Search Filters should have consistent ENTER key behaviour
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: 2.3-GIT
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-08 19:19 UTC by John Atkinson
Modified: 2009-09-09 22:34 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Atkinson 2009-09-08 19:19:45 UTC
Version:           latest Git head (using Devel)
OS:                Linux
Installed from:    Compiled sources

The behaviour of the search filters when pressing the ENTER key differs.

- When typing to search the collection, ENTER will end input and defocus the filter control with no further effect (regardless of collection selection).
- When typing to search the playlist, ENTER will end input and defocus then play the currently selected track. It will also (slowly) redraw the playlist widget for some reason.


This feel this is confusing. I would expect the ENTER key to have the same behaviour for both controls.

I'd propose that ENTER should not play the selected track immediately. (i.e. The playlist search filter should act in the way the collection search filter currently does). The selected entry should be able to be played by pressing the ENTER key twice anyway.

I can patch this, but I realise that work may be ongoing on this area already.

RELATED BUGS:
https://bugs.kde.org/show_bug.cgi?id=192125
https://bugs.kde.org/show_bug.cgi?id=180381
Comment 1 Teo Mrnjavac 2009-09-09 21:38:53 UTC
The behavior is indeed slightly different in the two filter bars (the playlist bar doesn't lose focus), but I can reproduce what you described for the playlist filter bar only when "Show Only Matches" is *not* selected in the filer menu, so the filter bar isn't a filter bar any more but a search bar technically.
I disagree that pressing ENTER shouldn't play the selected track, because that's the normal behavior for the playlist and I see no reason to make an exception in this instance.
I do agree however that the focus behavior should be consistent so I'll look into it.
Comment 2 Teo Mrnjavac 2009-09-09 22:34:41 UTC
commit 2f67ba0fa780cabf908f31dd976d3261639d240d
Author: Teo Mrnjavac <teo@getamarok.com>
Date:   Wed Sep 9 21:29:21 2009 +0200

    Made focus behavior consistent between browsers and playlist filter widget.
    BUG: 206776