Version: (using Devel) OS: Linux Installed from: Compiled sources The git master has a compile error, there is a broken code in the file amarok/src/collection/ipodcollection/handler/IpodHandler.cpp The error is : http://pastebin.com/m21cf9d28 I'm attaching a patch for the bug.
Created attachment 36708 [details] Proposed patch
Sorry, this patch is plain wrong. If you don't have the g_type_init() function, then compiling it out may fix the compilation but it will cause absolutely random errors when using the ipod code. Please install the package that provides that method.
(In reply to comment #2) > Sorry, this patch is plain wrong. If you don't have the g_type_init() function, > then compiling it out may fix the compilation but it will cause absolutely > random errors when using the ipod code. > > Please install the package that provides that method. I don't code for amarok, so I'm not familiar with the methods used there. But, if you look at the header, the glib header is included only when GDK is found, so it appears as the function is defined only when the GDK_FOUND is true. If you want people to have the package you should add it as a mandatory dependency and not an "optional" package. Plus the g_type_init() is not the only error. The other two lines changed make sense to me atleast as the ipodTrack variable is declared only when GDK_FOUND is true. The bug is not *invalid*, though the patch might not be correct. So imho the bug is not resolved. (And, anyway I don't get any of the iPod sync features even though they are built during the compile, that'll be a different bug report :P)
Created attachment 36733 [details] Proposed patch #2 This is an "ugly" patch which includes the glib_object.h header whether or not GDK is found. The other corrections are the same as in the previous patch.
Yes, I have already fixed the compilation errors with Q_UNUSED. As for #include "glib-object.h", the #ifdef GDK_FOUND check is too greedy here, it only needs to be around gdk-pixbuf. Fixed.