Bug 205235 - bbc weather engine can't find my location
Summary: bbc weather engine can't find my location
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Plasma
Component: widget-weather (show other bugs)
Version: unspecified
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
: 220841 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-08-26 21:35 UTC by Oliver Henshaw
Modified: 2010-06-12 02:30 UTC (History)
10 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Find error using UK MET (42.62 KB, image/png)
2010-02-04 07:04 UTC, jamundso
Details
bbcukmet.patch (739 bytes, patch)
2010-06-12 00:37 UTC, Lukas Krejci
Details
query parameters handling patch (3.80 KB, patch)
2010-06-12 02:23 UTC, Lukas Krejci
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Henshaw 2009-08-26 21:35:06 UTC
Version:            (using KDE 4.3.0)
OS:                Linux
Installed from:    Fedora RPMs

I've just updated to kde 4.3.0 and the plasma weather applet no longer displays a forecast. If I try and configure the applet and search for my town (with the bbc) then it can't be found. Searching for a nearby large town does work, however.

I looked at the plasma engine source and guess it could be an issue with parsing the search url, or something to do with redirects being disabled.


Further info:

Searching for "rochford" doesn't work, while searching for "southend" does - though both have the same code. Searching for either from the bbc weather website works fine.

Packages affected:

kdebase-workspace-4.3.0-9.fc11.i586
Comment 1 Shawn Starr 2009-08-26 21:54:49 UTC
Try "United Kingdom" BBC search broke finding some places. Using country name gives more names. This won't be fixed because the search code they have makes this impossible for me to parse without knowing ahead of time what places only show up when using country vs exact name.
Comment 2 Oliver Henshaw 2009-08-28 13:13:21 UTC
It looks like the results for my town turn up in the area search, but are stripped out in the bbcukmet ion. Is it possible to re-add results from area searches, or would that cause more trouble?
Comment 3 Oliver Henshaw 2009-09-08 22:01:21 UTC
As I said, my problem has more to do with "area search" than country names.

P.S. Have you got a list of problematic searches? If so I can try and re-enable area searches on my local machine and see if I can keep them working.
Comment 4 Christian Nitschkowski 2009-09-13 13:07:30 UTC
I've got the same problem with the city of Duisburg (Germany).
The weather applet suddenly stopped working for me some time during the KDE 4.3 beta phase.
Searching for Duisburg on the BBC web page will get me the results.
Comment 5 Shawn Starr 2009-12-23 02:34:05 UTC
BBC broke searching again. It's bad enough area search was not working. I will need to backport the new URL changes that BBC made for 4.3.x series.
Comment 6 jamundso 2010-02-04 07:04:03 UTC
Created attachment 40521 [details]
Find error using UK MET

BBC Weather can't find London. That's funny.
Comment 7 jamundso 2010-02-04 07:06:44 UTC
Ping.
Comment 8 Anne-Marie Mahfouf 2010-02-04 13:18:16 UTC
Jerry what KDE version? 4.4 branch is foxed and when you type 'London' you get all London possibilities.
Comment 9 Lukáš Tinkl 2010-02-04 13:39:48 UTC
Confirmed, it stopped working somewhen in the middle of 4.3 series; using 4.3.4 here. The BBC ion doesn't actually find any location at all
Comment 10 jamundso 2010-02-04 15:06:43 UTC
(In reply to comment #8)
> Jerry what KDE version? 4.4 branch is foxed and when you type 'London' you get
> all London possibilities.

4.3.4
Comment 11 jamundso 2010-02-06 03:23:37 UTC
(In reply to comment #10)
> (In reply to comment #8)
> > Jerry what KDE version? 4.4 branch is foxed and when you type 'London' you get
> > all London possibilities.
> 
> 4.3.4

and now, 4.3.5 also.
Comment 12 Dario Andres 2010-02-16 15:12:23 UTC
- Could you recheck this with KDE SC 4.4.0 ? (may be related to bug 225020)
Regards
Comment 13 Gerold Neuwirt 2010-03-01 19:16:53 UTC
I have got the same problem with KDE 4.3.5 on Kubuntu. I deleted the plasmarc files in the kde config and thought it will be easy to reinstall the plasmadesktop. When I wanted to configure the weather plasmoid it just tells me that it can't find the place.

To mention is also that the respond appears very fast for BBC, so I guess it doesn't even try to connect to the station. When I try the other two weather stations NOAA and Canada it seems that there is at least a fraction of a second response time.
Comment 14 Aaron J. Seigo 2010-05-11 05:39:56 UTC
*** Bug 220841 has been marked as a duplicate of this bug. ***
Comment 15 Nicolas L. 2010-06-07 10:51:34 UTC
Do you reproduce with kde 4.4.4 or 4.5 beta ?
Comment 16 Marcus Harrison 2010-06-07 10:54:07 UTC
Yeah, the bug is still present in 4.4.4. Don't have 4.5 beta installed, myself...
Comment 17 Anne-Marie Mahfouf 2010-06-07 11:11:33 UTC
It does not work well at all (4.5 branch) and there's even a new bug when you hit Enter after entering a location, Enter does not trigger the Search.

Not sure if the not found locations are BBC related but entering a location through the BBC website works when it does not work through the applet.
Comment 18 Lukas Krejci 2010-06-12 00:37:56 UTC
Created attachment 47918 [details]
bbcukmet.patch

I'm attaching a one character patch that fixed this bug for me (the patch is against KDE 4.4.3 as that is the version I have installed).

Before the patch, a search for "Brno" would find 13 locations none of which would be the correct one. With the patch, the correct location is found.

I did a smoke test with a couple of cities around the world and got correct results each time ("London" gets multiple relevant results as expected).
Comment 19 Aaron J. Seigo 2010-06-12 01:23:41 UTC
SVN commit 1137208 by aseigo:

start from the beginning, patch by Lukas Krejci
BUG:205235


 M  +1 -1      ion_bbcukmet.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1137208
Comment 20 Lukas Krejci 2010-06-12 02:23:19 UTC
Created attachment 47920 [details]
query parameters handling patch

This is another patch (that includes the original one-liner) that fixes the "Rochford problem" mentioned above by capturing and passing along the additional query parameters that can be applied to the RSS URLs (i.e. the "area" query parameter in this concrete case).
Comment 21 Lukas Krejci 2010-06-12 02:30:18 UTC
oh, forgot to mention that second patch should fix the bug 226194 as well...