Bug 202154 - restart/logout notification are shown before update completes
Summary: restart/logout notification are shown before update completes
Status: RESOLVED FIXED
Alias: None
Product: kpackagekit
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Steven M. Parrish
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-01 01:30 UTC by Steven M. Parrish
Modified: 2010-04-28 12:43 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Steven M. Parrish 2009-08-01 01:30:17 UTC
Version:           0.4.1.1 (using KDE 4.2.4)
OS:                Linux
Installed from:    Fedora RPMs

Description of problem:

When updating packages that require a restart (or a logout/login) with
packagekit, notifications appear before the end of the yum upgrade.

The notifications appear in a stack coming from the 'i' icon in the kde system
tray. I think they come around the end of the testing packages phase, or the
beginning of the install packages phase. Then when the update is complete, a
restart icon appears in the systray.


Additionally, there is one notification stacking up per package requiring
restart. None of these notifications show which package caused it. The
kpackagekit restart icon is much friendlier - it simply lists the packages
requiring update in a list in a tooltip.


Version-Release number of selected component (if applicable):

kpackagekit-0.4.1.1-1.fc11.i586
kdebase-workspace-4.2.4-5.fc11.i586
PackageKit-0.4.8-2.fc11.i586  


Comment #1 From  Steven M. Parrish (smparrish@gmail.com)  2009-07-25 10:55:10 EDT   (-) [reply] -------

IIRC the notifications actually come from PackageKit, is that correct Richard?

-- 
Steven M. Parrish - KDE Triage Master
                  - PackageKit Triager
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers  

------- Comment #2 From Richard Hughes (rhughes@redhat.com) 2009-07-28 08:44:48 EDT (-) [reply] -------

Yes, the signals come from packagekitd, which kpackagekit turns into
notifications. I think that restart notifications should be just a tooltip as
Comment 1 Daniel Nicoletti 2009-08-03 14:46:21 UTC
Well there are some reasons the notification icon do not show which package caused it:
- the restart signal can be called various times, and i'm unable to update the notification, unless i kill it and create a new one, which is ugly.
- updating the tool tip is easier since i have access there.

The restart as Richard said is issued by the backend tool which imo should only emit it when it finished it's job.
IMO this isn't a valid report, i'll keep it open for a while if you think i missed a point.
Comment 2 Oliver Henshaw 2009-08-11 18:30:04 UTC
Comment #5 From  Richard Hughes (rhughes@redhat.com)  2009-08-08 08:32:21 EDT (-) [reply] -------

(In reply to comment #4)
> I see that upstream believes that the timing of the notifications is the
> responsibility of the packagekit backend.

No, it's up to the frontend to take the notifications whenever they happen and
batch them up to show the user at the end. There's nothing in the spec about
when signals have to come during the transaction.
Comment 3 Oliver Henshaw 2009-08-11 18:34:58 UTC
Sorry, that's me clumsily quoting Richard Hughes in the downstream bug ( https://bugzilla.redhat.com/show_bug.cgi?id=513755 .)

Contrary to my statement in the original report that "when the update is complete, a restart icon appears in the systray," the icon is always in the systray throughout the update, it's just hidden under the stack of jobs in the kpackagekit icon.
Comment 4 Daniel Nicoletti 2009-08-11 18:58:44 UTC
Yes, about the icon you are right, I don't want to waste systray space since if you have running tasks why would you want to restart?
Comment 5 Oliver Henshaw 2009-08-17 23:16:30 UTC
I'll note that if you batch notifications until the end of the update, you could show the list of packages in the notification as well as in the kpackagekit tooltip.
Comment 6 Daniel Nicoletti 2009-08-20 20:00:44 UTC
Ok, for KPackageKit 0.5 I decided to store the restarts and print them at the end, since a backend will emit require restart more than once if multiple packages requested it, the only problem is that I don't know how the pop up will looks like when 100 packages caused it...
Comment 7 Oliver Henshaw 2010-04-28 12:43:54 UTC
This has re-appeared in Fedora 12, perhaps triggered by a PackageKit update (the kpackagekit version has remained stable for a while).

PackageKit-0.5.7-2.fc12.i686
kpackagekit-0.5.4-2.fc12.i686

If early notifications appear, it's now at a predictable point in the packagekit transaction. See https://bugzilla.redhat.com/show_bug.cgi?id=553356#c2 for further details and some console output.