Bug 201596 - window shadow not always fully painted
Summary: window shadow not always fully painted
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: compositing (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-26 23:38 UTC by S. Christian Collins
Modified: 2012-06-30 18:51 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screenshot of shadow glitch (160.84 KB, image/png)
2009-07-26 23:39 UTC, S. Christian Collins
Details

Note You need to log in before you can comment on or make changes to this bug.
Description S. Christian Collins 2009-07-26 23:38:30 UTC
Version:            (using KDE 4.2.98)
OS:                Linux
Installed from:    Ubuntu Packages

Occasionally, the shadow behind a window isn't fully painted.  It seems to happen most frequently with a window that is at least partially covering another window.  Please see the attached screenshot.

How to reproduce:
1) Open Dolphin
2) Right-click on the title bar and select "Configure Window Behavior".
3) Select "Window-Specific" from the column on the left
4) Click "New...".  The "Edit Window-Specific Settings" dialog should come up, and there is a good chance the shadow won't be fully painted.  If the shadow looks fine, click cancel to close the window, and then re-open it by clicking "New..." again.  Keep doing this until you see the glitch (don't worry, it won't take too long).

Notes:
I did not notice this problem prior to KDE 4.3 RC3.

My System Info:
Motherboard: MSI K9N SLI Platinum (nForce 570 SLI chipset)
CPU: AMD Athlon(tm) 64 Processor 4000+
RAM: 2GB DDR2
Video: EVGA NVIDIA GeForce 7600 GT (PCI Express) w/ 256 MB RAM
OS: Kubuntu 9.04
Comment 1 S. Christian Collins 2009-07-26 23:39:16 UTC
Created attachment 35655 [details]
screenshot of shadow glitch
Comment 2 S. Christian Collins 2009-07-26 23:41:19 UTC
I forgot to mention, I'm also running:

Kernel: 2.6.30-020630-generic
KDE: 4.3 RC3
NVIDIA driver: 185.18.14
Comment 3 Thomas Lübking 2009-07-27 00:00:24 UTC
just to be sure - can you reproduce this with any deco that's /not/ oxygen/ozone/nitrogen?
Comment 4 S. Christian Collins 2009-07-27 00:20:12 UTC
Other deco's no longer exhibit a shadow as of 4.3 RC3.  I've also noticed that if a window deco (besides ozone/oxygen) has rounded corners, the corners are no longer transparent with compositing enabled.  They look fine with compositing disabled... should I file that as a separate bug?
Comment 5 Thomas Lübking 2009-07-27 00:38:03 UTC
(In reply to comment #4)
> Other deco's no longer exhibit a shadow as of 4.3 RC3. 
Do you have the shadow plugin activated?

> I've also noticed that if a window deco (besides ozone/oxygen) has rounded corners, the corners are no longer transparent with compositing enabled.  They look fine with compositing disabled... should I file that as a separate bug?

Which decos did you try? (decorator and another 3rd party had "bugs" regarding this)
And in case: yes - that'd be different bugs  (with differend assignees - supposing it doesn't hit /all/ decos)
Comment 6 S. Christian Collins 2009-07-27 00:56:48 UTC
According to information posted in bug 198704
<https://bugs.kde.org/show_bug.cgi?id=198704>, the shadow plugin no longer
controls window shadows--that is up to the window decorator I guess.  This
change is probably what has contributed to the emergence of the bugs I am
experiencing.

FYI, Dekorator and Plastik were the decos with rounded corners that I tried. 
Both of those decos worked fine up until recently (sometime within the last two
RC releases).
Comment 7 Thomas Lübking 2009-07-27 01:23:27 UTC
(In reply to comment #6)
> According to information posted in bug 198704
> <https://bugs.kde.org/show_bug.cgi?id=198704>, the shadow plugin no longer

this /only/ holds for decos that support a specific attribute what's (atm) oxygen (and it's derivates) only + plus some decos that do "accidently"
all other decos still rely on the shadow plugin (just like popup menus, combobox lists, undecorated windows, etc.)

> FYI, Dekorator and Plastik were the decos with rounded corners that I tried. 
> Both of those decos worked fine up until recently (sometime within the last two RC releases).

plastik works for me.
can you try web/keramik and in case you have: qtcurve/bespin/aurorae?
Comment 8 S. Christian Collins 2009-07-27 02:33:31 UTC
Never mind.  Plastik works for me as well.  I don't know what I was doing when I checked it earlier...  Anyway, looks like deKorator is the only deco causing problems at the moment.  Sorry about the confusion.
Comment 9 Christoph Feck 2009-07-27 03:09:10 UTC
Christian, deKorator problem is bug 200311.
Comment 10 S. Christian Collins 2009-07-27 03:22:20 UTC
Looks like the deKorator developer(s) have fixed the issue as of version 0.4.0.3 (http://www.kde-look.org/content/show.php/deKorator?content=87921).  Anyway, sorry for leading things off topic here and distracting the focus from the actual bug.
Comment 11 S. Christian Collins 2009-07-28 16:49:45 UTC
I've discovered more helpful details about this bug:

1) The problem only occurs with the Oxygen/Ozone window decorations (and probably any others that specify their own shadows).  Other window decorations (such as Plastik), that have their shadows drawn by the shadow plugin are unaffected by this bug.

2) The fade plugin must be enabled

3) although it's harder to get a window to appear with the shadow entirely missing in spots, it is quite common to see areas of the shadow that are less than 100% strength--if you look closely around the shadow it will often appear "spotty", where there are patches of 100%, 60%, etc. shadow strength.
Comment 12 Martin Flöser 2009-07-29 13:48:56 UTC
SVN commit 1004121 by graesslin:

Reimplement addRepaintFull() in Client and add the padding to the repaint region.
CCBUG: 201596

 M  +1 -0      client.h  
 M  +6 -0      composite.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1004121
Comment 13 Martin Flöser 2009-07-29 13:51:00 UTC
If possible please try with that commit. I'm not totally sure if it fixes the issue - it is hard to test. Unfortunatelly I can't just backport the patch as it needs changes introduced by fixing bug #201780 (which isn't backported yet)
Comment 14 Martin Flöser 2009-08-19 15:42:36 UTC
SVN commit 1013298 by graesslin:

Backport rev 1004121: Reimplement addRepaintFull() in Client and add the padding to the repaint region.
CCBUG: 201596


 M  +1 -0      client.h  
 M  +6 -0      composite.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1013298
Comment 15 Martin Flöser 2009-08-23 14:58:52 UTC
Assuming the commits fixed the problem - if anybody is able to reproduce in 4.3.1 please reopen
Comment 16 Ruslan Kabatsayev 2012-06-30 18:51:51 UTC
This bug (at least with the same symptoms) appears in kde 4.8.3.
Now it appears not on decorated windows, but on tooltips, so I'm not sure if this is the same bug or I should file a new one.
See this screenshot: http://i.imgur.com/HYP0H.png
How to reproduce (KDE 4.8.3 on 64 bit ubuntu 12.04 LTS):
1. Start systemsettings
2. Highlight Quit button
3. Move mouse cursor to Help button fast enough that the tooltip doesn't disappear
4. Tooltip jumps to another position on screen and gets another text&size
5. After moving cursor from one button to another several times you can notice the glitch.
This is true for .
On another machine (32 bit LFS with KDE 4.8.2) I can't reproduce it this way, but I can another way:
1. Start dolphin
2. Undock Places panel
3. Steal focus from Dolphin main window so that Places panel disappears
4. Activate Dolphin window
5. The panel appears and its shadow is only painted where main window shadow is visible