Bug 200820 - [PATCH] Add support for AIFF in Amarok since every iPod supports it
Summary: [PATCH] Add support for AIFF in Amarok since every iPod supports it
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: 2.2-SVN
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-20 02:48 UTC by Rashad Tatum
Modified: 2009-12-09 11:34 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Adds support for AIFF. (1.12 KB, patch)
2009-07-20 02:52 UTC, Rashad Tatum
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rashad Tatum 2009-07-20 02:48:15 UTC
Version:            (using KDE 4.2.96)
Compiler:          gcc 4.3.3 
OS:                Linux
Installed from:    Ubuntu Packages

Every iPod introduced to market has support for AIFF, Apple's counterpart to WAV.  

See http://www.everymac.com/systems/apple/consumer_electronics/stats/ipod.html

and http://www.apple.com/ipod/whichipod/

Also, even the first generation iPod Shuffle supported AIFF.  See: http://www.testfreaks.co.uk/mp3-players/apple-ipod-shuffle-1st-generation/
Comment 1 Rashad Tatum 2009-07-20 02:52:09 UTC
Created attachment 35469 [details]
Adds support for AIFF.
Comment 2 Myriam Schweingruber 2009-07-20 11:36:41 UTC
Copying the patch inline:

Index: src/amarok/src/collection/ipodcollection/handler/IpodHandler.cpp
===================================================================
--- src/amarok/src/collection/ipodcollection/handler/IpodHandler.cpp	(revision 999501)
+++ src/amarok/src/collection/ipodcollection/handler/IpodHandler.cpp	(working copy)
@@ -902,6 +902,7 @@
     DEBUG_BLOCK
 //    findPathToCopy( srcTrack );
     KUrl srcurl = KUrl::fromPath( srcTrack->playableUrl().path() );
+    debug() << "Copying " << srcTrack << " to " << destTrack;
     m_trackscopying[ srcurl ] = srcTrack;
     return kioCopyTrack( srcurl, m_trackdesturl[ srcTrack ] );
 }
@@ -1478,6 +1479,10 @@
     {
         m_itdbtrackhash[ track ]->filetype = g_strdup( "wav" );
     }
+    else if( type=="aiff" )
+    {
+        m_itdbtrackhash[ track ]->filetype = g_strdup( "aiff" );
+    }
     else if(type=="mp3" || type=="mpeg")
     {
         m_itdbtrackhash[ track ]->filetype = g_strdup( "mpeg" );
@@ -1754,8 +1759,9 @@
 {
     QStringList formats;
 
-    formats << "mp3" << "aac" << "mp4" << "m4a";
+    formats << "mp3" << "aac" << "mp4" << "m4a" << "aiff";
 
+
     return formats;
 }
Comment 3 Alejandro Wainzinger 2009-07-20 12:05:16 UTC
Nice, thanks for the patch, will try tonight after work if I can find an aiff lying around.  If there's other formats left, don't feel shy about adding them in either.
Comment 4 Myriam Schweingruber 2009-08-09 16:13:55 UTC
Alejandro, any news about this patch?
Comment 5 Seb Ruiz 2009-08-27 12:36:51 UTC
Implemented locally, I'll push to git-mainline soon.