Bug 195846 - Custom playlist layout doesn't display mp3 ID3 tag (Length) when TLEN tag data is missing
Summary: Custom playlist layout doesn't display mp3 ID3 tag (Length) when TLEN tag dat...
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: 2.1
Platform: Ubuntu Linux
: NOR major
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-10 05:00 UTC by ross sumera
Modified: 2009-06-10 14:12 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ross sumera 2009-06-10 05:00:12 UTC
Version:           2.1 (using KDE 4.2.4)
Compiler:          cc (Ubuntu 4.3.3-5ubuntu4) 4.3.3 compiled using official ubuntu/debian packaging procedure
OS:                Linux
Installed from:    Ubuntu Packages

The predefine layout display the track length regardless if the mp3 ID3 tag TLEN is missing or not.

Custom layout will not show the mp3 Length data if the ID3 tag TLEN is missing.

To reproduce the problem copy the "No Grouping" predefined layout. Instead of 2 row / 2 column, make it a single row with only the following tag; Title, Artist & Length for both the Body and the Single tab.

Previously there is no problem with this kind of custom layout on 2.1 beta2 (2.0.96).

As per the release announcement "The biggest change however is the new playlist layout editor.... and leaves the rest for your creativity!"

Well, I'm trying to go back to the simple old style layout but it won't allow me.
Comment 1 ross sumera 2009-06-10 05:03:47 UTC
I've also compiled svn 979107, same problem
Comment 2 Nikolaj Hald Nielsen 2009-06-10 13:48:44 UTC
I see what you mean, but I think the bug is actually completely unrelated to the TLEN stuff, even though this is the symptom that you are experiencing.

The issue is that, when starting with the "no grouping" layout, and then dragging the artist token from the bottom row to the top row and removing the last element from the bottom row, you end up with 3 elements with width 50% in one row (you can check this by right clicking on an element) Since the 2 first elements then take up all the available space, there is no room for the length item.

To make matters worse, the width sliders are all stuck at 50% and cannot be moved, making it hard to correct the new layout.
Comment 3 Nikolaj Hald Nielsen 2009-06-10 14:12:11 UTC
SVN commit 979661 by nhnielsen:

Make it possible to change the size (only downwards) of playlist layout elements if the combined width of all elements exceed 100%. This can happen if dragging tokens between rows or manually editing a layout xml file, and previously made it impossible to fix the layout as there was no way to change the sizes of any od the elements.
Later a warning should be added for rows where the set width of items exceeds 100%, but this requires a string change so it will have to wait for a later version.
Also fix the size of the width slider so it does not overlap width the width display.
BUG: 195846 


 M  +10 -2     TokenWithLayout.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=979661