Bug 195593 - shaded windows have a truncated frame when composite is enabled
Summary: shaded windows have a truncated frame when composite is enabled
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: HI normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
: 198951 201379 201482 202882 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-06-07 20:50 UTC by Huynh Huu Long
Modified: 2009-08-19 15:44 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Shade window (606.80 KB, video/ogg)
2009-06-13 15:59 UTC, FiNeX
Details
modification to kde2-windeco (1.32 KB, text/plain)
2009-06-14 00:48 UTC, Huynh Huu Long
Details
screenshot of the kde2-windeco patch (35.19 KB, image/png)
2009-06-14 00:50 UTC, Huynh Huu Long
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Huynh Huu Long 2009-06-07 20:50:30 UTC
Version:            (using Devel)
OS:                Linux
Installed from:    Compiled sources

This bug can be easily seen with keramik or redmond decoration, where the bottom frame appears truncated. I suppose this effect is even stronger if any LM_OuterPadding is set.
Comment 1 Martin Flöser 2009-06-07 21:26:14 UTC
it looks to me like the bottom texture is inverted in OpenGL and I think I know why.

in Scene::Window::buildQuads we have:
QRegion decoration = (Workspace::self()->decorationHasAlpha() ?
    QRegion(client->decorationRect()) : shape()) - contents;

In case of a shaded window this will be only one rect. That is in makeQuads only one WindowQuad will be created for the decoration and scene opengl get's a little bit confused by this.

I see know two possible ways:
 * we ensure in buildQuads that four WindowQuads are created for the decoration
 * we ensure in scene opengl that the decoration is painted correctly if there is only one window quad and the window is shaded.

Personally I would prefer the first way as there could be quads filtered out so that there is only one decoration quad left. And this would ensure that it also works for XRender (although it seems to work there - which might be pure luck).

Fredrik any ideas?
Comment 2 FiNeX 2009-06-13 15:59:05 UTC
Created attachment 34500 [details]
Shade window

Hi! When I shade a window and desktop effects are enabled, the decoration is wrongly drawn. Is this the case?
Comment 3 Thomas Lübking 2009-06-13 16:32:21 UTC
nope, that was another bug (related to ARGB decos and an invalid window region hint) i forgot the id, but it's meanwhile fixed =D

this bug here is rather "minor" and about a slight visual glitch inside the titlebar if the shaded titlebar is bigger than the normal one - unfortunately holds for most decos :-(
Comment 4 FiNeX 2009-06-13 20:17:14 UTC
@Thomas: are you really sure it has been fixed? What should I update to test the fix? I've updated both kdebase and kdelibs, but the problem is still there... Do you need I open a new bug report about it? Thanks!
Comment 5 Thomas Lübking 2009-06-13 22:18:07 UTC
actually it appears you suffer from a third bug that only affects the oyxgen/ozone (in fact oxygen instantly segfaults kwin here...) deco but maybe related to this one (rather than to the fixed one)
it just looks more like the fixed bug (the shaded window was not clipped from the window stack and thus the region never got erased - looked similar to the video)

try another deco (e.g. keramik or redmond as mentioned in the original post), it should not show at least such a harsh behavior (usually the bottom is painted inverted)
Comment 6 Huynh Huu Long 2009-06-14 00:48:27 UTC
Created attachment 34512 [details]
modification to kde2-windeco

I modified the kde2 window decoration to get the same effect on there and I don´t do anything suspicious.
Steps are:
* enable AbilityUsesAlphaChannel
* set LM_OuterPadding* to 25
* resize the decoration rectangle
* fill it with something opaque
Comment 7 Huynh Huu Long 2009-06-14 00:50:46 UTC
Created attachment 34513 [details]
screenshot of the kde2-windeco patch
Comment 8 FiNeX 2009-06-14 13:11:41 UTC
@Thomas: you're right, the bug I've seen is only on oxygen/ozone deco.
Comment 9 Thomas Lübking 2009-06-14 14:31:35 UTC
(In reply to comment #6)
> don´t do anything suspicious.
except making use of KDecorationUnstable... of course ;-)

the collision between oxygen's intermediate ARGB support (soft corners) and the general ARGB support for decorations is probably (pretty apparent) the reason for this bug. as the ARBG deco afaik cannot be extended to shadows for 4.3 and i don't know whether this collision can be cleared at all.

this may lead to another regression for 4.3 (after loosing blurring) what brings us to release cycle coordination and release cycles at all and another flame war ;-P

(you can even have more fun w/ the oxygen/ozone deco by suspending composition, shading a window, reactivating composition, try* to unshade it...)
*to fix: just resuspend composition, unshade all windows, then resume composition
Comment 10 Huynh Huu Long 2009-06-14 14:49:18 UTC
(In reply to comment #9)
> (In reply to comment #6)
> > don´t do anything suspicious.
> except making use of KDecorationUnstable... of course ;-)
Nope, I use KCommonDecoration in this case.
Comment 11 Thomas Lübking 2009-06-14 15:30:24 UTC
i'm not sure how kcommondecoration handles this, but the padding handling is part of kdecorationunstable
so if you successfully set paddings i assume kcommondecoration will (silently?) use kdecorationunstable...

what happens if you keep the alpha ability but drop the paddings?
Comment 12 Huynh Huu Long 2009-06-14 15:55:59 UTC
Well the bug doesn´t then doesn´t show up any more of course because the "extra height" at the bottom is the same as the padding.
Comment 13 Knut Johansson 2009-06-14 15:58:40 UTC
Just updated to trunk, and I see several errors in the window decorations when running effects. Not sure if they are related to this or not, but they seem related.

If you look at the KDE2 example screen-shot, the color of the button symbols are wrong. When running a unmodified version of the KDE2 deco (or Laptop/keramik etc) the button symbols get the wrong color, actually they get transparency. 

If you play around with several windows and some shade/unshade actions the whole buttons get 100 transparent, but do return when moving the mouse over them. 

Also when shaded, the bottom bar of the window get transparent and about double size of what it should have.
Comment 14 Huynh Huu Long 2009-07-04 21:49:10 UTC
*** Bug 198951 has been marked as a duplicate of this bug. ***
Comment 15 Martin Flöser 2009-07-24 20:36:29 UTC
*** Bug 201379 has been marked as a duplicate of this bug. ***
Comment 16 Thomas Lübking 2009-07-25 20:56:02 UTC
*** Bug 201482 has been marked as a duplicate of this bug. ***
Comment 17 Martin Flöser 2009-07-30 20:22:23 UTC
SVN commit 1004690 by graesslin:

When we have a shaded window we have to create the four decoration quads manually. For each deco pixmap there has to be one quad of same size.
This requires some testing and will be backported in two or three weeks.
BUG: 195593

 M  +12 -1     scene.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1004690
Comment 18 FiNeX 2009-07-31 10:52:59 UTC
Thanks for the fix :-)
Comment 19 Martin Flöser 2009-08-06 23:36:57 UTC
*** Bug 202882 has been marked as a duplicate of this bug. ***
Comment 20 Martin Flöser 2009-08-19 15:44:04 UTC
SVN commit 1013299 by graesslin:

Backport rev 1004690: When we have a shaded window we have to create the four decoration quads manually. For each deco pixmap there has to be one quad of same size.
CCBUG: 195593


 M  +12 -1     scene.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1013299