Bug 195002 - filters are applied twice or more
Summary: filters are applied twice or more
Status: RESOLVED WAITINGFORINFO
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-02 17:52 UTC by Pierre Rossi
Modified: 2012-05-15 08:56 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre Rossi 2009-06-02 17:52:18 UTC
Version:           2.0.0 (using KDE 4.2.3)
OS:                Linux
Installed from:    Unlisted Binary Package

when applying a filter (such as color adjustment) with the preview on, clicking Apply or OK will result in applying the filter once again (applied once by the preview already). This behaviour doesn't feel quite right.
Comment 1 Elián Hanisch 2009-06-07 04:40:27 UTC
I can confirm in trunk, but only when hitting the 'apply' button, using ok was alright.
Comment 2 Elián Hanisch 2009-06-07 04:51:57 UTC
actually, this is due to the preview itself, this is easy to see with the invert filter. When you 'apply' the invert filter, the image is inverted, then the preview is updated and it looks back to the way it was before, and if you hit cancel the preview goes away and you end with your image inverted once.

the convination of hitting 'apply' and 'ok' would cause the filter to be applied twice.

as a solution, one can remove the apply button (not a good idea if you want to apply several filters) or disable the preview and the action of the "ok" button until you select another filter
Comment 3 Cyrille Berger 2009-06-07 09:38:11 UTC
... and reenable ok when messing with the settings of the current filter. But I think the original bug report was that we compute the filtering twice, once in the preview mask, and once after hitting apply/ok. Both things are indeed good point, I think Boudewijn has something in the work for the compute twice thing. I will look at the ok/apply thing.
Comment 4 Cyrille Berger 2009-06-07 09:57:03 UTC
SVN commit 978443 by berger:

Disable the apply/ok button until filter is changed

CCBUG:195002

 M  +4 -0      kis_dlg_filter.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=978443
Comment 5 Halla Rempt 2012-03-06 14:50:31 UTC
No problems about this anymore that I can see.