Version: (using Devel) OS: Linux Installed from: Compiled sources --- src/amarokurls/BookmarkManagerWidget.cpp (revision 970285) +++ src/amarokurls/BookmarkManagerWidget.cpp (working copy) @@ -41,7 +41,7 @@ m_toolBar = new QToolBar( this ); m_toolBar->setToolButtonStyle( Qt::ToolButtonTextBesideIcon ); - KAction * addGroupAction = new KAction( KIcon("media-track-add-amarok" ), i18n( "Add Folder" ), this ); + KAction * addGroupAction = new KAction( KIcon("media-track-add-amarok" ), i18n( "Add Group" ), this ); m_toolBar->addAction( addGroupAction ); connect( addGroupAction, SIGNAL( triggered( bool ) ), BookmarkModel::instance(), SLOT( createNewGroup() ) );
Could you be a bit more specific in future bug reports? The title wasn't very descriptive. Renaming for you. Also, please explain what your patch is meant to achieve. Why do you want to rename this string?
(In reply to comment #1) > Could you be a bit more specific in future bug reports? The title wasn't very > descriptive. Renaming for you. I just wanted to spend less time for this bug report ;), I'll try to make the titles more descriptive in the future. But I'd not say that this is a patch, it just was the easiest way to define what I want to change. > > Also, please explain what your patch is meant to achieve. Why do you want to > rename this string? I think, amarok should use one term to define the concept of "group of bookmarks", but there are 2 terms currently being used for this ("group" and "folder"): src/amarokurls/BookmarkManagerWidget.cpp:44: "Add Folder" src/amarokurls/BookmarkModel.cpp:438: "New Group" I "vote" for "group" because the term "folder" usually stands for a directory in a file system.
Alexander, can you please verify if this patch is still valid with current git master? Bookmark handling got many improvements and there's no applet anymore.
(In reply to comment #3) > Alexander, can you please verify if this patch is still valid with current git > master? Bookmark handling got many improvements and there's no applet anymore. Excuse me? Either I missed something in the last few minutes, but I still have a Bookmarks applet here. How else would you handle the existing bookmarks?
I have no bookmark applet anymore. From the changelog: * Remove the bookmark manager context applet and add a bookmark manager instead.
Funny, because I still have it here, Amarok 2.2-git, compiled a few minutes ago. And the bookmark manager is just exactly the same, only opening in a separate window, so I don't see how this would change anything in this report.
The button adding a new group of bookmarks is still called "Add Folder" while everywhere else the term "group" is used for the same thing: 1. the default name of a group is "New Group", 2. the group line has "group" in the "Type" column. I still think that "Add Folder" should be renamed to "Add Group". The bookmarks plasmoid has transformed to Bookmark Manager, but nothing has changed in principle.
nhn removed the bookmark applet. however, as it is a separate library, the files still exist on your system, so they still get loaded.
Reminds me that we need a versioning system for Applets. A simple number that we could bump, like we do with other plugins.
See #8.
(In reply to comment #10) > See #8. Did I say something about applets? This bug is about the Bookmark Manager you can open from the "Tools" menu.
Created attachment 47501 [details] screenshot
This bug is still valid.
Please submit your patch to http://reviewboard.kde.org
This is not a large code patch, so it's easier to discuss the suggested change here.
Well, the Amarok workflow is that all patches should go to reviewboard, regardless if big or small, so you should really do so.
Then just pretend that I didn't post any patches here. There is a problem that should be fixed (see comment#2, comment#7 and the screenshot).
Git commit 7a57685394fa73cce6c2b0ca07777bc316db83f3 by Sven Krohlas. Committed on 16/06/2011 at 21:16. Pushed by krohlas into branch 'master'. Rename "Add Folder" to "Add Group" in Bookmark Manager Patch by Alexander Potashev. BUG:193308 FIXED-IN:2.4.2 M +1 -1 src/amarokurls/BookmarkManagerWidget.cpp http://commits.kde.org/amarok/7a57685394fa73cce6c2b0ca07777bc316db83f3