Bug 191474 - ACL not copied for files when copying the parent folder
Summary: ACL not copied for files when copying the parent folder
Status: RESOLVED FIXED
Alias: None
Product: kio
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 4.2.0
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-03 15:09 UTC by jonathan aquilina
Modified: 2013-06-16 21:33 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.9


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jonathan aquilina 2009-05-03 15:09:27 UTC
Version:            (using KDE 4.2.2)
OS:                Linux
Installed from:    I Don't Know

Binary package hint: konqueror

There's a folder with files having ACL permissions. While copying into an other folder with acl permissions, only folder permissions are inherited. I've tried Dolphin and Konqueror, neither of them work, but mc works fine.

Steps:

1. There is a folder with acl permissions in this folder is a folder "folder1" which are files with name "file1", "file2", "file3" permissions to file similar folder:
getfacl - numeric ./folder1
user:: rwx
group:: rwx
group: 10004: rwx
mask:: rwx
other ::---
default: user:: rwx
default: group:: rwx
default: group: 10004: rwx
default: mask:: rwx
default: other ::---

2. In Konqueror, Dolphin copy folder

3. Opens second "folder2" folder in which the following ACL:
getfacl - numeric ./folder2
user:: rwx
group:: rwx
group: 10005: rwx
mask:: rwx
other ::---
default: user:: rwx
default: group:: rwx
default: group: 10005: rwx
default: mask:: rwx
default: other ::---

4. Inserts in "folder2" folder with name "folder1", after inserting a folder in mc (nautilus), ACL permissions inherited from folders with name "folder2" unlike Konqueror, Dolphin.

5. After ACL in "folder1" viewer, we see that the permissions of the folder have changed, as it should be:
getfacl - numeric ./folder2/folder1
user:: rwx
group:: rwx
group: 10005: rwx
mask:: rwx
other ::---
default: user:: rwx
default: group:: rwx
default: group: 10005: rwx
default: mask:: rwx
default: other ::---

But if you look at the files in this folder, then their permissions remained unchanged
getfacul - numeric ./folder2/folder1/file1
user:: rwx
group:: rwx
group: 10004: rwx
mask:: rwx
other ::---
default: user:: rwx
default: group:: rwx
default: group: 10004: rwx
default: mask:: rwx
default: other ::---

It was expected that after copying folders with name "folder1", it has the permissions to default inherit from the folder "folder2". While copying in mc or nautilus permissions to a folder copied correctly inherited from the folder which one level above.
Comment 1 jonathan aquilina 2009-05-03 15:10:25 UTC
bug can be found at https://bugs.edge.launchpad.net/ubuntu/+source/kdebase/+bug/254877
Comment 2 Heretic 2010-02-19 11:40:50 UTC
I found fix, in kdelibs package for me. In Kubuntu 8.04 LTS. KDE 3.5.10.

./apt-build/build/kdelibs-3.5.10/kio/kio/job.cpp

2195c2195
<         m_defaultPermissions = false;
---
>         m_defaultPermissions = true;
Comment 3 David Faure 2012-08-20 15:58:34 UTC
Git commit 73ea8cee7661579d3c414f510f6a74fc241c3ecf by David Faure.
Committed on 20/08/2012 at 17:53.
Pushed by dfaure into branch 'KDE/4.9'.

Fix copying of files with extended ACLs.

The switch to #cmakedefine01 in KDE Frameworks has detected a missing
 #include <config-acl.h> in file_unix.cpp ever since it was splitted
out. In case we still had a doubt about how much more superior the
cmakedefine01 (#if instead of #ifdef) solution is...
  (not tested, but might help...)

M  +2    -9    kioslave/file/file.cpp
M  +10   -0    kioslave/file/file.h

http://commits.kde.org/kdelibs/73ea8cee7661579d3c414f510f6a74fc241c3ecf
Comment 4 Dawit Alemayehu 2013-06-16 21:33:48 UTC
Seems to be fixed for 4.9. Feel free to reopen if that is not the case.