Bug 191058 - Deleted tracks stay in collection
Summary: Deleted tracks stay in collection
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Collections/Local (show other bugs)
Version: 2.0.90
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
: 190169 194200 195139 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-04-29 18:40 UTC by Unknown
Modified: 2009-12-25 23:07 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
crash backtrace (9.58 KB, application/octet-stream)
2009-05-01 16:06 UTC, Unknown
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Unknown 2009-04-29 18:40:52 UTC
Version:           2.0.90 (using 4.2.2 (KDE 4.2.2), Kubuntu packages)
Compiler:          cc
OS:                Linux (i686) release 2.6.28-11-generic

I moved two directories from my collection to somewhere out of the collection using Dolphin. Since then, I clicked "Rescan collection", restarted Amarok and even restarted the PC, but they are still in the collection somehow: Filtering for them in the collection browser shows nothing, but the number of tracks did not go down. In addition, when I move the whole collection to the playlist, the removed files are in there (of course, it can't play them). I don't want to (again) remove the collection database, but obviously that is the only way to get a track out of the collection which got removed by another application?

This is Amarok 2.1 Beta from kubuntu-unstable
Comment 1 Unknown 2009-05-01 16:06:11 UTC
Even when it's amarok which renames the files (by choosing "organize"), it doesn't remove deleted files and instead duplicates the ones it renames. Selecting "Delete track" on such a non-existing crashes with a backtrace I will attach.
I just lost all the track ratings I did today (what a fool I was to start doing that at all) because I had to remove the collection database - about the 10th time since I updated to Amarok 2...
Comment 2 Unknown 2009-05-01 16:06:58 UTC
Created attachment 33278 [details]
crash backtrace
Comment 3 Unknown 2009-05-02 12:00:32 UTC
There really is no way to get a track out of the collection (besides removing the database, that is) - the "Remove track" feature of Amarok removes the track from the collection browser, but the track count does not go down, and dragging it to the playlist still contains the removed track.
Comment 4 Seb Ruiz 2009-05-03 06:07:31 UTC
*** Bug 190169 has been marked as a duplicate of this bug. ***
Comment 5 Ralf Jung 2009-05-03 16:59:52 UTC
I have the same issue with the current trunk
Comment 6 Myriam Schweingruber 2009-05-31 10:14:59 UTC
Does this still happen with Amarok 2.1?
Comment 7 Lydia Pintscher 2009-05-31 10:23:52 UTC
Yes it still happens. Tracks only get removed after a restart
Comment 8 Mikko C. 2009-05-31 10:43:34 UTC
*** Bug 194200 has been marked as a duplicate of this bug. ***
Comment 9 Ralf Jung 2009-06-01 17:49:06 UTC
I tested it again with current trunk.
Renaming a file works great now, be it by an other application or by Amarok itself using "Organize Tracks".
Removing still has some problems though: Removing the file works, and the overall track count is correctly reduced. However, when I copy the same file back, it reproducibly (tried it two times) is not recognized by Amarok. The track count goes back up, but the file is not shown in the collection, no matter how often I restart amarok or rescan the collection. Only removing the database fixes it.
Comment 10 Mikko C. 2009-06-23 21:30:34 UTC
Can you try with current trunk? There's been a commit that should have fixed this.
Comment 11 Ralf Jung 2009-06-25 15:29:30 UTC
Yes, it seems this got fixed - thanks a lot :)
Comment 12 Mikko C. 2009-06-25 16:18:08 UTC
Thanks for testing :)
Comment 13 Myriam Schweingruber 2009-06-25 16:52:50 UTC
*** Bug 195139 has been marked as a duplicate of this bug. ***
Comment 14 Vovochka 2009-12-23 15:08:20 UTC
Also it doesn't reread tags of existing files.
I'm russian and many song in our (russian) case have ID3 with cp1251.
Amarok doesn't work with diffrent encodings - ok. But when such files fall into collectio, I see names in wrong encoding. I convert tags to utf8 but! There is no way to make amarok see such changes, except deleting the collection and rescaning folders again. It's annoy.
Comment 15 Vovochka 2009-12-23 15:09:34 UTC
Sorry, dosn't notice that this report is closed :-D
Comment 16 Jeff Mitchell 2009-12-24 00:41:00 UTC
(In reply to comment #14)
> Also it doesn't reread tags of existing files.
> I'm russian and many song in our (russian) case have ID3 with cp1251.
> Amarok doesn't work with diffrent encodings - ok. But when such files fall into
> collectio, I see names in wrong encoding. I convert tags to utf8 but! There is
> no way to make amarok see such changes, except deleting the collection and
> rescaning folders again. It's annoy.

I don't understand. How exactly do you expect Amarok to notice that tags have changed if it doesn't rescan those files?
Comment 17 Vovochka 2009-12-24 00:42:17 UTC
(In reply to comment #16)
> (In reply to comment #14)
> > Also it doesn't reread tags of existing files.
> > I'm russian and many song in our (russian) case have ID3 with cp1251.
> > Amarok doesn't work with diffrent encodings - ok. But when such files fall into
> > collectio, I see names in wrong encoding. I convert tags to utf8 but! There is
> > no way to make amarok see such changes, except deleting the collection and
> > rescaning folders again. It's annoy.
> 
> I don't understand. How exactly do you expect Amarok to notice that tags have
> changed if it doesn't rescan those files?

May be rescan files with changed last mod time?
Comment 18 Myriam Schweingruber 2009-12-25 08:42:18 UTC
Well, a full collection rescan should be enough to make those show up. 
Vovochka, please do not post to closed bugs of other version, I bet you do not use Amarok 2.0.90, don't you?
Comment 19 Jeff Mitchell 2009-12-25 23:07:56 UTC
Well right -- I asked how you expect Amarok to notice changes in the tags of files without rescanning, and your answer is to rescan -- which was my point.

FWIW, Amarok detects changes in the mtimes of the defined folders in your collection -- not of each individual file. (There are several reasons for this that I won't go into here.) Simply doing a "touch" on the directory with the changed files will cause the incremental scan to include that directory next time. Note that this behavior changed a bit around 2.2.1 -- if you have changed files in subdirectories as well, you touch those subdirectories too.