Bug 190811 - SmRestartStyleHint SmCard8 type is set/got as an int, but should be as an 8bit type
Summary: SmRestartStyleHint SmCard8 type is set/got as an int, but should be as an 8bi...
Status: RESOLVED FIXED
Alias: None
Product: ksmserver
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Lubos Lunak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-27 13:31 UTC by Caolan McNamara
Modified: 2009-04-28 16:03 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
proposed patch to fix (2.23 KB, patch)
2009-04-27 13:32 UTC, Caolan McNamara 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Caolan McNamara 2009-04-27 13:31:40 UTC 
Version:            (using KDE 4.2.2)
OS:                Linux
Installed from:    Fedora RPMs

As per http://www.xfree86.org/current/SMlib.pdf the SmRestartStyleHint property is a SmCard8, and a SmCard8 is a CARD8 which is an 8bit type. So apps that attempt to set a SmRestartNever of 3 end up with

restartStyleHint13=-1202323453
in ~/.kde/share/config/ksmserverrc

and get launched on the next session. The attached patch fixes up the types and give me the expected results that the app doesn't get launched in the next session
Comment 1 Caolan McNamara 2009-04-27 13:32:07 UTC 
Created attachment 33154 [details]
proposed patch to fix
Comment 2 Dario Andres 2009-04-28 01:30:14 UTC 
Moving to KSMServer
Comment 3 Lubos Lunak 2009-04-28 16:01:40 UTC 
SVN commit 960495 by lunakl:

CARD8 is not int, thanks for the patch.
BUG: 190811



 M  +1 -1      ksmserver/client.cpp  
 M  +2 -2      kwin/sm.cpp  
 M  +2 -2      libs/kworkspace/kworkspace.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=960495
Comment 4 Lubos Lunak 2009-04-28 16:03:54 UTC 
SVN commit 960497 by lunakl:

CARD8 is not int.
CCBUG: 190811



 M  +1 -1      ksmserver/client.cpp  
 M  +2 -2      kwin/sm.cpp  
 M  +2 -2      libs/kworkspace/kworkspace.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=960497