Bug 190704 - librivox searches which include spaces are displayed with %20
Summary: librivox searches which include spaces are displayed with %20
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Internet Services (show other bugs)
Version: 2.1-SVN
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-26 14:29 UTC by Alan Jenkins
Modified: 2009-07-18 14:14 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot (47.99 KB, image/png)
2009-04-26 14:30 UTC, Alan Jenkins
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Jenkins 2009-04-26 14:29:06 UTC
Version:           2.0.2 (using KDE 4.2.2)
OS:                Linux
Installed from:    Ubuntu Packages

1. Open Amarok and visit "Librivox.org" under the "Internet" tab in the sidebar.
2. Enter a multi-word search such as "foo bar"

In the results, the query is displayed as "foo bar%20".
"foo bar baz" displays as "foo bar%20baz%20".
Comment 1 Alan Jenkins 2009-04-26 14:30:21 UTC
Created attachment 33119 [details]
Screenshot
Comment 2 Myriam Schweingruber 2009-05-31 10:03:14 UTC
Alan, can you reproduce this with Amarok 2.1?
Comment 3 Alan Jenkins 2009-05-31 10:31:10 UTC
Myriam, I am unlikely to upgrade any time soon.

I am confident in my instructions, and this seems a pretty generic issue :-).  If you cannot reproduce it in 2.1 then feel free to mark this as fixed (and maybe WORKSFORME).

I have email archives of all the bugs I report, so if I eventually find that it still happens in 2.1 the it will be simple for me to reopen it.

Thanks
Comment 4 Myriam Schweingruber 2009-05-31 14:11:32 UTC
I tried with 2.1 final and a search of 'William Shakespeare' gives the result 'William Shakespeare%20'. So the behavior has at least improved a little.
Comment 5 Alan Jenkins 2009-05-31 15:31:06 UTC
(In reply to comment #4)
> I tried with 2.1 final and a search of 'William Shakespeare' gives the result
> 'William Shakespeare%20'. So the behavior has at least improved a little.

That's exactly the behaviour I reported above - "foo bar" gives the result "foo bar%20".

Thanks for confirming that this happens in version 2.1.
Comment 6 Nikolaj Hald Nielsen 2009-07-18 14:14:19 UTC
SVN commit 998725 by nhnielsen:

Fix escaped space "%20" being shown at the end of each filter value in the LibriVox service
BUG: 190704



 M  +1 -1      scripts/librivox_service/main.js  
 M  +1 -0      services/scriptable/ScriptableServiceQueryMaker.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=998725