Bug 190609 - konqueror crashes on large json file
Summary: konqueror crashes on large json file
Status: RESOLVED WORKSFORME
Alias: None
Product: konqueror
Classification: Applications
Component: kjs (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR crash
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-25 11:45 UTC by Jos van den Oever
Modified: 2021-01-02 04:34 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jos van den Oever 2009-04-25 11:45:52 UTC
Version:            (using Devel)
OS:                Linux
Installed from:    Compiled sources

when loading http://ktown.kde.org/~vandenoever/gardentree/nice.html konqueror crashes with this (recursive) backtrace:

#58192 0x00007f9108c30c23 in KJS::NodeVisitor::visit (this=0x7f9108eb0670,
    node=0x7fff20802cf0) at /home/kde-devel/src/KDE/kdelibs/kjs/nodes.cpp:250
#58193 0x00007f9108c336c4 in KJS::PropertyListNode::recurseVisit (
    this=0x4eafed0, visitor=0x7fff20802cf0)
    at /home/kde-devel/src/KDE/kdelibs/kjs/nodes.h:148
#58194 0x00007f9108c30c23 in KJS::NodeVisitor::visit (this=0x7f9108eb0670,
    node=0x7fff20802cf0) at /home/kde-devel/src/KDE/kdelibs/kjs/nodes.cpp:250
#58195 0x00007f9108c336c4 in KJS::PropertyListNode::recurseVisit (
    this=0x4eafd50, visitor=0x7fff20802cf0)
    at /home/kde-devel/src/KDE/kdelibs/kjs/nodes.h:148

The bottom of the stacktrace is unavailable because gdb crashes when trying to display it.
Comment 1 Maksim Orlovich 2009-04-25 19:48:10 UTC
SVN commit 959204 by orlovich:

Don't walk object literals for declarations; they can't possibly 
be there, and we may run out of stack space doing this.

I think I'll probably switch over how we do declarations at some point, though 
--- since we now track the active function context in the grammar, we should 
be able to keep track of declarations at the time, avoiding extra AST walks.


CCBUG:190609


 M  +4 -3      nodes.cpp  
 M  +5 -3      nodes.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=959204
Comment 2 Maksim Orlovich 2009-04-25 19:49:50 UTC
SVN commit 959208 by orlovich:

automatically merged revision 959204:
Don't walk object literals for declarations; they can't possibly 
be there, and we may run out of stack space doing this.

I think I'll probably switch over how we do declarations at some point, though 
--- since we now track the active function context in the grammar, we should 
be able to keep track of declarations at the time, avoiding extra AST walks.


CCBUG:190609

 M  +4 -3      nodes.cpp  
 M  +5 -3      nodes.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=959208
Comment 3 Maksim Orlovich 2009-04-26 23:28:10 UTC
SVN commit 959712 by orlovich:

Cache and coalesce StringImp's for sufficiently short string literals.
This cuts heap usage by about 48% on vandenoever's heap demo; 
also seems to be about ~2% speedup on SunSpider --- perhaps, it's noisy;
but with a clear 1.11x or so on string-unpack-code which is fairly 
realistic piece of code, too 

CCBUG:190609


 M  +0 -31     identifier.cpp  
 M  +0 -2      identifier.h  
 M  +45 -0     interpreter.cpp  
 M  +18 -0     interpreter.h  
 M  +3 -1      nodes.h  
 M  +21 -5     nodes2bytecode.cpp  
 M  +20 -0     ustring.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=959712
Comment 4 Maksim Orlovich 2009-04-26 23:34:53 UTC
SVN commit 959716 by orlovich:

automatically merged revision 959712:
Cache and coalesce StringImp's for sufficiently short string literals.
This cuts heap usage by about 48% on vandenoever's heap demo; 
also seems to be about ~2% speedup on SunSpider --- perhaps, it's noisy;
but with a clear 1.11x or so on string-unpack-code which is fairly 
realistic piece of code, too 

CCBUG:190609

 M  +0 -31     identifier.cpp  
 M  +0 -2      identifier.h  
 M  +45 -0     interpreter.cpp  
 M  +18 -0     interpreter.h  
 M  +3 -1      nodes.h  
 M  +21 -5     nodes2bytecode.cpp  
 M  +20 -0     ustring.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=959716
Comment 5 Justin Zobel 2020-12-03 22:37:25 UTC
Thank you for the report, Jos.

As it has been a while since this was reported, can you please test and confirm if this issue is still occurring or if this bug report can be marked as resolved.

I have set the bug status to "needsinfo" pending your response, please change back to "reported" or "resolved/worksforme" when you respond, thank you.
Comment 6 Bug Janitor Service 2020-12-18 04:34:48 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 7 Bug Janitor Service 2021-01-02 04:34:22 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!