Bug 185341 - show grid doesn't show anything
Summary: show grid doesn't show anything
Status: RESOLVED FIXED
Alias: None
Product: kword
Classification: Miscellaneous
Component: general (show other bugs)
Version: 1.9.8
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Thomas Zander
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-23 14:41 UTC by Elián Hanisch
Modified: 2009-03-02 12:47 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Elián Hanisch 2009-02-23 14:41:15 UTC
Version:           2.0 beta-6 (using 4.1.2 (KDE 4.1.2), Kubuntu packages)
Compiler:          gcc
OS:                Linux (i686) release 2.6.24-23-generic

snap to grid does have some effect in flake shapes, but I can't see the grid with view -> show grid
Comment 1 Thomas Zander 2009-03-01 20:15:14 UTC
SVN commit 933849 by zander:

Sometimes you get a bugreport and while it seems innocent enough it uncovers a
big pile of unfinished and not-well-thought-out code...

So we have a nice abstraction for grids; with a centralized painting method
and all. Awesome!
The way its hooked into the UI was not so awesome as we have the strings and
action in each application. All of them slightly different and all of them buggy.

So, here you are;
* Moved the creation of an action to the KoGridData which centralizes the
i18n usage. (not yet, need to do that after the string freeze lifts)
It also means that things work for multiple views the way you expect.

* renamed the action as it is known in the actionCollection to view_grid to
make it consistent across all apps.

CCBUG:185341
The final part that fixes the bug is to actually draw the grid in KWord. I have that patch
at work and will commit tomorrow.

 M  +2 -2      karbon/data/karbon.rc  
 M  +6 -15     karbon/ui/KarbonView.cpp  
 M  +0 -1      karbon/ui/KarbonView.h  
 M  +2 -2      krita/krita.rc  
 M  +7 -7      krita/ui/canvas/kis_grid_manager.cpp  
 M  +0 -1      krita/ui/canvas/kis_grid_manager.h  
 M  +3 -8      kword/part/KWView.cpp  
 M  +0 -2      kword/part/KWView.h  
 M  +4 -10     libs/kopageapp/KoPAView.cpp  
 M  +0 -2      libs/kopageapp/KoPAView.h  
 M  +37 -9     libs/main/KoGridData.cpp  
 M  +10 -2     libs/main/KoGridData.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=933849
Comment 2 Thomas Zander 2009-03-02 12:47:53 UTC
SVN commit 934066 by zander:

Draw the grid too..
BUG:185341

 M  +7 -0      KWCanvas.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=934066