Bug 183694 - size-restoring broken
Summary: size-restoring broken
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: general (show other bugs)
Version: git master
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-08 16:25 UTC by Andreas Pakulat
Modified: 2012-03-11 10:21 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Pakulat 2009-02-08 16:25:59 UTC
due to custom code copied from xmlgui framework, to support the storing of our area's the size-restoring upon start is broken. If I have kdevelop started in maximized mode then the next time it starts its only maximized horizontally. 

What I notice is that we have two groups "MainWindow" and "Main Window", the former having proper information stored (height/width = max-size+1) and also state and toolbar-information. The latter uses a slightly different format for storing the geometry and that geometry is indeed broken, i.e. the height is about 400 pixel here.
Comment 1 Milian Wolff 2009-07-20 16:01:09 UTC
works for me, seems like it was fixed.
Comment 2 Andreas Pakulat 2009-07-21 07:03:46 UTC
No definetly not fix, I still have this all the time on my home machine. However, it could be a kwin vs. plasma bug as I can't reproduce it here on my laptop and my home machine has 2 screen's. One containing a horizontal panel and the kdevelop window is on the screen without panel and seems to be vertically sized as if there was a panel on that screen. I'll do some more experimenting with other applications and then re-assign to the proper component.
Comment 3 Andreas Pakulat 2009-11-16 23:48:27 UTC
definetly a kwin or plasma problem, kate works, but konqueror also doesn't work. Neither does konsole. Re-Assigning. 

As I said this mostly happens when these apps restore to "maximized" on a second screen that has no panel. The other screen does have a panel and the restored apps are missing the height of the panel. That is they're as high as the screen minus the height of the panel.
Comment 4 Thomas Lübking 2011-11-12 21:00:25 UTC
Can you please check whether https://git.reviewboard.kde.org/r/103121/ fixes it for you? Thanks.
Comment 5 Thomas Lübking 2011-11-13 17:53:45 UTC
Git commit c64f22c20ba8947ff1259ad2b3d14037f671f7d7 by Thomas Lübking.
Committed on 12/11/2011 at 21:39.
Pushed by luebking into branch 'master'.

Move maximization when managing client

Maximization of oversized windows must happen BEFORE keepInArea() is called
because that will through resizeWithChecks() lead to an artificial constrainment
to the WorkArea which is the combination of all screens minus all struts
this fails if only one screen struts and as a result the window is no more
bigger than FullArea which is used as maximization enforcing condition.
(Maximization must also happen AFTER placement, because otherwise the window
will eventually be maximized to the wrong MaximizeArea - Screens(s) - (local) struts
depending on xinerama settings)

BUG:285967
CCBUG:286146
CCBUG:183694

FIXED-IN:4.8

M  +32   -20   kwin/manage.cpp

http://commits.kde.org/kde-workspace/c64f22c20ba8947ff1259ad2b3d14037f671f7d7
Comment 6 Thomas Lübking 2012-03-11 07:00:53 UTC
is this -considering the patch- still an issue?
Comment 7 Andreas Pakulat 2012-03-11 10:21:23 UTC
No idea wether I'm running with that patch (I assume no since I'm still on 4.6), but I cannot reproduce the problem anymore.