Version: (using KDE 4.1.4) Installed from: Mandriva RPMs Hi, It would be nice to have specific icons for the export plugins (facebook, flickr,...). In wish format (.svg ? .png ?) should I submit icons ? Best wishes, Julien
Julien, We need SVG as reference image. generating all png images for all icon sizes is trivial to do from svg. Thanks in advance Gilles Caulier
Created attachment 31190 [details] Icon Facebook
Created attachment 31191 [details] Icon flickr
Created attachment 31192 [details] Icon Picasa
Risto, Can you review svg icons from Julien ? Thanks in advance Gilles Caulier
Created attachment 31193 [details] Icon Flash
Created attachment 31194 [details] Icon SmugMug
I have created using Inkscape all these logos except the flickr logo. The flickr logo is a modified version of kflickr's logo. The logo themselves may be copyrighted. I don't know if it is legal to use them. Look here to see what wikipedia says about copyright/trademark of a logo: http://en.wikipedia.org/wiki/File:Picasa.svg Julien
SVN commit 938386 by lure: Add action icons for Picasa, Flickr, Facebook, Flash and SmugMug. SVG icons are from Julien Narboux - thanks for your contribution. BUG: 183661 CCMAIL: Julien@narboux.fr M +1 -0 AUTHORS M +2 -1 NEWS M +2 -0 facebook/CMakeLists.txt A facebook/icons (directory) A facebook/icons/CMakeLists.txt AM facebook/icons/hi128-action-facebook.png AM facebook/icons/hi16-action-facebook.png AM facebook/icons/hi22-action-facebook.png AM facebook/icons/hi32-action-facebook.png AM facebook/icons/hi48-action-facebook.png AM facebook/icons/hi64-action-facebook.png AM facebook/icons/hisc-action-facebook.svgz M +4 -2 facebook/plugin_facebook.cpp M +2 -0 flashexport/CMakeLists.txt A flashexport/icons (directory) A flashexport/icons/CMakeLists.txt AM flashexport/icons/hi128-action-flash.png AM flashexport/icons/hi16-action-flash.png AM flashexport/icons/hi22-action-flash.png AM flashexport/icons/hi32-action-flash.png AM flashexport/icons/hi48-action-flash.png AM flashexport/icons/hi64-action-flash.png AM flashexport/icons/hisc-action-flash.svgz M +3 -1 flashexport/plugin_flashexport.cpp M +2 -0 flickrexport/CMakeLists.txt A flickrexport/icons (directory) A flickrexport/icons/CMakeLists.txt AM flickrexport/icons/hi128-action-flickr.png AM flickrexport/icons/hi16-action-flickr.png AM flickrexport/icons/hi22-action-flickr.png AM flickrexport/icons/hi32-action-flickr.png AM flickrexport/icons/hi48-action-flickr.png AM flickrexport/icons/hi64-action-flickr.png AM flickrexport/icons/hisc-action-flickr.svgz M +3 -1 flickrexport/plugin_flickrexport.cpp M +1 -0 picasawebexport/CMakeLists.txt A picasawebexport/icons (directory) A picasawebexport/icons/CMakeLists.txt AM picasawebexport/icons/hi128-action-picasa.png AM picasawebexport/icons/hi16-action-picasa.png AM picasawebexport/icons/hi22-action-picasa.png AM picasawebexport/icons/hi32-action-picasa.png AM picasawebexport/icons/hi48-action-picasa.png AM picasawebexport/icons/hi64-action-picasa.png AM picasawebexport/icons/hisc-action-picasa.svgz M +3 -1 picasawebexport/plugin_picasawebexport.cpp M +2 -0 smug/CMakeLists.txt A smug/icons (directory) A smug/icons/CMakeLists.txt AM smug/icons/hi128-action-smugmug.png AM smug/icons/hi16-action-smugmug.png AM smug/icons/hi22-action-smugmug.png AM smug/icons/hi32-action-smugmug.png AM smug/icons/hi48-action-smugmug.png AM smug/icons/hi64-action-smugmug.png AM smug/icons/hisc-action-smugmug.svgz M +4 -2 smug/plugin_smug.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=938386
Created attachment 34231 [details] Svg icon for 23
Created attachment 34232 [details] Svg icon for gallery export
Julien. Warning. this file is already closed... For me, your icons sound fine. So you can add it to svn directly. Please follow instructions below : - For 23 export, go to flickrexport plugin : http://lxr.kde.org/source/extragear/graphics/kipi-plugins/flickrexport/icons/ You need to generate 23 PNG icons files using same naming scheme than flickr icons. Don't forget SVG file too. In code, for 23 export, icon name must be set there : http://lxr.kde.org/source/extragear/graphics/kipi-plugins/flickrexport/plugin_flickrexport.cpp#83 - For Gallery, there is no icons subfolder in plugin. You need to create this one as with flickrexport. Don't forget to register icons sub-folder in lead CMakeLists.txt as it do with flicrexport there: http://lxr.kde.org/source/extragear/graphics/kipi-plugins/flickrexport/CMakeLists.txt#1 ... and register icon name to plugin here : http://lxr.kde.org/source/extragear/graphics/kipi-plugins/galleryexport/plugin_galleryexport.cpp#77 That all. Gilles Caulier
Gilles, I did what you said for 23 export, but I still get a "question mark" instead of the right icon. It seems that the "make install" does not install the 23 icon. Is there another cmake file I should update ? Thanks for your help, Julien
well, in FlickrExport/icons, a CMakeLists.txt file already exist : http://lxr.kde.org/source/extragear/graphics/kipi-plugins/flickrexport/icons/CMakeLists.txt and is enough. Perhaps you need to restart cmake . from root kipi-plugins dir to regenrate Makefiles with cmake, including new icon files. In GalleryExport/icons, of course, this file must be created. Gilles Caulier
Julien, delete your plugin library and install it again. It could be that it has not been updated. I had the same problem, removing /usr/lib/kde4/kipiplugin_flickrexport.so helped. Andi