Bug 183131 - Missed icons for - "Caption/Tags", "Metadata", "Image Editor", "Color Management"
Summary: Missed icons for - "Caption/Tags", "Metadata", "Image Editor", "Color Managem...
Status: RESOLVED DOWNSTREAM
Alias: None
Product: digikam
Classification: Applications
Component: Usability-Themes (show other bugs)
Version: 0.10.0
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-04 07:26 UTC by Valery Novikov
Modified: 2022-01-13 06:23 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 7.5.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Valery Novikov 2009-02-04 07:26:32 UTC
Version:           0.10.0-rc1 (using KDE 4.2.0)
OS:                Linux
Installed from:    Gentoo Packages

Hi!

There are some missed icons in Digikam GUI (icons with questions currently presented).

"Caption/Tags", "Metadata" - in right panel on main window
"Metadata", "Image Editor", "Color Management" - in "Conigure" dialog
"Edit" button in "Edit" menu of main window

Thanks.
Comment 1 caulier.gilles 2009-02-04 08:05:03 UTC
Sound like a broken package installation. It's not reproducible here.

Gilles Caulier
Comment 2 Marcel Wiesweg 2009-02-04 10:55:01 UTC
All these icons are shipped with digikam and installed by default. This must be a downstream problem. The icons you describe are "action/exifinfo", "action/imagecomment", "action/editimage", "action/colormanagement".
Did you compile manually from SVN?
Comment 3 Andi Clemens 2009-02-04 11:07:50 UTC
This is definitely a downstream error and nothing we can help.
You can try to re-run kbuildsycoca4, maybe this helps.
I'll close this one now.

Valery,

please report the bug to your distributor, http://bugs.gentoo.org/ should be the right place.

Andi
Comment 4 Tomáš Chvátal 2009-02-09 22:27:50 UTC
(In reply to comment #3)
> This is definitely a downstream error and nothing we can help.
> You can try to re-run kbuildsycoca4, maybe this helps.
> I'll close this one now.
> 
> Valery,
> 
> please report the bug to your distributor, http://bugs.gentoo.org/ should be
> the right place.
> 
> Andi
> 

Ok guys we use this sed:
    # Fix files collision, use icon from kdebase-data rather that digikam ones
    sed -i \
        -e "s:add_subdirectory:#add_subdirectory:g" \
        data/icons/CMakeLists.txt || die "Failed to remove icon install"
because of you shiping the icons which are already shipped with kde, so you give us file collisions...
the colliding files are:
 * kde-base/kdebase-data-4.2.0
 *      /usr/share/icons/oxygen/128x128/apps/digikam.png
 *      /usr/share/icons/oxygen/16x16/actions/transform-crop-and-resize.png
 *      /usr/share/icons/oxygen/16x16/actions/view-object-histogram-linear.png
 *      /usr/share/icons/oxygen/16x16/actions/view-object-histogram-logarithmic.png
 *      /usr/share/icons/oxygen/16x16/apps/digikam.png
 *      /usr/share/icons/oxygen/22x22/actions/transform-crop-and-resize.png
 *      /usr/share/icons/oxygen/22x22/actions/view-object-histogram-linear.png
 *      /usr/share/icons/oxygen/22x22/actions/view-object-histogram-logarithmic.png
 *      /usr/share/icons/oxygen/22x22/apps/digikam.png
 *      /usr/share/icons/oxygen/32x32/actions/transform-crop-and-resize.png
 *      /usr/share/icons/oxygen/32x32/actions/view-object-histogram-linear.png
 *      /usr/share/icons/oxygen/32x32/actions/view-object-histogram-logarithmic.png
 *      /usr/share/icons/oxygen/32x32/apps/digikam.png
 *      /usr/share/icons/oxygen/48x48/actions/transform-crop-and-resize.png
 *      /usr/share/icons/oxygen/48x48/apps/digikam.png
 *      /usr/share/icons/oxygen/64x64/apps/digikam.png
 *      /usr/share/icons/oxygen/scalable/actions/transform-crop-and-resize.svgz
 *      /usr/share/icons/oxygen/scalable/actions/view-object-histogram-linear.svgz
 *      /usr/share/icons/oxygen/scalable/actions/view-object-histogram-logarithmic.svgz
 *      /usr/share/icons/oxygen/scalable/apps/digikam.svgz

i know that those files are probably yours so make your mind and tell kde to stop shipping them or you rely on kde and dont ship your ones.

Or at least tell me if i should really really use yours or the kde-base one
Comment 5 Maciej Mrozowski 2009-02-11 22:53:40 UTC
I love all those bugs resolved as 'DOWNSTREAM'... (a'ka WONTFIX)
Situation is clear:
- kdebase-runtime ships some icons
- digikam ships some icons that overwrite those from KDE
- upstream needs to decide whether to ship them here or there
Comment 6 Marcel Wiesweg 2009-02-11 23:16:29 UTC
If they are both here and there I dont see the reason why users get none. I'm not familiar if we pushed them to kdebase, if it's usual that KDE takes common icons. Maybe they are needed for certain KDE versions or not for others.
Comment 7 Maciej Mrozowski 2009-02-12 00:04:55 UTC
Users get some of them (not none) as we usually disable installing package Oxygen icons when we detect (upon source package/scripts preparation) that they are already provided by KDE. Of course we could check those icons one by one for every package but I believe upstream has more means to sort such issues out - besides statistically such issues are very rare - usually with koffice and some extragear/playground stuff - and usually after some time things are clarified and duplicates are being removed without our "intervention". Of course those packages are allowed to provide even full Oxygen icon set if they want...