Bug 182994 - Allow user to change background colour
Summary: Allow user to change background colour
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 0.7.4
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
: 307116 319736 372055 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-02-03 13:57 UTC by Claus Appel
Modified: 2017-10-18 19:56 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Claus Appel 2009-02-03 13:57:52 UTC
Version:           0.7.4 (using 4.1.4 (KDE 4.1.4), 4.1.4-2.fc9 Fedora)
Compiler:          gcc
OS:                Linux (i686) release 2.6.27.12-78.2.8.fc9.i686

If the document displayed is narrower than the Okular window, some empty background is visible to the left and right of the document. Is it possible for the user to change the colour of this background? On my system it is a light blue colour, which does not seem to conform to anything I have in my KDE colour settings. 

The Okular Preferences include an option to select the background colour used in presentation mode, but not in regular mode and full screen mode. Please add such an option.
Comment 1 Jan Kaspar 2009-03-11 11:12:55 UTC
I fully support this wish. The white background can sometimes can be very unfortunate - an example: for my presentations I use logos which are white/transparent. On white background you cannot see anything...

A custom background color might be a good option. Or a checked pattern background (like in Gimp for transparent background)...

Kašpi
Comment 2 Maciej Pilichowski 2009-03-11 11:22:46 UTC
Jan, I believe you are talking about document background color ("paper" color), not about okular background (and this wish is about that).
Comment 3 Jan Kaspar 2009-03-11 11:30:08 UTC
You're right, Maciej. Moreover I realized that one can change the paper color in Okular settings. Thus, please, forget my previous posting.

Thanks, Jan.
Comment 4 Nate Graham 2017-09-29 04:31:45 UTC
*** Bug 307116 has been marked as a duplicate of this bug. ***
Comment 5 Nate Graham 2017-09-29 04:31:52 UTC
*** Bug 319736 has been marked as a duplicate of this bug. ***
Comment 6 Nate Graham 2017-09-29 04:32:01 UTC
*** Bug 372055 has been marked as a duplicate of this bug. ***
Comment 7 Nate Graham 2017-10-01 01:45:53 UTC
Git commit 6b5a7c9a1a00dec994cfb03b0abf369539168758 by Nathaniel Graham.
Committed on 01/10/2017 at 01:45.
Pushed by ngraham into branch 'master'.

Custom background color

Summary:

Adds an option to the config dialog that enables background color (the color around the displayed page) to be changed (while by default preserving the Qt toolkit selection as not to affect existing users).

Reasons for this change:
Accessibility, eye strain, aesthetic reasons, color displayed on monitor can affect power consumption (how: depends on display technology).
Many people want this change occording to Bugzilla and other sources.

Maintenance: Nearly no additional maintenance:
This is no new subsystem but a trivial feature with no complex code dependencies, and we are already showing a colour selection dialog and setting colours in other places in Okular.

{F4257766}

Other less important information:
https://git.reviewboard.kde.org/r/130219/
https://mail.kde.org/pipermail/okular-devel/2017-September/025520.html

Test Plan:
Tested everything, it all works:
Toggled the custom background color, changed custom background color, removed okular settings file (with: "rm ~/.config/okular*") to verify it uses the usual qt theme colour by default (where the settings file remembered the custom color).

Reviewers: #okular, aacid, elvisangelaccio, rkflx, ngraham

Reviewed By: ngraham

Subscribers: aacid, ltoscano, ngraham

Tags: #okular

Differential Revision: https://phabricator.kde.org/D8051

M  +2    -2    CMakeLists.txt
M  +7    -0    conf/dlggeneral.cpp
M  +3    -0    conf/dlggeneral.h
M  +59   -2    conf/dlggeneralbase.ui
M  +5    -0    conf/okular.kcfg
M  +6    -1    ui/pageview.cpp

https://commits.kde.org/okular/6b5a7c9a1a00dec994cfb03b0abf369539168758
Comment 8 Luigi Toscano 2017-10-01 09:32:19 UTC
Git commit 1f6e8a4782f6f750daf893709e1a043096a837fe by Luigi Toscano, on behalf of Albert Freeman.
Committed on 01/10/2017 at 09:31.
Pushed by ltoscano into branch 'master'.

Custom background color

Summary:

Adds an option to the config dialog that enables background color (the color around the displayed page) to be changed (while by default preserving the Qt toolkit selection as not to affect existing users).

Reasons for this change:
Accessibility, eye strain, aesthetic reasons, color displayed on monitor can affect power consumption (how: depends on display technology).
Many people want this change occording to Bugzilla and other sources.

Maintenance: Nearly no additional maintenance:
This is no new subsystem but a trivial feature with no complex code dependencies, and we are already showing a colour selection dialog and setting colours in other places in Okular.

{F4257766}

Other less important information:
https://git.reviewboard.kde.org/r/130219/
https://mail.kde.org/pipermail/okular-devel/2017-September/025520.html

Test Plan:
Tested everything, it all works:
Toggled the custom background color, changed custom background color, removed okular settings file (with: "rm ~/.config/okular*") to verify it uses the usual qt theme colour by default (where the settings file remembered the custom color).

Reviewers: #okular, aacid, elvisangelaccio, rkflx, ngraham

Reviewed By: ngraham

Subscribers: aacid, ltoscano, ngraham

Tags: #okular

Differential Revision: https://phabricator.kde.org/D8051

M  +2    -2    CMakeLists.txt
M  +7    -0    conf/dlggeneral.cpp
M  +3    -0    conf/dlggeneral.h
M  +59   -2    conf/dlggeneralbase.ui
M  +5    -0    conf/okular.kcfg
M  +6    -1    ui/pageview.cpp

https://commits.kde.org/okular/1f6e8a4782f6f750daf893709e1a043096a837fe