Bug 180609 - Export menu items disabled by default
Summary: Export menu items disabled by default
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-Menus (show other bugs)
Version: 0.10.0
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-14 02:12 UTC by Michael Ploujnikov
Modified: 2017-07-29 06:22 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 0.10.0
Sentry Crash Report:


Attachments
all Export menu items are disabled (431.87 KB, image/png)
2009-01-14 02:14 UTC, Michael Ploujnikov
Details
my digikamrc file (17.19 KB, text/plain)
2009-01-14 02:16 UTC, Michael Ploujnikov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Ploujnikov 2009-01-14 02:12:40 UTC
Version:           0.10.0-rc1 (rev.: 910704) (using KDE 4.1.3)
Compiler:          gcc (GCC) 4.3.0 20080428 (Red Hat 4.3.0-8) 
OS:                Linux
Installed from:    Fedora RPMs

For some reason after building this and an earlier digikam revision the Export menu appears grayed out for me (see screenshot). The menu stays grayed out in all of the left-hand-side tabs except for the "Albums" one. Once I visit the "Albums" tab, the Export menu becomes working in all of the other tabs for me.

Basically, I compiled digikam from SVN.
component info:
digiKam version 0.10.0-rc1 (rev.: 910704)
Exiv2 can write to Jp2: No
Exiv2 can write to Jpeg: Yes
Exiv2 can write to Png: No
Exiv2 can write to Tiff: No
Exiv2 support XMP metadata: Yes
LibCImg: 129
LibExiv2: 0.16
LibJPEG: 62
LibJasper: 1.900.1
LibKDE: 4.1.3 (KDE 4.1.3)
LibKExiv2: 0.6.0
LibKdcraw: 0.5.0
LibLCMS: 117
LibPNG: 1.2.29
LibQt: 4.4.3
LibRaw: 0.7.0-Alpha1
LibTIFF: LIBTIFF, Version 3.8.2 Copyright (c) 1988-1996 Sam Leffler Copyright (c) 1991-1996 Silicon Graphics, Inc.
LibGphoto2: 2.4.0
LibKipi: 0.4.0
Comment 1 Michael Ploujnikov 2009-01-14 02:14:43 UTC
Created attachment 30230 [details]
all Export menu items are disabled

This is what I see in every tab except for the "Albums" tab right after loading digikam.
Comment 2 Michael Ploujnikov 2009-01-14 02:16:22 UTC
Created attachment 30231 [details]
my digikamrc file
Comment 3 Michael Ploujnikov 2009-01-14 03:24:07 UTC
After more experimentation the "Export" menu seems to get enabled and disabled  randomly but reproducibly as I switch between different tabs. For example:
* with the attached digikamrc, digikam starts in the Timeline tab. The "Export" menu is disabled.
* I go to the "Searches" tab and the "Export" menu is still disabled.
* I go to the "Calendar" tab and the "Export" menu stays disabled.
* I go to the "Tags" tab and the "Export" menu becomes enabled.
* I go to the "Calendar" tab and the "Export" menu stays enabled.
* I go to the "Searches" tab and the "Export" menu stays enabled.
* I go to the "Timeline" tab and the "Export" menu becomes disabled.
* I go to the "Calendar" tab and the "Export" menu stays disabled.
* I go to the "Albums" tab and the "Export" menu becomes enabled.
* I go to the "Timeline" tab and the "Export" menu becomes disabled.
* I go to the "Tags" tab and the "Export" menu becomes enabled.
Comment 4 Marcel Wiesweg 2009-01-14 09:58:46 UTC
Gilles, you no better than me the kipi plugins (to test most of them I need login data etc.): They work on the currently selected pictures, don't they? Or do they access the current album? It seems HTML export uses its own album select widget, and not the current album, some others use the current selection.

We currently enable/disable the export actions depending on if there is a physical album or a tag album active; I think this is wrong, they should be enabled if there is any album active? Or if there is a non-empty album?
Comment 5 caulier.gilles 2009-01-14 11:06:05 UTC
Marcel,

Following code from :

http://lxr.kde.org/source/extragear/graphics/digikam/digikam/digikamapp.cpp#1167



Comment 6 caulier.gilles 2009-01-14 11:16:19 UTC
Marcel,

Following code from :

http://lxr.kde.org/source/extragear/graphics/digikam/digikam/digikamapp.cpp#1167

and 

http://lxr.kde.org/source/extragear/graphics/digikam/digikam/digikamapp.cpp#1220

I think that all rules to enable or disable plugins action depending of current album selection is wrong. This must be done directly in plugins code, not in digiKam.

Also, flickrExport for example is a modaless dialog. you can go back to digiKam make a new selection and D&D images to plugin.

There is no reason to not be able to use date album content with flickr export. Currently it's the case. Also the logic used in these method is not clear...

Gilles
Comment 7 caulier.gilles 2009-01-14 13:38:20 UTC
SVN commit 910844 by cgilles:

digiKam from trunk: do not limit export tools to use physical albums/tags contents. 
BUG: 180609


 M  +3 -22     digikamapp.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=910844
Comment 8 caulier.gilles 2009-01-15 19:01:11 UTC
SVN commit 911590 by cgilles:

backport commit #910844 from trunk
CCBUG: 180609


 M  +2 -33     digikamapp.cpp  
 M  +1 -1      digikamapp.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=911590