Bug 180278 - lock-logout applet takes too much space in panel
Summary: lock-logout applet takes too much space in panel
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Unspecified
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-10 17:52 UTC by Antonio Rojas
Modified: 2009-12-11 19:33 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
lock-logout applet in KDE 4.1.3 (11.65 KB, image/png)
2009-01-10 17:54 UTC, Antonio Rojas
Details
lock-logout applet in KDE 4.2 RC1 (14.89 KB, image/png)
2009-01-10 17:55 UTC, Antonio Rojas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Rojas 2009-01-10 17:52:58 UTC
Version:            (using Devel)
Installed from:    Compiled sources

The lock-logout applet takes too much horizontal space in the panel, it doesn't use two rows unless the panel is huge. This was fixed in 4.1 in rev.861676 but apparently didn't make it to trunk.
Comment 1 Antonio Rojas 2009-01-10 17:54:07 UTC
Created attachment 30101 [details]
lock-logout applet in KDE 4.1.3
Comment 2 Antonio Rojas 2009-01-10 17:55:08 UTC
Created attachment 30102 [details]
lock-logout applet in KDE 4.2 RC1
Comment 3 Aaron J. Seigo 2009-01-12 00:02:18 UTC
SVN commit 909646 by aseigo:

allow the buttons to go down to 16px in size; of course, this screws over everyone with moderate size panels who'd like normal sized icons.
BUG:180278


 M  +12 -4     lockout.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=909646
Comment 4 Antonio Rojas 2009-11-18 18:29:39 UTC
This is happening again in 4.4 svn . What's with the huge icons? If someone wants them, they can now use a different applet for each button, but please don't force everybody to waste precious space on the panel.
Comment 5 Beat Wolf 2009-12-06 19:42:29 UTC
please post a screenshot of your exact problem. thank you (i fix it if you do)
Comment 6 Antonio Rojas 2009-12-06 19:46:52 UTC
(In reply to comment #5)
> please post a screenshot of your exact problem. thank you (i fix it if you do)

See comments #1 and #2
Comment 7 Beat Wolf 2009-12-06 20:06:37 UTC
Ok i see.
Actually there where some bugs in the sizing code for the logout widget.
So, it's not possible to please everybody with the size of those icons. The only possibility i see is to create a option where the user can choose. But that can't be done now (kde 4.4 is in string freeze).

So this bug will not be fixed before kde sc 4.5, unless you have a really convincing proposal how to do it without adding a new option (i actually like the current behaviour).
Comment 8 Antonio Rojas 2009-12-06 20:18:21 UTC
Well, my proposal is to leave it like it was in 4.3. That way everybody can be happy: if you want big icons, just use two applets next to each other (since you can choose which icons they display). If you want small icons, then use just one applet. I just find it a bit absurd to waste a 64x32 space on the panel to display an icon which shows no information at all, it's just there to be clicked.
Comment 9 Beat Wolf 2009-12-11 19:33:13 UTC
fixed that today, should be in the next beta release