SVN commit 906154 by mwiesweg:

Fix a possible source of a crash

CCBUG: 179650

 M  +7 -10     albumfolderview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=906154

The backtrace is not clear, because album->id() is not called in this method.
There is a chance my commit fixed the problem, but there is a good chance it does not.
I am interested in this white-window behavior you decribe. Is it in any way reproducible? Can you select an album in the left side bar and everything works?

Yes, after choosing something on the left everything works - this is not reincarnation of much hated splitter bug :)

To reproduce just remove album (sorry, this has nothing common with restart). No album is getting focus so central area is empty... Have some idea... Yep, the same happens after removing tag. Other panels are not affected - only Albums and Tags.

Crucial part is that nothing in the left panel has focus - is highlighted with blue in Default theme.

Waiting for recompilation. Waiting. Waiting. Waiting.

Bad luck (this one from Tag crash, exactly the same as from Album crash):

from /lib/i686/libc.so.6

Thread 3 (Thread 0xad5f2b90 (LWP 9268)):
#0  0xffffe430 in __kernel_vsyscall ()
#1  0xb6a79b95 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib/i686/libpthread.so.0
#2  0xb6ad70b2 in QWaitCondition::wait () from /usr/lib/qt4/lib/libQtCore.so.4
#3  0xb77f5a22 in Digikam::LoadSaveThread::run () from /home/mikolaj/kde/lib/libdigikamcore.so.1
#4  0xb6ad6320 in ?? () from /usr/lib/qt4/lib/libQtCore.so.4
#5  0x0ad681b8 in ?? ()
#6  0x00000000 in ?? ()

Thread 2 (Thread 0xac58ab90 (LWP 9270)):
#0  0xffffe430 in __kernel_vsyscall ()
#1  0xb6a79b95 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib/i686/libpthread.so.0
#2  0xb6ad70b2 in QWaitCondition::wait () from /usr/lib/qt4/lib/libQtCore.so.4
#3  0xb77f5a22 in Digikam::LoadSaveThread::run () from /home/mikolaj/kde/lib/libdigikamcore.so.1
#4  0xb6ad6320 in ?? () from /usr/lib/qt4/lib/libQtCore.so.4
#5  0x0aee0130 in ?? ()
#6  0x00000000 in ?? ()

Thread 1 (Thread 0xb4e4b6d0 (LWP 9254)):
[KCrash Handler]
#6  0x081c29b7 in Digikam::Album::id ()
#7  0x08279df4 in Digikam::TagFolderView::slotTextTagFilterChanged ()
#8  0x0827e780 in Digikam::TagFolderView::qt_metacall ()
#9  0xb6bc280a in QMetaObject::activate () from /usr/lib/qt4/lib/libQtCore.so.4
#10 0xb6bc2d82 in QMetaObject::activate () from /usr/lib/qt4/lib/libQtCore.so.4
#11 0xb785a3b3 in Digikam::SearchTextBar::signalSearchTextSettings () from /home/mikolaj/kde/lib/libdigikamcore.so.1
#12 0xb785a42f in Digikam::SearchTextBar::slotTextChanged () from /home/mikolaj/kde/lib/libdigikamcore.so.1
#13 0xb785a8fd in Digikam::SearchTextBar::qt_metacall () from /home/mikolaj/kde/lib/libdigikamcore.so.1
#14 0xb6bc280a in QMetaObject::activate () from /usr/lib/qt4/lib/libQtCore.so.4
#15 0xb6bc2d82 in QMetaObject::activate () from /usr/lib/qt4/lib/libQtCore.so.4
#16 0xb6682b33 in QLineEdit::textChanged () from /usr/lib/qt4/lib/libQtGui.so.4
#17 0xb6689519 in ?? () from /usr/lib/qt4/lib/libQtGui.so.4
#18 0x0ad21038 in ?? ()
#19 0xbfbb2c84 in ?? ()
#20 0xb80b6ff4 in ?? () from /lib/ld-linux.so.2
#21 0x00009c16 in ?? ()
#22 0x01000104 in ?? ()
#23 0x0ad21038 in ?? ()
#24 0x01010004 in ?? ()
#25 0x00000000 in ?? ()

Recompiled digiKam with debug support, there is a bit more info (pasting only last section, the rest is unchanged):

Thread 1 (Thread 0xb4aa86d0 (LWP 16787)):
[KCrash Handler]
#6  Digikam::Album::id (this=0x92c96b8) at /home/mikolaj/kde/src/extragear/graphics/digikam/digikam/album.cpp:188
#7  0x081a89d1 in Digikam::AlbumFolderView::slotTextFolderFilterChanged (this=0x92c96b8, settings=@0x92c0eac) at /home/mikolaj/kde/src/extragear/graphics/digikam/digikam/albumfolderview.cpp:284
#8  0x081aa572 in Digikam::AlbumFolderView::qt_metacall (this=0x92c96b8, _c=QMetaObject::InvokeMetaMethod, _id=2, _a=0xbfdfee8c)
    at /home/mikolaj/kde/build/extragear/graphics/digikam/digikam/albumfolderview.moc:96
#9  0xb6a4e80a in QMetaObject::activate () from /usr/lib/qt4/lib/libQtCore.so.4
#10 0xb6a4ed82 in QMetaObject::activate () from /usr/lib/qt4/lib/libQtCore.so.4
#11 0xb76c9413 in Digikam::SearchTextBar::signalSearchTextSettings (this=0x92bbfb8, _t1=@0x92c0eac) at /home/mikolaj/kde/build/extragear/graphics/digikam/digikam/searchtextbar.moc:84
#12 0xb76c94a6 in Digikam::SearchTextBar::slotTextChanged (this=0x92bbfb8, text=@0xbfdff004) at /home/mikolaj/kde/src/extragear/graphics/digikam/libs/widgets/common/searchtextbar.cpp:133
#13 0xb76c956d in Digikam::SearchTextBar::qt_metacall (this=0x92bbfb8, _c=QMetaObject::InvokeMetaMethod, _id=2, _a=0xbfdfefcc)
    at /home/mikolaj/kde/build/extragear/graphics/digikam/digikam/searchtextbar.moc:73
#14 0xb6a4e80a in QMetaObject::activate () from /usr/lib/qt4/lib/libQtCore.so.4
#15 0xb6a4ed82 in QMetaObject::activate () from /usr/lib/qt4/lib/libQtCore.so.4
#16 0xb650eb33 in QLineEdit::textChanged () from /usr/lib/qt4/lib/libQtGui.so.4
#17 0xb6515519 in ?? () from /usr/lib/qt4/lib/libQtGui.so.4
#18 0x092bbfb8 in ?? ()
#19 0xbfdff004 in ?? ()
#20 0xb7f02ff4 in ?? () from /lib/ld-linux.so.2
#21 0x00005c16 in ?? ()
#22 0x01000104 in ?? ()
#23 0x092bbfb8 in ?? ()
#24 0x01010004 in ?? ()
#25 0x00000000 in ?? ()

Konsole output, these are only first lines. digiKam make queries for several hunderd lines:

digikam(16787)/digikam (core) Digikam::DatabaseBackend::exec: Failure executing query:
digikam(16787)/digikam (core) Digikam::DatabaseBackend::exec: "SELECT id FROM Albums WHERE albumRoot=? AND relativePath=?;"
digikam(16787)/digikam (core) Digikam::DatabaseBackend::exec: "database is locked Unable to fetch row" 5
digikam(16787)/digikam (core) Digikam::DatabaseBackend::exec: Bound values:  (QVariant(int, 1) ,  QVariant(QString, "/Stare") )
digikam(16787)/digikam (core) Digikam::DatabaseBackend::exec: Detected locked database file. There is an active transaction.

digikam(16787)/digikam (core) Digikam::DatabaseBackend::exec: Failure executing query:
digikam(16787)/digikam (core) Digikam::DatabaseBackend::exec: "REPLACE INTO Albums (albumRoot, relativePath, date, caption, collection) VALUES(?, ?, ?, ?, ?);"
digikam(16787)/digikam (core) Digikam::DatabaseBackend::exec: "database is locked Unable to fetch row" 5
digikam(16787)/digikam (core) Digikam::DatabaseBackend::exec: Bound values:  (QVariant(int, 1) ,  QVariant(QString, "/Stare") ,  QVariant(QString, "2008-12-26") ,  QVariant(QString, "") ,  QVariant(QString, "") )
digikam(16787)/digikam (core) Digikam::DatabaseBackend::exec: Detected locked database file. There is an active transaction.

digikam(16787)/digikam (core) Digikam::DatabaseBackend::exec: Failure executing query:
digikam(16787)/digikam (core) Digikam::DatabaseBackend::exec: "SELECT id, album, name, status, category, modificationDate, uniqueHash FROM Images WHERE album=?;"
digikam(16787)/digikam (core) Digikam::DatabaseBackend::exec: "database is locked Unable to fetch row" 5
digikam(16787)/digikam (core) Digikam::DatabaseBackend::exec: Bound values:  (QVariant(int, 0) )
digikam(16787)/digikam (core) Digikam::DImg::load: "/home/mikolaj/Imgs/Stare/drzewa.jpg"  : JPEG file identified
digikam(16787)/digikam (core) Digikam::ImageScanner::addImage: Adding new item "/home/mikolaj/Imgs/Stare/drzewa.jpg"
digikam(16787)/digikam (core) Digikam::DatabaseBackend::exec: Detected locked database file. There is an active transaction.

SVN commit 906732 by mwiesweg:

Fix crash when returning from filtering with no current album, and properly handle this case.

CCBUG: 179650

 M  +8 -1      folderview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=906732

Your toolchain swallowed the important part of the backtrace (#1):

#0  Digikam::Album::id (this=0x0) at /home/marcel/freshmeat/multimedia/kde4/src/extragear/graphics/digikam/digikam/album.cpp:188
#1  0x000000000061ea22 in Digikam::FolderView::collapseView (this=0x14574d0, mode=<value optimized out>)                        
    at /home/marcel/freshmeat/multimedia/kde4/src/extragear/graphics/digikam/digikam/folderview.cpp:647                         
#2  0x00000000006509b0 in Digikam::TagFolderView::slotTextTagFilterChanged (this=0x14574d0, settings=@0x1460f58)                
    at /home/marcel/freshmeat/multimedia/kde4/src/extragear/graphics/digikam/digikam/tagfolderview.cpp:253                      

But thanks to your hint of deleting the current tag, I could easily reproduce and fix this. This bug is fixed.

Unrelated to this, all these "database is locked" errors from your output log look very unusual, this is not normal behavior.

I recreated each step and output was practically identical to what I posted. Maybe you fixed different bug? (Waiting for recompilation ;)

Interesting this about locked database messages: they will appear only when asking for debug info. When closing normally I don't see them, and even after crash when rejecting "show details" there will be none.

Complete backtrace when waiting:

Application: digiKam (digikam), signal SIGSEGV
 [?1034h[Thread debugging using libthread_db enabled]
[Current thread is 1 (Thread 0xb4ac36d0 (LWP 12844))]

Thread 12 (Thread 0xb35b4b90 (LWP 12851)):
#0  0xffffe430 in __kernel_vsyscall ()
#1  0xb5ee0ac6 in nanosleep () from /lib/i686/libc.so.6
#2  0xb5ee08ae in sleep () from /lib/i686/libc.so.6
#3  0xb2b95349 in ?? () from /usr/lib/qt4/plugins/sqldrivers/libqsqlite.so
#4  0x00000000 in ?? ()

Thread 11 (Thread 0xb233bb90 (LWP 12856)):
#0  0xffffe430 in __kernel_vsyscall ()
#1  0xb6920b95 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib/i686/libpthread.so.0
#2  0xb697e0b2 in QWaitCondition::wait () from /usr/lib/qt4/lib/libQtCore.so.4
#3  0xb7696b72 in Digikam::LoadSaveThread::run (this=0x9faea10) at /home/mikolaj/kde/src/extragear/graphics/digikam/libs/threadimageio/loadsavethread.cpp:129
#4  0xb697d320 in ?? () from /usr/lib/qt4/lib/libQtCore.so.4
#5  0x09faea00 in ?? ()
#6  0x00000000 in ?? ()

Thread 10 (Thread 0xb2b3cb90 (LWP 12857)):
#0  0xffffe430 in __kernel_vsyscall ()
#1  0xb6920b95 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib/i686/libpthread.so.0
#2  0xb697e0b2 in QWaitCondition::wait () from /usr/lib/qt4/lib/libQtCore.so.4
#3  0xb7696b72 in Digikam::LoadSaveThread::run (this=0xa0bda78) at /home/mikolaj/kde/src/extragear/graphics/digikam/libs/threadimageio/loadsavethread.cpp:129
#4  0xb697d320 in ?? () from /usr/lib/qt4/lib/libQtCore.so.4
#5  0x0a0bda68 in ?? ()
#6  0x00000000 in ?? ()

Thread 9 (Thread 0xaff46b90 (LWP 12858)):
#0  0xffffe430 in __kernel_vsyscall ()
#1  0xb6920ec2 in pthread_cond_timedwait@@GLIBC_2.3.2 () from /lib/i686/libpthread.so.0
#2  0xb032240b in metronom_sync_loop (this=0xa221ff8) at metronom.c:871
#3  0xb691d315 in start_thread () from /lib/i686/libpthread.so.0
#4  0xb5f22dde in clone () from /lib/i686/libc.so.6

Thread 8 (Thread 0xaf2e4b90 (LWP 12859)):
#0  0xffffe430 in __kernel_vsyscall ()
#1  0xb5f1b101 in select () from /lib/i686/libc.so.6
#2  0xb034b435 in xine_usec_sleep (usec=0) at utils.c:457
#3  0xb032fd8b in video_out_loop (this_gen=0xa226b08) at video_out.c:1246
#4  0xb691d315 in start_thread () from /lib/i686/libpthread.so.0
#5  0xb5f22dde in clone () from /lib/i686/libc.so.6

Thread 7 (Thread 0xaeae3b90 (LWP 12860)):
#0  0xffffe430 in __kernel_vsyscall ()
#1  0xb5f18367 in poll () from /lib/i686/libc.so.6
#2  0xb5172d6a in ?? () from /usr/lib/libglib-2.0.so.0
#3  0xb51730a8 in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0
#4  0xb6a7e717 in QEventDispatcherGlib::processEvents () from /usr/lib/qt4/lib/libQtCore.so.4
#5  0xb6a566fa in QEventLoop::processEvents () from /usr/lib/qt4/lib/libQtCore.so.4
#6  0xb6a568ba in QEventLoop::exec () from /usr/lib/qt4/lib/libQtCore.so.4
#7  0xb697a4c3 in QThread::exec () from /usr/lib/qt4/lib/libQtCore.so.4
#8  0xb036bb39 in Phonon::Xine::XineThread::run () from /home/mikolaj/kde/lib/kde4/plugins/phonon_backend/phonon_xine.so
#9  0xb697d320 in ?? () from /usr/lib/qt4/lib/libQtCore.so.4
#10 0x0a225d40 in ?? ()
#11 0x00000000 in ?? ()

Thread 6 (Thread 0xae2c1b90 (LWP 12863)):
#0  0xb5f182f9 in poll () from /lib/i686/libc.so.6
#1  0xaf72ae93 in ao_alsa_handle_event_thread (data=0xa636db0) at audio_alsa_out.c:150
#2  0xb691d315 in start_thread () from /lib/i686/libpthread.so.0
#3  0xb5f22dde in clone () from /lib/i686/libc.so.6

Thread 5 (Thread 0xadac0b90 (LWP 12864)):
#0  0xffffe430 in __kernel_vsyscall ()
#1  0xb6920b95 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib/i686/libpthread.so.0
#2  0xb0332980 in ao_loop (this_gen=0xa64e7c0) at audio_out.c:345
#3  0xb691d315 in start_thread () from /lib/i686/libpthread.so.0
#4  0xb5f22dde in clone () from /lib/i686/libc.so.6

Thread 4 (Thread 0xaa3ffb90 (LWP 12880)):
#0  0xffffe430 in __kernel_vsyscall ()
#1  0xb6920b95 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib/i686/libpthread.so.0
#2  0xb697e0b2 in QWaitCondition::wait () from /usr/lib/qt4/lib/libQtCore.so.4
#3  0xb7696b72 in Digikam::LoadSaveThread::run (this=0xb55db70) at /home/mikolaj/kde/src/extragear/graphics/digikam/libs/threadimageio/loadsavethread.cpp:129
#4  0xb697d320 in ?? () from /usr/lib/qt4/lib/libQtCore.so.4
#5  0x0b55db60 in ?? ()
#6  0x00000000 in ?? ()

Thread 3 (Thread 0xad295b90 (LWP 12899)):
#0  0xffffe430 in __kernel_vsyscall ()
#1  0xb5f1b101 in select () from /lib/i686/libc.so.6
#2  0xb6a3bb87 in ?? () from /usr/lib/qt4/lib/libQtCore.so.4
#3  0x00000006 in ?? ()
#4  0xb697d320 in ?? () from /usr/lib/qt4/lib/libQtCore.so.4
#5  0x09e83aa0 in ?? ()
#6  0x00000000 in ?? ()

Thread 2 (Thread 0xaca3db90 (LWP 12938)):
#0  0xffffe430 in __kernel_vsyscall ()
#1  0xb6920b95 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib/i686/libpthread.so.0
#2  0xb697e0b2 in QWaitCondition::wait () from /usr/lib/qt4/lib/libQtCore.so.4
#3  0xb7696b72 in Digikam::LoadSaveThread::run (this=0xc12e168) at /home/mikolaj/kde/src/extragear/graphics/digikam/libs/threadimageio/loadsavethread.cpp:129
#4  0xb697d320 in ?? () from /usr/lib/qt4/lib/libQtCore.so.4
#5  0x0c12e158 in ?? ()
#6  0x00000000 in ?? ()

Thread 1 (Thread 0xb4ac36d0 (LWP 12844)):
[KCrash Handler]
#6  Digikam::Album::id (this=0xb50efc0) at /home/mikolaj/kde/src/extragear/graphics/digikam/digikam/album.cpp:188
#7  0x081a89d1 in Digikam::AlbumFolderView::slotTextFolderFilterChanged (this=0xb50efc0, settings=@0xb515224) at /home/mikolaj/kde/src/extragear/graphics/digikam/digikam/albumfolderview.cpp:284
#8  0x081aa572 in Digikam::AlbumFolderView::qt_metacall (this=0xb50efc0, _c=QMetaObject::InvokeMetaMethod, _id=2, _a=0xbfd1b63c)
    at /home/mikolaj/kde/build/extragear/graphics/digikam/digikam/albumfolderview.moc:96
#9  0xb6a6980a in QMetaObject::activate () from /usr/lib/qt4/lib/libQtCore.so.4
#10 0xb6a69d82 in QMetaObject::activate () from /usr/lib/qt4/lib/libQtCore.so.4
#11 0xb76e4413 in Digikam::SearchTextBar::signalSearchTextSettings (this=0xb503228, _t1=@0xb515224) at /home/mikolaj/kde/build/extragear/graphics/digikam/digikam/searchtextbar.moc:84
#12 0xb76e44a6 in Digikam::SearchTextBar::slotTextChanged (this=0xb503228, text=@0xbfd1b7b4) at /home/mikolaj/kde/src/extragear/graphics/digikam/libs/widgets/common/searchtextbar.cpp:133
#13 0xb76e456d in Digikam::SearchTextBar::qt_metacall (this=0xb503228, _c=QMetaObject::InvokeMetaMethod, _id=2, _a=0xbfd1b77c)
    at /home/mikolaj/kde/build/extragear/graphics/digikam/digikam/searchtextbar.moc:73
#14 0xb6a6980a in QMetaObject::activate () from /usr/lib/qt4/lib/libQtCore.so.4
#15 0xb6a69d82 in QMetaObject::activate () from /usr/lib/qt4/lib/libQtCore.so.4
#16 0xb6529b33 in QLineEdit::textChanged () from /usr/lib/qt4/lib/libQtGui.so.4
#17 0xb6530519 in ?? () from /usr/lib/qt4/lib/libQtGui.so.4
#18 0x0b503228 in ?? ()
#19 0xbfd1b7b4 in ?? ()
#20 0xb7f1dff4 in ?? () from /lib/ld-linux.so.2
#21 0x00000c16 in ?? ()
#22 0x01000104 in ?? ()
#23 0x0b503228 in ?? ()
#24 0x01010004 in ?? ()
#25 0x00000000 in ?? ()

1. Create a tag Test/AB
2. Select tag
3. Delete tag with context menu
4. Type ABC to search bar
5. Clear searchbar

=> no crash here, it crashed before the commit

As to your "database locked" messages, if this appears only in the very abnormal situation after a crash, we can ignore them.

Sorry, of course I confirm FIXED :) Just wanted to show that I couldn't reproduce your output.