Bug 179355 - File type association-related programs in "konqueror" module
Summary: File type association-related programs in "konqueror" module
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Unspecified
: NOR normal
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-02 12:28 UTC by markuss
Modified: 2009-03-20 23:09 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description markuss 2009-01-02 12:28:13 UTC
Version:            (using Devel)
Installed from:    Compiled sources

When I choose to uninstall Konqueror, suddenly critical functionality is missing from KDE that goes beyond of just not having a second file manager (in addition to Dolphin) and a web browser.
Let's say that I define Firefox as web browser in System Settings. When Konqueror is not installed, I can't open web sites in Firefox from Akregator, unless I set Firefox as alternative external browser from within Akregator's settings window.

keditfiletype is also no longer available, making it impossible to change existing file type associations.

IMHO file type association-related programs should be moved to kdebase, kdelibs or whatever.
Comment 1 Pino Toscano 2009-01-02 12:55:47 UTC
Did you install KDE with distro packages? If so, then it is a problem with them.
Comment 2 markuss 2009-01-02 14:02:42 UTC
I dug through the KDE source code a little bit. It seems to be really a KDE problem. keditfiletype and the other filetype-related stuff are located in http://websvn.kde.org/trunk/KDE/kdebase/apps/konqueror/settings/filetypes/ (a subfolder of Konqueror) while IMO they should be located in http://websvn.kde.org/trunk/KDE/kdebase/runtime/ or http://websvn.kde.org/trunk/KDE/kdebase/workspace/
Comment 3 Pino Toscano 2009-01-02 14:07:00 UTC
The source location does matters that much.
Still you did not reply to my question: did you install KDE via distro packages or not?
Comment 4 markuss 2009-01-02 14:25:34 UTC
Yes, I did. That's why I also filed a report there: https://bugzilla.novell.com/show_bug.cgi?id=463258
On Monday or Tuesday I can check if Kubuntu is also affected.

Even without being a programmer, I think that the source code location is at least misleading and should be changed --  no matter if it's the distributor's responsibility to change the packages.
Comment 5 David Faure 2009-03-09 17:16:49 UTC
I'll move filetypes to kdebase/runtime, it's even a runtime dependency of kpropertiesdialog, so it would make much sense to have it there indeed.

For that move I needed to centralize a bit of code in kdelibs though, so I'll have to wait until next monday (16 March 2009) to commit the kdebase changes, to make the life of other developers easier.

I see that this is only half of this report though, the problem with launching firefox seems to be related to uninstalling kfmclient, so invokeBrowser fallsback to xdg-open which depends on $BROWSER. Actually, in which browser does xdg-open open the urls for you, if that's neither konqueror nor firefox??
Comment 6 markuss 2009-03-09 17:51:12 UTC
(In reply to comment #5)

> I see that this is only half of this report though, the problem with launching
> firefox seems to be related to uninstalling kfmclient, so invokeBrowser
> fallsback to xdg-open which depends on $BROWSER. Actually, in which browser
> does xdg-open open the urls for you, if that's neither konqueror nor firefox??

I got the message that kfmclient cannot be opened.
Comment 7 David Faure 2009-03-20 23:06:20 UTC
(In reply to comment #6)

I can't reproduce that. Do you get that error also when typing 
xdg-open http://www.kde.org
in a terminal?
I removed kfmclient and chose firefox as web browser in System Settings, and then any url would open in firefox, even the bugs.kde.org link in the "Help/Report Bug" dialog (which ends up calling xdg-open when kfmclient isn't around). In such a case, the kde setting for the webbrowser isn't actually used, though, it ends up being xdg-open's responsibility to find a browser.

Or is the error from KDE? (i.e. xdg-open works, but kde isn't calling it)?
In that case please try a more recent version of KDE, I have the feeling this was exactly my fix in KToolInvocation.
Comment 8 David Faure 2009-03-20 23:09:15 UTC
SVN commit 942059 by dfaure:

Move keditfiletype to runtime since it's actually needed by KPropertiesDialog.
This also makes it possible to configure kde-wide file associations even without konqueror installed.
BUG: 179355


 M  +0 -1      apps/konqueror/settings/CMakeLists.txt  
 D             apps/konqueror/settings/filetypes (directory)  
 M  +1 -0      runtime/CMakeLists.txt  
 AM            runtime/keditfiletype (directory)   apps/konqueror/settings/filetypes#941928
 A             runtime/keditfiletype/mimetypewriter.cpp   apps/konqueror/settings/filetypes/mimetypewriter.cpp#941945 [License: GPL (v2/3+eV)]
 A             runtime/keditfiletype/mimetypewriter.h   apps/konqueror/settings/filetypes/mimetypewriter.h#941945 [License: GENERATED FILE]
 A             runtime/keditfiletype/sharedmimeinfoversion.cpp   apps/konqueror/settings/filetypes/sharedmimeinfoversion.cpp#941945 [License: GPL (v2/3+eV)]


WebSVN link: http://websvn.kde.org/?view=rev&revision=942059