Version: 2.0-SVN (using Devel) Compiler: g++ OS: Linux Installed from: Compiled sources To increase the compatibility with my IPOD Nano 4G and also to test some little things with the code of the device-applet i installed libgpod 0.7.0rc1. Cmake Checks were made without errors, libgpod 0.7.0rc1 was found. But when compiling the IpodHandler.cpp make exits with the following: http://pastebin.com/d63d7e548 Sorry its in German but i don't know how to switch it for now. The Errors will probably be something like: Error: »itdb_thumb_get_gdk_pixbuf« was not define in that ?(Range)? ?(area of validity)? When libgpod is installed in version 0.7.0rc1, the IpodHandler of an existing installation can't be load too.
Have you tried again with the latest trunk?
I tried it yesterday evening with Revision: 898317, Changed 2008-12-18 00:05:12 +0100 (Do, 18. Dez 2008) by you! With the latest Rev. 898507 i have not tried, will do it later or tomorrow, im a little bit busy atm. ^^
Checked it, it exits with the same Errors but now, in other lines. But other lines are likely cause you deleted some lines whereelse. Heres the Pastebin: http://pastebin.com/d537a134e
I did a diff between itdb.h of libgpod 0.6.0 and the one of 0.7.0 The make errors are because some artwork variables like ITDB_THUMB_COVER_SMALL are not longer declared in libgpod 0.7.0 Unfortunately my C++ Skills are not so good that i could write something to correct this for me. Later there should be a query which version of Libgpod is installed.
I compiled it with libgpod 0.7.0rc1 now. Based on the DIFFS mentioned above, I uncommented half of the "Getcoverart"-Function in /src/collection/ipodcollection/handler/Ipodhandler.cpp After that, compiling worked. I hoped with the new libgpod would the coverArt-Bug be resolved, but I was wrong. Seems to be an amarok bug.
I mean, commented out, not uncommented
I reopen this because I think it can better be found here. Unless the code was not changed this should stay open so that it cannot be forgotten to fix. Accordingly its not such a mayor bug but libgpod 0.7.0 will be released soon I think. And when that happens there should be at least a little workaround to avoid the make error.
Yes, I've talked to one of the libgpod devs some time ago and am waiting for it to be released. Given the amount of improvements coming with libgpod 0.7.0, the accommodation for recognition of more devices will definitely happen, although both 0.6.0 and 0.7.0 will be supported since distros will not likely package it immediately, or will have it in their unstable branch for a while.
@xevix: FYI, if libgpod 0.7.0 provides marked improvements, then we should use it as a base, and simply drop 0.6.0 support. This will simply force distros to upgrade to libgpod 0.7.0. which is a good thing. The time it took them to pick up earlier versions (like 0.4) was just unbearably slow. We need to push them.
I'm all for that, as I remember Debian was once stuck with no Ipod Classic support for a long time since they refused to package 0.6.0 until a release far in the future. I just don't want to get stuck in that odd situation where we depend on a newer version than is packaged for distros.
xevix: I noticed that the Problem was solved. It now compiles without changing the code. So I close here.
Jochen: Are you sure the code is fixed? I just checked trunk code (915441), and those ITDB_THUMB_COVER_SMALL is still using in IpodHandler. And I still get tons of undefined errors.
LuRan: Well, my latest builds worked fine. Maybe it is cause I'm using libgpod0.7.0rc2 instead of rc01 now. I dont have the time today to check the code. But I swear the trunk code of wednesday worked without any errors.
Reopened again.... The Patch it worked with has been removed :-(. Now Libgpod 0.7.0 has been released. The title of the report should be changed if possible.
SVN commit 916188 by awainzinger: libgpod 0.7.0? Yes we can! Notes: - libgpod 0.6.0 will likely not compile with this, go upgrade to 0.7.0 final - image size specified to libgpod generates strange gtk-related warnings at runtime, ignore them, showing artwork works - setting artwork is still disabled, will get to this eventually - CMake still not testing for version, since I still can't figure out how to make it do that and have it work right BUG:178054 CCMAIL: amarok-devel@kde.org M +1 -1 CMakeLists.txt M +3 -60 src/collection/ipodcollection/handler/IpodHandler.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=916188