Bug 177858 - Copy To/Move To should discard duplicate entries in recent folder list
Summary: Copy To/Move To should discard duplicate entries in recent folder list
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-15 16:29 UTC by Michal Ziabkowski
Modified: 2008-12-16 21:45 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Ziabkowski 2008-12-15 16:29:04 UTC
Version:           4.1.82 (using Devel)
Compiler:          gcc 4.1.2 (Gentoo 4.1.2 p1.1) 
OS:                Linux
Installed from:    Compiled sources

When using the Copy To/Move To, if you navigate manually to the same folder (instead of just clicking the list entry), you end up with multiple copies of the same directory in the recent folder list.  It would probably make sense to check whether the folder being added isn't already on the list. No sense in having duplicate entries of the same path.
Comment 1 David Faure 2008-12-15 16:42:09 UTC
I'm surprised; in my tests when developing the feature this didn't happen, and the code still checks for the url being in the list before appending it...
Are you sure the exact same url occurs twice?


Can you check the konquerorrc config file, group kuick-copy (or kuick-move if it's about moving)? Does it occur twice there?
Comment 2 Michal Ziabkowski 2008-12-15 16:55:34 UTC
Yes, after selecting /tmp as the destination 3 times I get this in konquerorrc:

[kuick-copy]
Paths[$e]=/tmp,/tmp,/tmp
Comment 3 Michal Ziabkowski 2008-12-15 17:03:22 UTC
Just noticed something: this only happens when using the "Root Folder" submenu. Couldn't reproduce it with "Browse..." or "Home Folder".
Comment 4 FiNeX 2008-12-16 20:29:00 UTC
Does it happens only using konqueror or even in dolphin?
Comment 5 Michal Ziabkowski 2008-12-16 20:43:50 UTC
Both. It hit me first in Dolphin, but I reproduced it in Konqueror as well.
Comment 6 David Faure 2008-12-16 20:58:44 UTC
Logical, since the code is shared :-)

I can reproduce this indeed. Not when selecting the "recent entry", but when using the Root Folder -> tmp entry. Debugging it now.
Comment 7 David Faure 2008-12-16 21:01:45 UTC
Found the reason, the code wants to add //tmp, which doesn't match the existing /tmp ;-)
Comment 8 David Faure 2008-12-16 21:45:54 UTC
SVN commit 897797 by dfaure:

Fix duplicated entries in the recent folder list of the Copy To / Move To submenus, was due to /tmp != //tmp.
BUG: 177858


 M  +4 -1      konq_copytomenu.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=897797