Bug 177678 - Simplelauncher: favorites changes aren't applied until Plasma is restarted
Summary: Simplelauncher: favorites changes aren't applied until Plasma is restarted
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Plasma
Component: widget-kickoff (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-13 14:11 UTC by Michal Ziabkowski
Modified: 2009-01-16 21:18 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Ziabkowski 2008-12-13 14:11:31 UTC
Version:            (using Devel)
Compiler:          4.1.2 (Gentoo 4.1.2 p1.1) 
OS:                Linux
Installed from:    Compiled sources

Steps to reproduce:
1) Switch Simplelauncher into Kickoff mode.
2) Add a program to bookmarks.
3) Switch back to Simplelauncher.

The new shortcut won't be there, until Plasma is restarted.
Comment 1 Sebastian Sauer 2008-12-14 07:05:40 UTC
Seems I cannot reproduce this one. If I have konqi open and choose Bookmarks=>Add Bookmark and then open the simplemenu with view=bookmark then the new bookmark is visible. Same with deleting the bookmark again.
Comment 2 Michal Ziabkowski 2008-12-14 13:34:07 UTC
Actually, I meant Favorites. Sorry for not making myself clear.
Comment 3 Sebastian Sauer 2008-12-14 23:35:56 UTC
Thanks for the report, Michael. And I can confirm that one now :)
Comment 4 Michal Ziabkowski 2009-01-02 21:26:19 UTC
Still there in 4.1.87.
Comment 5 Sebastian Sauer 2009-01-14 05:42:09 UTC
Fixed with r910752 in trunk (upcoming 4.3) now. Cause of the offensive patch I fear we wan't backport it to 4.2 :-/

Thanks for your feedback Michal!
Comment 6 Nicolas L. 2009-01-16 21:18:28 UTC
with this commit a user reported a crash

the crash seems related to this part of code that assert is in void MenuView::rowsInserted(const QModelIndex& parent, int start, int end)
 and is :

    QMenu *menu = menuAction->menu();
    Q_ASSERT(menu);



Une erreur fatale s'est produite
The application Espace de travail Plasma (plasma) crashed and caused the signal
6 (SIGABRT).
Please help us improve the software you use by filing a report at
http://bugs.kde.org. Useful details include how to reproduce the error,
documents that were loaded, etc.

Veuillez attacher les informations suivantes à votre rapport de bogue :

Application : Espace de travail Plasma (plasma), signal SIGABRT
[Current thread is 1 (Thread 0xb536b6d0 (LWP 4858))]

Thread 3 (Thread 0xa9b9fb90 (LWP 4859)):
#0  0xffffe424 in __kernel_vsyscall ()
#1  0xb592cb95 in pthread_cond_wait@@GLIBC_2.3.2 () from
/lib/i686/libpthread.so.0
#2  0xb7fde21d in pthread_cond_wait () from /lib/i686/libc.so.6
#3  0xb695d9bb in QWaitCondition::wait (this=0xa308ae8, mutex=0xa308ae4,
time=4294967295) at thread/qwaitcondition_unix.cpp:82
#4  0xb59ca54c in QHostInfoAgent::run (this=0xa308ad8) at
kernel/qhostinfo.cpp:241
#5  0xb695c8af in QThreadPrivate::start (arg=0xa308ad8) at
thread/qthread_unix.cpp:185
#6  0xb5929315 in start_thread () from /lib/i686/libpthread.so.0
#7  0xb7fd0dde in clone () from /lib/i686/libc.so.6

Thread 2 (Thread 0xa934fb90 (LWP 4862)):
#0  0xffffe424 in __kernel_vsyscall ()
#1  0xb592cb95 in pthread_cond_wait@@GLIBC_2.3.2 () from
/lib/i686/libpthread.so.0
#2  0xb7fde21d in pthread_cond_wait () from /lib/i686/libc.so.6
#3  0xb695d9bb in QWaitCondition::wait (this=0x9f76fa8, mutex=0x9f76fa4,
time=4294967295) at thread/qwaitcondition_unix.cpp:82
#4  0xaa240d3e in RenderThread::run (this=0x9f76f9c) at
/usr/src/debug/kdebase-workspace-4.1.96/plasma/wallpapers/image/renderthread.cpp:91
#5  0xb695c8af in QThreadPrivate::start (arg=0x9f76f9c) at
thread/qthread_unix.cpp:185
#6  0xb5929315 in start_thread () from /lib/i686/libpthread.so.0
#7  0xb7fd0dde in clone () from /lib/i686/libc.so.6

Thread 1 (Thread 0xb536b6d0 (LWP 4858)):
[KCrash Handler]
#6  0xffffe424 in __kernel_vsyscall ()
#7  0xb7f21d90 in raise () from /lib/i686/libc.so.6
#8  0xb7f237f8 in abort () from /lib/i686/libc.so.6
#9  0xb6954445 in qt_message_output (msgType=QtFatalMsg, 
    buf=0xbf9e8990 "ASSERT: \"menu\" in file
/home/mandrake/rpm/BUILD/kdebase-workspace-4.1.96/plasma/applets/kickoff/simpleapplet/menuview.cpp,
line 297") at global/qglobal.cpp:2102
#10 0xb6954535 in qFatal (msg=0xb6aa7b98 "ASSERT: \"%s\" in file %s, line %d")
at global/qglobal.cpp:2303
#11 0xb69545e5 in qt_assert (assertion=0xaa0e791c "menu", file=0xaa0e77e4
"/home/mandrake/rpm/BUILD/kdebase-workspace-4.1.96/plasma/applets/kickoff/simpleapplet/menuview.cpp",
line=297)
    at global/qglobal.cpp:1872
#12 0xaa0dbfb0 in Kickoff::MenuView::rowsAboutToBeInserted (this=0xa59bbd0,
parent=@0xbf9eab70, start=0, end=0)
    at
/usr/src/debug/kdebase-workspace-4.1.96/plasma/applets/kickoff/simpleapplet/menuview.cpp:297
#13 0xaa0dc515 in Kickoff::MenuView::qt_metacall (this=0xa59bbd0,
_c=QMetaObject::InvokeMetaMethod, _id=1, _a=0xbf9eab08)
    at
/usr/src/debug/kdebase-workspace-4.1.96/build/plasma/applets/kickoff/menuview.moc:76
#14 0xb6a6acad in QMetaObject::activate (sender=0xa59f838, from_signal_index=8,
to_signal_index=8, argv=0xbf9eab08) at kernel/qobject.cpp:3031
#15 0xb6a6bab5 in QMetaObject::activate (sender=0xa59f838, m=0xb6b3c8f8,
local_signal_index=4, argv=0xbf9eab08) at kernel/qobject.cpp:3101
#16 0xb6aa6135 in QAbstractItemModel::rowsAboutToBeInserted (this=0xa59f838,
_t1=@0xbf9eab70, _t2=0, _t3=0) at
.moc/release-shared/moc_qabstractitemmodel.cpp:150
#17 0xb6a501fa in QAbstractItemModel::beginInsertRows (this=0xa59f838,
parent=@0xbf9eab70, first=0, last=0) at kernel/qabstractitemmodel.cpp:2074
#18 0xb725d238 in QStandardItemModelPrivate::rowsAboutToBeInserted
(this=0xa59f850, parent=0xa345f28, start=0, end=0) at
itemviews/qstandarditemmodel.cpp:483
#19 0xb72610ba in QStandardItemPrivate::insertRows (this=0xa584ce0, row=0,
count=1, items=@0xbf9eac20) at itemviews/qstandarditemmodel.cpp:374
#20 0xb7263b91 in QStandardItem::insertRow (this=0xa345f28, row=0,
items=@0xbf9eac20) at itemviews/qstandarditemmodel.cpp:1429
#21 0xaa0ae9fa in QStandardItem::insertRow (this=0xa345f28, arow=0,
aitem=0x9fbdc50) at /usr/lib/qt4/include/QtGui/qstandarditemmodel.h:307
#22 0xaa0b7ee3 in Kickoff::RecentlyUsedModel::Private::addRecentApplication
(this=0xa59f990, service={d = 0xbf9eac94}, append=false)
    at
/usr/src/debug/kdebase-workspace-4.1.96/plasma/applets/kickoff/core/recentlyusedmodel.cpp:70
#23 0xaa0b5fbf in Kickoff::RecentlyUsedModel::recentApplicationAdded
(this=0xa59f838, service={d = 0xbf9eacc8})
    at
/usr/src/debug/kdebase-workspace-4.1.96/plasma/applets/kickoff/core/recentlyusedmodel.cpp:160
#24 0xaa0b627c in Kickoff::RecentlyUsedModel::qt_metacall (this=0xa59f838,
_c=QMetaObject::InvokeMetaMethod, _id=5, _a=0xbf9ead8c)
    at
/usr/src/debug/kdebase-workspace-4.1.96/build/plasma/applets/kickoff/recentlyusedmodel.moc:85
#25 0xb6a6acad in QMetaObject::activate (sender=0xa599164, from_signal_index=4,
to_signal_index=4, argv=0xbf9ead8c) at kernel/qobject.cpp:3031
#26 0xb6a6bab5 in QMetaObject::activate (sender=0xa599164, m=0xaa0fa9f4,
local_signal_index=0, argv=0xbf9ead8c) at kernel/qobject.cpp:3101
#27 0xaa0b25bd in Kickoff::RecentApplications::applicationAdded
(this=0xa599164, _t1={d = 0xbf9eade8}, _t2=1)
    at
/usr/src/debug/kdebase-workspace-4.1.96/build/plasma/applets/kickoff/recentapplications.moc:90
#28 0xaa0b29ed in Kickoff::RecentApplications::add (this=0xa599164, service={d
= 0xbf9eae54}) at
/usr/src/debug/kdebase-workspace-4.1.96/plasma/applets/kickoff/core/recentapplications.cpp:181
#29 0xaa0c134e in Kickoff::ServiceItemHandler::openUrl (this=0xa1dfac8,
url=@0xbf9eaeb0) at
/usr/src/debug/kdebase-workspace-4.1.96/plasma/applets/kickoff/core/itemhandlers.cpp:55
#30 0xaa0bfd36 in Kickoff::UrlItemLauncher::Private::openUrl
(urlString=@0xbf9eaf58) at
/usr/src/debug/kdebase-workspace-4.1.96/plasma/applets/kickoff/core/urlitemlauncher.cpp:76
#31 0xaa0bf154 in Kickoff::UrlItemLauncher::openItem (this=0xa5f7910,
index=@0xbf9eaf80) at
/usr/src/debug/kdebase-workspace-4.1.96/plasma/applets/kickoff/core/urlitemlauncher.cpp:118
#32 0xaa0dc2e1 in Kickoff::MenuView::actionTriggered (this=0xa5f7928,
action=0xa30eb70) at
/usr/src/debug/kdebase-workspace-4.1.96/plasma/applets/kickoff/simpleapplet/menuview.cpp:390
#33 0xaa0de157 in MenuLauncherApplet::actionTriggered (this=0xa14d590,
action=0xa30eb70) at
/usr/src/debug/kdebase-workspace-4.1.96/plasma/applets/kickoff/simpleapplet/simpleapplet.cpp:579
#34 0xaa0dfd81 in MenuLauncherApplet::qt_metacall (this=0xa14d590,
_c=QMetaObject::InvokeMetaMethod, _id=5, _a=0xbf9eb100)
    at
/usr/src/debug/kdebase-workspace-4.1.96/build/plasma/applets/kickoff/simpleapplet.moc:103
#35 0xb6a6acad in QMetaObject::activate (sender=0xa5864e0,
from_signal_index=29, to_signal_index=29, argv=0xbf9eb100) at
kernel/qobject.cpp:3031
#36 0xb6a6bab5 in QMetaObject::activate (sender=0xa5864e0, m=0xb74bfe88,
local_signal_index=2, argv=0xbf9eb100) at kernel/qobject.cpp:3101
#37 0xb70c57e5 in QMenu::triggered (this=0xa5864e0, _t1=0xa30eb70) at
.moc/release-shared/moc_qmenu.cpp:156
#38 0xb70cd611 in QMenuPrivate::activateAction (this=0xa609920,
action=0xa30eb70, action_e=QAction::Trigger, self=true) at
widgets/qmenu.cpp:1012
#39 0xb70ce2c4 in QMenu::mouseReleaseEvent (this=0xa5fb070, e=0xbf9eb7d8) at
widgets/qmenu.cpp:2169
#40 0xb79a10fa in KMenu::mouseReleaseEvent (this=0xa5fb070, e=0xbf9eb7d8) at
/usr/src/debug/kdelibs-4.1.96/kdeui/widgets/kmenu.cpp:454
#41 0xb6d309ba in QWidget::event (this=0xa5fb070, event=0xbf9eb7d8) at
kernel/qwidget.cpp:7163
#42 0xb70d0664 in QMenu::event (this=0xa5fb070, e=0xbf9eb7d8) at
widgets/qmenu.cpp:2265
#43 0xb6cd5fac in QApplicationPrivate::notify_helper (this=0x9e6f6e0,
receiver=0xa5fb070, e=0xbf9eb7d8) at kernel/qapplication.cpp:3803
#44 0xb6cdebbf in QApplication::notify (this=0x9e4c8f8, receiver=0xa5fb070,
e=0xbf9eb7d8) at kernel/qapplication.cpp:3528
#45 0xb78c8da0 in KApplication::notify (this=0x9e4c8f8, receiver=0xa5fb070,
event=0xbf9eb7d8) at
/usr/src/debug/kdelibs-4.1.96/kdeui/kernel/kapplication.cpp:307
#46 0xb6a55873 in QCoreApplication::notifyInternal (this=0x9e4c8f8,
receiver=0xa5fb070, event=0xbf9eb7d8) at kernel/qcoreapplication.cpp:587
#47 0xb6cddde1 in QApplicationPrivate::sendMouseEvent (receiver=0xa5fb070,
event=0xbf9eb7d8, alienWidget=0x0, nativeWidget=0xa5fb070,
buttonDown=0xb74d63f0, lastMouseReceiver=@0xb74d63f4)
    at ../../src/corelib/kernel/qcoreapplication.h:212
#48 0xb6d4af8a in QETWidget::translateMouseEvent (this=0xa5fb070,
event=0xbf9ebd8c) at kernel/qapplication_x11.cpp:3978
#49 0xb6d4a1a0 in QApplication::x11ProcessEvent (this=0x9e4c8f8,
event=0xbf9ebd8c) at kernel/qapplication_x11.cpp:3040
#50 0xb6d73224 in x11EventSourceDispatch (s=0x9e726f8, callback=0,
user_data=0x0) at kernel/qguieventdispatcher_glib.cpp:142
#51 0xb57c9cea in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
#52 0xb57cd408 in ?? () from /usr/lib/libglib-2.0.so.0
#53 0xb57cd5c8 in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0
#54 0xb6a8136a in QEventDispatcherGlib::processEvents (this=0x9e6c5f0, flags={i
= -1080115400}) at kernel/qeventdispatcher_glib.cpp:319
#55 0xb6d7297a in QGuiEventDispatcherGlib::processEvents (this=0x9e6c5f0,
flags={i = -1080115352}) at kernel/qguieventdispatcher_glib.cpp:198
#56 0xb6a53ee3 in QEventLoop::processEvents (this=0xbf9ebfe0, flags={i =
-1080115288}) at kernel/qeventloop.cpp:143
#57 0xb6a540a1 in QEventLoop::exec (this=0xbf9ebfe0, flags={i = -1080115224})
at kernel/qeventloop.cpp:194
#58 0xb6a56812 in QCoreApplication::exec () at kernel/qcoreapplication.cpp:845
#59 0xb6cd5e14 in QApplication::exec () at kernel/qapplication.cpp:3331
#60 0xb8072721 in kdemain (argc=1, argv=0xbf9ec184) at
/usr/src/debug/kdebase-workspace-4.1.96/plasma/shells/desktop/main.cpp:54
#61 0x0804856f in main (argc=) at
/usr/src/debug/kdebase-workspace-4.1.96/build/plasma/shells/desktop/plasma_qgv_dummy.cpp:3