Bug 177501 - undo button or function missing
Summary: undo button or function missing
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 0.7.2
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
: 229269 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-12-11 16:26 UTC by Patrick Fehr
Modified: 2013-06-03 20:47 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.11.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Fehr 2008-12-11 16:26:24 UTC
Version:           0.7.2 (using KDE 4.1.2)
OS:                Linux
Installed from:    Ubuntu Packages

There is no undo-function for adding review annotations. 

And it is a bug, that sometimes my annotations don't get saved even if I save them.
Comment 1 Pino Toscano 2008-12-11 16:34:51 UTC
> And it is a bug, that sometimes my annotations don't get saved even if I save
> them.

You cannot "save" annotations. What do you really mean?
(Again, offtopic wrt the bug topic.)
Comment 2 Alvaro Aguilera 2009-06-13 18:37:36 UTC
This is a big PITA. 

Given that the yellow highlighter doesn't work that well with non-trivial page layouts, I find myself deleting wrong marks as soon as I start marking something. 

With the current version of okular, you have to open the navigation sidebar, go to reviews, look for the last one and delete it. An "undo" option (with the usual Ctrl+Z shortcut) would make life a lot easier.

Another usability improvement would be to leave the highlighter tool selected after marking something. Again, with a non-trivial layout, you not only have to mark line by line, but also select the highlighter tool every single time.
Comment 3 Carl 2009-09-02 10:18:21 UTC
+1 for this request. I sometimes find myself marking a wrong sentence and would love to be able to press Ctrl-Z and undo the last review action. Would be a big timesaver.
Comment 4 Pino Toscano 2010-03-03 17:30:10 UTC
*** Bug 229269 has been marked as a duplicate of this bug. ***
Comment 5 Mat 2010-11-12 21:03:33 UTC
this bug is a REAL productivity-killer ! :(

this still even seems to exist with okular 0.11.2 from KDE 4.5.3

(Gentoo ~amd64 with qt 4.7.1)

please add an undo-functionality such as at least an undo-button or ctrl+z to undo it via an shortcut

Many thanks in advance ! :)
Comment 6 Jesse Taylor 2011-03-13 05:05:15 UTC
+1 for fixing this usability bug.

Maybe I'll soon get around to setting up a development environment for KDE (I don't use KDE as a desktop), so I can write a patch for this.

Basically, I was going to make it where whenever the Annotations toolbar is open, there will be Undo/Redo options listed in the Edit menu which will be connected by default with key shortcuts CTRL+Z/CTRL+R, respectively.

Is there anyone that would have a problem with me adding this, before I take the time to get set up and write a patch?
Comment 7 Albert Astals Cid 2011-03-13 13:25:15 UTC
This is *not* a usability bug, it's a missing feature.

That said, of course if you implement it it will be considered for inclusion.
Comment 8 Alvaro Aguilera 2011-03-13 13:37:23 UTC
>Is there anyone that would have a problem with me adding this, before I take
>the time to get set up and write a patch?

I won't. Since you may encounter some resistance if your patches include words like "edit" or "undo", please announce them here so that people like me can apply them, even if they don't make it into the official version.

Thanks!
Comment 9 Albert Astals Cid 2011-03-13 15:40:41 UTC
@Alvaro: "Since you may encounter some resistance if your patches include words
like "edit" or "undo""

Sorry?
Comment 10 Yevheniy 2013-01-17 18:16:58 UTC
*** This bug has been confirmed by popular vote. ***
Comment 11 mutlu inek 2013-04-08 07:37:34 UTC
IIUC, this is fixed in trunk.
Comment 12 Albert Astals Cid 2013-04-08 18:22:34 UTC
Only for annotations, not for forms
Comment 13 Albert Astals Cid 2013-06-03 20:47:41 UTC
Git commit b7ce9114c56a08770cc2f45abd67ca7d2f8dec51 by Albert Astals Cid, on behalf of Jon Mease.
Committed on 03/06/2013 at 22:46.
Pushed by aacid into branch 'master'.

Undo support for PDF forms

Together with the already commited support for undo in annotations fixes 177501
REVIEW: 110589
FIXED-IN: 4.11.0

M  +49   -0    core/document.cpp
M  +83   -0    core/document.h
M  +205  -0    core/documentcommands.cpp
M  +95   -1    core/documentcommands_p.h
M  +572  -65   ui/formwidgets.cpp
M  +119  -11   ui/formwidgets.h
M  +15   -10   ui/pageview.cpp
M  +1    -1    ui/pageview.h

http://commits.kde.org/okular/b7ce9114c56a08770cc2f45abd67ca7d2f8dec51