Bug 177449 - Enter doesn't wait the game out in Killbots
Summary: Enter doesn't wait the game out in Killbots
Status: RESOLVED FIXED
Alias: None
Product: killbots
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Parker Coates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-11 01:01 UTC by David Benjamin
Modified: 2008-12-13 17:31 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Benjamin 2008-12-11 01:01:36 UTC
Version:            (using Devel)
OS:                Linux
Installed from:    Compiled sources

In the default configuration, the menus imply that pressing Enter waits the rest of the game out, but it does not appear to in trunk.
Comment 1 Parker Coates 2008-12-11 14:24:30 UTC
Did you try both the main enter key and the numeric keypad enter key? This might be a case of Qt treating them differently. I'm out of the country and away from my dev machine, so I can't confirm this behaviour at this time.

My intention was to have two sets of shortcuts: one using only the keypad (the primary set) and one using only letter keys (the alternate set), but if this is going to cause confusion over the enter keys, then maybe I should be rethinking that.
Comment 2 David Benjamin 2008-12-11 18:09:06 UTC
(I'm on a laptop and don't actually have a numpad enter key, but Fn+Enter seems to send the right keycode.)

Using the "numpad"'s enter does indeed work.
Comment 3 Albert Astals Cid 2008-12-11 20:18:39 UTC
Hmm, here if i press numeric Enter it enters an infinite waiting state until i'm killed, it's that the intended behaviour?
Comment 4 Parker Coates 2008-12-11 20:27:28 UTC
@Albert

Yes, that's the intended behaviour, except that you're supposed to be skilled enough to not die. ;)

The idea is that you get the hero into a situation where you can complete the round without having to move. You get bonus points and/or energy for each enemy destroyed while that happens, so the goal is to get yourself into such a position as soon as possible.
Comment 5 Albert Astals Cid 2008-12-11 20:40:41 UTC
Ok, then i think you can close the bug, unless you want it to work with return too.
Comment 6 Parker Coates 2008-12-11 20:47:44 UTC
I'm going to leave it open until I've had a chance to play with Qt and KShortcutsDialog's handling of the enter/return keys. The shortcuts certainly won't change before 4.2.
Comment 7 Parker Coates 2008-12-13 17:27:49 UTC
Okay. So Qt (and presumably X) treats the return key (above the left shift) and the enter (on the numpad) as entirely different entities. The problem is that most modern keyboards label both keys as 'Enter'.

The only way I see to clear this up is to change the shortcut.
Comment 8 Parker Coates 2008-12-13 17:31:13 UTC
SVN commit 896497 by coates:

Change the primary shortcut for 'Wait Out Round' to '*' to avoid 
confusion between around the naming of the 'enter' and 'return' keys. 
The enter key was a bit to easy to hit for such a dangerous action 
anyway. Hopefully I don't yet have enough users for this change to 
bother anyone.

BUG: 177449


 M  +13 -13    mainwindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=896497