Bug 176925 - Center wallpaper positioning of images smaller than screen is incorrect
Summary: Center wallpaper positioning of images smaller than screen is incorrect
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Plasma
Component: desktop (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-04 22:33 UTC by Marian Kyral
Modified: 2008-12-05 21:23 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot when the centered positiong is selected (61.87 KB, image/png)
2008-12-04 22:34 UTC, Marian Kyral
Details
When scalled, keep proportions is selected (60.00 KB, image/png)
2008-12-04 22:36 UTC, Marian Kyral
Details
Gwenview fullscreen preview, how it should looks like (363.02 KB, image/png)
2008-12-04 22:37 UTC, Marian Kyral
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marian Kyral 2008-12-04 22:33:34 UTC
Version:           4.1.80 (using Devel)
Compiler:          gcc-4.3.2 x86_64-pc-linux-gnu-4.3.2 
OS:                Linux
Installed from:    Compiled sources

I have an image 1000x708, screen resolution is 1280x800.

When I select this image as a wallpaper and change the wallpaper position to "Centered", the image is incorrectly scaled to the whole screen.
Also Tiled and Tiled center positioning looks very bad. The image is always scaled and is bigger than the screen resolution.

Expected result: The image is in the center of the screen and there is a color border around.
Comment 1 Marian Kyral 2008-12-04 22:34:55 UTC
Created attachment 29044 [details]
Screenshot when the centered positiong is selected
Comment 2 Marian Kyral 2008-12-04 22:36:06 UTC
Created attachment 29045 [details]
When scalled, keep proportions is selected
Comment 3 Marian Kyral 2008-12-04 22:37:26 UTC
Created attachment 29046 [details]
Gwenview fullscreen preview, how it should looks like
Comment 4 Marian Kyral 2008-12-04 23:22:17 UTC
I've played with this for a while and it seems that setting to positioning to "Centered" has the same effect as "Scaled & Cropped"
Comment 5 Aaron J. Seigo 2008-12-05 21:23:30 UTC
SVN commit 893037 by aseigo:

only scale the size of the image by the ratio when we are going to actually scale the final image
BUG:176925


 M  +4 -0      image.cpp  
 M  +24 -23    renderthread.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=893037