Bug 176086 - Recursive slideshow only shows last album
Summary: Recursive slideshow only shows last album
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Generic-SlideShow (show other bugs)
Version: 0.10.0
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-25 21:21 UTC by Yann LE HIR
Modified: 2012-06-27 11:25 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 0.10.0


Attachments
Patch file that solves the bug. (399 bytes, patch)
2008-11-25 21:23 UTC, Yann LE HIR
Details
patch#2 (640 bytes, patch)
2008-11-25 22:04 UTC, Andi Clemens
Details
patch (560 bytes, patch)
2008-11-25 23:56 UTC, Yann LE HIR
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yann LE HIR 2008-11-25 21:21:52 UTC
Version:           SVN-888882 (using KDE 4.1.3)
Compiler:          cmake version 2.6-patch 2, gcc 4.1.2 (Gentoo 4.1.2 p1.0.2) 
OS:                Linux
Installed from:    Gentoo Packages

I was just hacking around trying to add a new slideshow system and I find out that asking digikam for a recursive slideshow only shows the last album.
Comment 1 Yann LE HIR 2008-11-25 21:23:45 UTC
Created attachment 28821 [details]
Patch file that solves the bug.
Comment 2 Andi Clemens 2008-11-25 21:59:09 UTC
There seem to be more problems. I have applied the patch (but with a foreach loop) and started the slideshow for a folder without subfolders.
Using All (F9) loads all images into the slideshow, but using "With Subfolders" does not load all images.
Same for a folder with subfolders. Recursive view mode displays more images then the slideshow loads.

Gilles, Marcel,

any idea?

Andi
Comment 3 Andi Clemens 2008-11-25 22:04:05 UTC
Created attachment 28822 [details]
patch#2

slighty different patch (like in KDE3 branch)
Comment 4 Yann LE HIR 2008-11-25 22:46:17 UTC
I didn't know of the second bug, which is actually completly independent from the first one.

I checked with a 16 images album, recursive mode and All mode works fine, but with a 2,000 images, the recursive mode only has 201 images.
I tried multiple times with different albums, always 201 images.

Same bug with latest digikam 0.9.5-svn

Some limits with ImageInfoJob ?
Comment 5 Yann LE HIR 2008-11-25 23:54:52 UTC
Ok, I figured it out. Each time a slotItemsInfo is thrown, ImageInfoAlbumsJob changes of album, it should only change of album when signalCompleted is thrown.
Comment 6 Yann LE HIR 2008-11-25 23:56:06 UTC
Created attachment 28827 [details]
patch
Comment 7 caulier.gilles 2008-12-03 16:49:03 UTC
Andi,

yann has updated patch for you...

Gilles
Comment 8 Andi Clemens 2008-12-03 17:03:36 UTC
Sounds fine, works fine... I will commit it.

Andi
Comment 9 Andi Clemens 2008-12-03 17:06:07 UTC
SVN commit 892133 by aclemens:

patch by yann LE HIR: fix recursive slideshow

BUG:176086

 M  +1 -11     imageinfoalbumsjob.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=892133