Two problems in current trunk: - when you've only a file transfer and, while the download is active, you click on "delete selected", the transfer list is emptied, but the title bar still has the last % value. - when you have 2 file transfer and you stop the first and, after a while, you stop the second one, the % on the title is related to the last stopped transfer. Instead if you stop them togheter the % is calculated from both. bye
Created attachment 28727 [details] Update the mainwindow window title when a transfer is removed or stopped Attach a patch to solve this problems: 1- Update the kget window title when a transfer is removed too (MainWindowGroupObserver::removedTransferEvent) 2- We only show the percent of the active transfers (Call to updateTitle when a transfer status is changed)
@Javier: I've tested the patch and it works perfectly. You can commit it :-) Thanks!
No, it's wrong actually... If a Transfer's status changes the group status does not automatically change... ;) We should better go with a clean sollution, probably update the title from GenericTransferObserver? Lukas
Why not tell the TransferGroup about the transfer changes using the GenericTransferObserver::transferChangedEvent ? something like transfer->group()->setGroupChange([Some conversion between the transfer and the group changeFlags], true);
It's a change of the Transfer, not of the Group actually... Lukas
SVN commit 900895 by jgoday: BUG: 175715 Add a transferObserver to the mainWindow to upload the titleBar M +23 -4 mainwindow.cpp M +20 -2 mainwindow.h WebSVN link: http://websvn.kde.org/?view=rev&revision=900895