Bug 175643 - Message sort order not remembered
Summary: Message sort order not remembered
Status: RESOLVED FIXED
Alias: None
Product: kmail
Classification: Applications
Component: new message list (show other bugs)
Version: 1.10.90
Platform: Compiled Sources Linux
: HI normal
Target Milestone: ---
Assignee: Szymon Stefanek
URL:
Keywords: triaged
: 176886 179559 180112 180444 180710 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-11-20 11:57 UTC by Maxi Schimmel
Modified: 2009-01-19 20:12 UTC (History)
8 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maxi Schimmel 2008-11-20 11:57:08 UTC
Version:           1.10.90 (using Devel)
OS:                Linux
Installed from:    Compiled sources

I have reordered my message list on two different accounts inbox folders, when I close and reopen Kmail this order preferences has been disapear and I have to reorder again.

Another thing that Kmail have to remember is the tabs disposition. I like very much to reopen Kmail and found everything in the place I put before.

Thanks guys a lot for the excelent work that make in every release of Kmail, especially on the last!
Comment 1 Maxi Schimmel 2008-11-20 12:29:36 UTC
This issue repeats inside a kmail session when I enter into another folder and come back to the previously ordered one, the order selection lost.
Comment 2 Jaime Torres 2008-11-20 12:36:10 UTC
You must have a more recent svn revision, in r886196 the tabs also dissapear from session to session.
Comment 3 Thomas McGuire 2008-11-20 13:48:24 UTC
This is a known regression, we'll work on it to get it fixed before the 4.2.0 release.
Comment 4 Thomas McGuire 2008-12-05 17:13:57 UTC
*** Bug 176886 has been marked as a duplicate of this bug. ***
Comment 5 Thomas McGuire 2009-01-04 14:10:14 UTC
*** Bug 179559 has been marked as a duplicate of this bug. ***
Comment 6 Thomas McGuire 2009-01-11 00:57:25 UTC
SVN commit 909096 by tmcguire:

Remove the sort order settings from the aggregation, and make
a stand-alone class instead, that can be saved per-folder or
globally (the default).
This should fix the problems with the message sort order not
being remembered.

Also, fix a little bug that the sort indicator of the headers
would not always be shown.

BUG: 175643


 M  +1 -0      CMakeLists.txt  
 M  +8 -166    messagelistview/core/aggregation.cpp  
 M  +2 -144    messagelistview/core/aggregation.h  
 M  +12 -109   messagelistview/core/aggregationeditor.cpp  
 M  +0 -10     messagelistview/core/aggregationeditor.h  
 M  +61 -79    messagelistview/core/manager.cpp  
 M  +5 -0      messagelistview/core/manager.h  
 M  +59 -52    messagelistview/core/model.cpp  
 M  +12 -0     messagelistview/core/model.h  
 A             messagelistview/core/sortorder.cpp   [License: GPL (v2+)]
 A             messagelistview/core/sortorder.h   [License: GPL (v2+)]
 M  +3 -3      messagelistview/core/theme.cpp  
 M  +4 -4      messagelistview/core/theme.h  
 M  +3 -3      messagelistview/core/themeeditor.cpp  
 M  +5 -24     messagelistview/core/view.cpp  
 M  +7 -0      messagelistview/core/view.h  
 M  +103 -55   messagelistview/core/widgetbase.cpp  
 M  +36 -6     messagelistview/core/widgetbase.h  
 M  +0 -3      messagelistview/pane.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=909096
Comment 7 Jaime Torres 2009-01-13 09:33:37 UTC
*** Bug 180112 has been marked as a duplicate of this bug. ***
Comment 8 Nick Shaforostoff 2009-01-13 20:08:47 UTC
*** Bug 180444 has been marked as a duplicate of this bug. ***
Comment 9 Pino Toscano 2009-01-14 19:25:52 UTC
*** Bug 180710 has been marked as a duplicate of this bug. ***
Comment 10 Richard Bos 2009-01-14 20:25:52 UTC
Problem is still present on kde-4.1.96 (kde-4.2rc1)

Comment 11 Thomas McGuire 2009-01-14 20:32:33 UTC
> Problem is still present on kde-4.1.96 (kde-4.2rc1)

Yes, not yet backported.
Comment 12 Richard Bos 2009-01-15 20:41:19 UTC
> Yes, not yet backported.

Oh, please do before kde-4.2 is officially released.  It's really (ahum)
annoying to have to change the sorting order for each and every visited
folder.  kde-4.2 will be a better place, if the code is backported :)
Comment 13 Thomas McGuire 2009-01-19 20:12:27 UTC
SVN commit 913714 by tmcguire:

Backport the sort order fixes.
I reverted all string changes, those are not very visible strings anyway.
Sorry for the very very late commit, I hope I didn't break anything and
apologize in advance.
===

Backport r909096 by tmcguire from trunk to the 4.2 branch:

Remove the sort order settings from the aggregation, and make
a stand-alone class instead, that can be saved per-folder or
globally (the default).
This should fix the problems with the message sort order not
being remembered.

Also, fix a little bug that the sort indicator of the headers
would not always be shown.

CCBUG: 175643

===

Backport r913236 by tmcguire from trunk to the 4.2 branch:

Since I decoupled the sort order from the aggregations, there
were some combinations that didn't made sense, for example grouping by
date by sorting by something different.

Fix this situation by not allowing those combinations, and using
sensible defaults instead.

===

Backport r913240 by tmcguire from trunk to the 4.2 branch:

Slightly better way to detect incorrect sort orders, as we now know the default value.

====

Backport r913666 by tmcguire from trunk to the 4.2 branch:

Fix crash.


 M  +1 -0      CMakeLists.txt  
 M  +8 -166    messagelistview/core/aggregation.cpp  
 M  +2 -144    messagelistview/core/aggregation.h  
 M  +11 -108   messagelistview/core/aggregationeditor.cpp  
 M  +0 -10     messagelistview/core/aggregationeditor.h  
 M  +49 -60    messagelistview/core/manager.cpp  
 M  +5 -0      messagelistview/core/manager.h  
 M  +57 -50    messagelistview/core/model.cpp  
 M  +12 -0     messagelistview/core/model.h  
 A             messagelistview/core/sortorder.cpp   trunk/KDE/kdepim/kmail/messagelistview/core/sortorder.cpp#909096 [License: GPL (v2+)]
 A             messagelistview/core/sortorder.h   trunk/KDE/kdepim/kmail/messagelistview/core/sortorder.h#909096 [License: GPL (v2+)]
 M  +3 -3      messagelistview/core/theme.cpp  
 M  +4 -4      messagelistview/core/theme.h  
 M  +3 -3      messagelistview/core/themeeditor.cpp  
 M  +5 -24     messagelistview/core/view.cpp  
 M  +7 -0      messagelistview/core/view.h  
 M  +113 -58   messagelistview/core/widgetbase.cpp  
 M  +36 -6     messagelistview/core/widgetbase.h  
 M  +0 -3      messagelistview/pane.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=913714