Bug 175604 - playlist displays various artists album incorrect
Summary: playlist displays various artists album incorrect
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Playlist (show other bugs)
Version: 2.0-SVN
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-19 17:47 UTC by simon
Modified: 2009-01-23 08:12 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screenshot (70.64 KB, image/png)
2008-11-19 17:48 UTC, simon
Details
another screenshot (286.93 KB, image/png)
2008-11-23 12:12 UTC, Mikko C.
Details
collection-same problem (44.16 KB, image/jpeg)
2009-01-23 08:12 UTC, vikrant
Details

Note You need to log in before you can comment on or make changes to this bug.
Description simon 2008-11-19 17:47:05 UTC
Version:           2.0-SVN (using 4.1.80 (KDE 4.1.80 (KDE 4.2 Beta1)), Gentoo)
Compiler:          x86_64-pc-linux-gnu-gcc
OS:                Linux (x86_64) release 2.6.26-tuxonice

after dragging a album with various artists (marked as "show as various") into the playlist, subsequent tracks of the same artists ar kind of grouped while the others are not (showing albumcover for each track etc)

see attached screenshot
Comment 1 simon 2008-11-19 17:48:34 UTC
Created attachment 28699 [details]
screenshot
Comment 2 Mikko C. 2008-11-23 12:09:11 UTC
I can confirm this with today's svn.
Comment 3 Mikko C. 2008-11-23 12:12:26 UTC
Created attachment 28763 [details]
another screenshot

all the tracks from the album are not grouped.
Comment 4 Mark Kretschmann 2008-11-23 14:24:38 UTC
Confirming based on Mikko's comments.
Comment 5 Nikolaj Hald Nielsen 2008-12-22 19:55:54 UTC
SVN commit 900391 by nhnielsen:

Make the grouping in the playlist depend on album pointers instead of relying on artist and album names. This should fix issues with various artist albums nto being properly grouped. Because of the new private meta registry, the scripted servies are also ok with 
this way of grouping now. Unfortunately, this gloriously breaks grouping of albums loaded with Meta::File or Meta::stream classes (even if loaded from a playlist and having correct album information) as the implementation of these classes does not lend itself 
to using the registry. Most notable is storing a playlit with a librivox book (which is loaded from the playlist again as a series of Meta::Streams). These will no longer get grouped, even though they all have the same album names.
BUG: 175604 


 M  +1 -13     GroupingProxy.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=900391
Comment 6 Rafael Tesser 2008-12-22 23:49:14 UTC
Thanks for the fix.

If I understood your explanation, then the fact of music added to the playlist not being grouped and not showing track numbers a consequence of this fix. Am I right about it? 
Comment 7 Nikolaj Hald Nielsen 2008-12-23 08:37:36 UTC
The fix only (potentially) adversely affects tracks loaded from the file browser and streams that are not loaded from a service (such as from a stored playlist)
Comment 8 vikrant 2009-01-23 08:11:51 UTC
Doesn't same problem exists in collection tab. I have an album with various artists. I have arranged by collection as Genre/Album. Attached the screenshot for same.
Comment 9 vikrant 2009-01-23 08:12:44 UTC
Created attachment 30521 [details]
collection-same problem